Skip to content

Refactor BiVAECF code#376

Merged
qtuantruong merged 7 commits intoPreferredAI:masterfrom
qtuantruong:bivae-refactor
Dec 28, 2020
Merged

Refactor BiVAECF code#376
qtuantruong merged 7 commits intoPreferredAI:masterfrom
qtuantruong:bivae-refactor

Conversation

@qtuantruong
Copy link
Copy Markdown
Member

Description

Related Issues

Checklist:

  • I have added tests.
  • I have updated the documentation accordingly.
  • I have updated README.md (if you are adding a new model).
  • I have updated examples/README.md (if you are adding a new example).
  • I have updated datasets/README.md (if you are adding a new dataset).

@qtuantruong qtuantruong requested a review from saghiles December 24, 2020 13:20
@qtuantruong
Copy link
Copy Markdown
Member Author

@saghiles I did some refactoring which should not affect the reproducibility of the model. Please take a look and see if there is anything you want to update.

@saghiles
Copy link
Copy Markdown
Member

I went through it already, and it looks all good to me. Please feel free to merge, thanks :)

@qtuantruong qtuantruong merged commit 9ed51ca into PreferredAI:master Dec 28, 2020
@qtuantruong qtuantruong deleted the bivae-refactor branch December 28, 2020 05:28
qtuantruong pushed a commit to amirj/cornac that referenced this pull request May 22, 2021
qtuantruong pushed a commit to qtuantruong/cornac that referenced this pull request Oct 25, 2025
qtuantruong added a commit to qtuantruong/cornac that referenced this pull request Oct 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants