Make it possible to specify a FeatureModality directly #374
Merged
saghiles merged 3 commits intoPreferredAI:masterfrom Dec 15, 2020
Merged
Make it possible to specify a FeatureModality directly #374saghiles merged 3 commits intoPreferredAI:masterfrom
saghiles merged 3 commits intoPreferredAI:masterfrom
Conversation
qtuantruong
reviewed
Dec 14, 2020
Member
qtuantruong
left a comment
qtuantruong
left a comment
There was a problem hiding this comment.
It looks fine. Could you please add a few test cases to cover the new changes?
qtuantruong
approved these changes
Dec 14, 2020
qtuantruong
pushed a commit
to amirj/cornac
that referenced
this pull request
May 22, 2021
qtuantruong
pushed a commit
to qtuantruong/cornac
that referenced
this pull request
Oct 25, 2025
qtuantruong
pushed a commit
to qtuantruong/cornac
that referenced
this pull request
Oct 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Checklist:
README.md(if you are adding a new model).examples/README.md(if you are adding a new example).datasets/README.md(if you are adding a new dataset).