Replaced WorkspaceFileSystemWrapper with Get-Content and Get-ChildItem#2136
Draft
dkattan wants to merge 6 commits intoPowerShell:mainfrom
Draft
Replaced WorkspaceFileSystemWrapper with Get-Content and Get-ChildItem#2136dkattan wants to merge 6 commits intoPowerShell:mainfrom
dkattan wants to merge 6 commits intoPowerShell:mainfrom
Conversation
dkattan
force-pushed
the
feature/get-content
branch
from
59af6f2 to
42c028f
Compare
Contributor
Author
|
@andyleejordan Curious your thoughts on this. It ended up being heavier-handed than I wanted with all the async changes, but I'm wondering if that would be desirable if I split it into a separate MR? I know @SeeminglyScience doesn't want me changing the public interfaces, but they likely should've been Task<> from the start, async or not. |
dkattan
force-pushed
the
feature/get-content
branch
from
42c028f to
e72a219
Compare
dkattan
changed the title
dkattan
force-pushed
the
feature/get-content
branch
from
974e92e to
1faf9f2
Compare
dkattan
changed the title
dkattan
changed the title
Collaborator
Can you talk through what you're trying to solve? When you make a synchronous method return |
dkattan
force-pushed
the
feature/get-content
branch
from
1faf9f2 to
974e92e
Compare
andyleejordan
force-pushed
the
main
branch
2 times, most recently
from
caa9e27 to
677f42c
Compare
andyleejordan
force-pushed
the
main
branch
2 times, most recently
from
80b2351 to
9ce8911
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Removes artificial Uri schema restriction, provides a mechanism for language clients to specify URIs that direct to PSProviders
PR Context