Repository navigation
refactor(skills): stop reading bundle entries from the skill menu - #1568
Conversation
A menu entry that is a bundle of variants is left out when the menu is fetched, so it is never offered or installed. The bundle installer, the bundle fields on a menu entry and the expansion of a bundle's variants are removed. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Test against a Context Mill branch:
Add Results will be posted here when complete. |
|
✅ Security review complete — No findings above the confidence threshold, in 5 min. Add the |
gewenyu99
left a comment
There was a problem hiding this comment.
🥸 Reviewed by NotVincent, totally not Vincent. The real Vincent will review it separately. Probably slop, please disregard.
| export function prepareSkillMenu(menu: SkillMenu): SkillMenu { | ||
| for (const [category, entries] of Object.entries(menu.categories)) { | ||
| const family = skillFamily(category); | ||
| menu.categories[category] = entries |
There was a problem hiding this comment.
I think this breaks replay-vision on v1.66.0, the current context-mill floor, because:
- on
v1.66.0,replay-vision-enable-replayonly ships as a bundle entry - this filter drops bundle entries, so
wizard skill replay-vision-setupand linearreplay-visioncan't find it - the categories whose only entries are bundles stay as empty arrays and still show up in
load_skill_menu
Bundle entries in the live v1.66.0 skill-menu.json:
integration-v2/capture integration-v2-capture
integration-v2/error-tracking-step integration-v2-error-tracking-step
integration-v2/init integration-v2-init
integration-v2/install integration-v2-install
replay-vision-enable-replay replay-vision-enable-replay
Maybe delete a category key once its list is empty, and either bump CONTEXT_MILL_FLOOR once a context-mill release without bundles ships, or keep reading bundles until then.
There was a problem hiding this comment.
You're right on all three points, and the gap is temporary. On 1.66.0 the published replay-vision-setup skill names replay-vision-enable-replay, which ships only as a bundle, so wizard skill replay-vision-setup and a linear replay-vision run can't install that step. wizard replay-vision on the orchestrator names integration-session-replay and is not affected.
It closes with the next context-mill release (PostHog/context-mill#537), where replay-vision-setup names integration-session-replay and the bundle is gone. That release follows this one, so we're accepting the window and not keeping the bundle reader for it. The description now lists this case.
- Empty categories: fixed in f69248f. A category that holds only bundles is left out of the menu.
CONTEXT_MILL_FLOOR: it moves up once that context-mill release is out.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
# Conflicts: # src/shared/README.md
A category whose entries are all bundles of variants was left as an empty list, so load_skill_menu listed a category with nothing in it. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Behaviour
The wizard installs a skill from its own zip, and from nothing else.
load_skill_menu, resolved, or installed.load_skill_menulists no empty category.The bundle installer, the
bundleandvariantsfields on a menu entry, and the expansion of a bundle's variants are gone.Verified
pnpm typecheckandpnpm lint(0 errors).pnpm test: 292 files, 4,474 tests pass, 1 skipped.skill-menu.test.tscovers a menu with a bundle entry: the entry is left out, its neighbour is kept, and a category of bundles alone is gone.flow-graphs.test.tsstill finds every skill the bundled prompts name on the recorded context-mill 1.66.0 menu, with its five bundle entries left out.error-trackingmenu category and installed the skill they chose from it.Rollout
This is the last of four stacked PRs that remove the old code paths. They merge together and ship in one release.
wizard-agent-dagandwizard-agent-dag-skillshave both held at 100% with no stop rule tripped, no run that fetched its prompts, and no run that fell back to an old skill.context-mill publishes bundle entries until it releases without the old step skills. Until then, a wizard with this change does not do four things:
integration-v2-install, throughinstall_skill. Onmainthat name is already not foundintegration-v2/*andreplay-vision-enable-replaymenu categories. No bundled prompt names onereplay-vision-enable-replay, which the publishedreplay-vision-setupskill names for its session replay step. That skill is read bywizard skill replay-vision-setupand by a replay-vision run on the linear sequence.wizard replay-visionon the orchestrator namesintegration-session-replayand is not affectedNo orchestrator flow reaches a bundle: every skill its prompts name is published as its own zip.
All four end with that context-mill release, in which
replay-vision-setupnamesintegration-session-replay. The oldest context-mill release the wizard accepts moves up to it afterwards.🤖 Generated with Claude Code