Repository navigation
test: remove the import-boundary scanner - #1374
Merged
gewenyu99 merged 1 commit intoSep 30, 2026
Merged
Conversation
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Test against a Context Mill branch:
Add Results will be posted here when complete. |
This was referenced Sep 29, 2026
gewenyu99
marked this pull request as ready for review
September 29, 2026 10:21
Generated-By: PostHog Desktop Task-Id: d14e92bb-6ee1-49b5-8502-39cb80079589
gewenyu99
force-pushed
the
posthog/functional-r9-01-remove-the-import-boundary-scanner
branch
from
September 30, 2026 08:44
e9f257c to
7b932f2
Compare
johncwaters
reviewed
Sep 30, 2026
johncwaters
left a comment
johncwaters
left a comment
Contributor
There was a problem hiding this comment.
Note
Automated review. Not written by a human.
Clean removal of the architecture test, its known-violations ledger, the vitest architecture project and the test:arch script. No code or CI references remain, but four docs and comments still cite the deleted test (listed below, none are in the diff, so they are not inline). Also worth confirming that the compiler-level rules from the description land before or with this merge: the deleted test also covered the shared/tui/cli/programs surface matrix and programs deep imports, which ESLint does not cover.
AGENTS.md:211: still sayspnpm test:archrejects deep@agent/*imports; the script is removed. Drop that mention..eslintrc.cjs:102: the comment says the architecture test applies the same rule to resolved paths; that test is deleted. Update the comment.src/shared/README.md:43: describes the architecture test and linksknown-violations.json, both deleted. Reword or remove.src/agent/index.ts:4: says deeper imports fail lint and the architecture test. Say lint only.
edwinyjlim
approved these changes
Sep 30, 2026
gewenyu99
deleted the
posthog/functional-r9-01-remove-the-import-boundary-scanner
branch
September 30, 2026 09:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a ledger for my own sanity. We no longer need this, up stack there is compiler level rules.