Repository navigation
fix(rust): add the tls feature to the blocking-client install - #1572
Merged
Merged
Conversation
posthog-rs 1.x turns TLS off with default features. The no-runtime install, `cargo add posthog-rs --no-default-features`, built a client that never sends to an https host. Add `--features tls`, and leave it out on posthog-rs 0.x, which has no such feature. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Test against a Context Mill branch:
Add Results will be posted here when complete. |
PR overviewNo security issues were found in this pull request. Reviews
|
edwinyjlim
approved these changes
Nov 17, 2026
|
✅ Security review complete — No findings above the confidence threshold, in 3 min. Add the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
posthog-rs 1.x turns TLS off when default features are off. For a Rust project with no async runtime, the wizard tells the agent to run
cargo add posthog-rs --no-default-features. That build has no TLS, so every capture tohttps://us.i.posthog.comfails, and becausecapture()is fire-and-forget the app runs and drops every event.posthog-rs 0.x kept TLS on with default features off, so this broke with the 1.0 release.
Changes
cargo add posthog-rs --no-default-features --features tls.--features tlson posthog-rs 0.x, which has notlsfeature, socargo adddoesn't fail on crates pinned to 0.x.How did you test this?
capture_immediateagainsthttps://example.com.default-features = falsehas no rustls inCargo.lockand fails witherror sending request. Addingfeatures = ["tls"]pulls in rustls and gets an HTTP 405 back from the host.pnpm build,pnpm typecheck, andvitest run src/services/detection/__tests__/framework.test.tspass.🤖 Generated with Claude Code