Skip to content

fix(error-tracking-upload-source-maps): require the tls feature on the Rust blocking client - #542

Open
gewenyu99 wants to merge 4 commits into
mainfrom
vincent/rust-blocking-tls
Open

gewenyu99 wants to merge 4 commits into
mainfrom
vincent/rust-blocking-tls

Conversation

@gewenyu99

Copy link
Copy Markdown
Collaborator

Problem

The Rust SDK 1.x.x turns TLS off when default-features = false. The Rust test step in error-tracking-upload-source-maps tells the agent to mirror a blocking-client build with features = ["error-tracking"] added back. On 1.x.x that build has no TLS, so the test capture to an HTTPS host fails silently and the source-map check can't pass.

Changes

  • context/skills/error-tracking-upload-source-maps/description.md:377: on the Rust SDK 1.x.x the agent also needs "tls" in the feature list, adds it if missing, and says so in the report. The Rust SDK 0.x.x has no tls feature, so the line says to leave it alone there.

How did you test this?

  • With posthog-rs 1.0.0 and the blocking client, default-features = false has no rustls in Cargo.lock, and capture_immediate to an HTTPS host fails with error sending request. Adding features = ["tls"] gets an HTTP response.
  • Prose-only change to one skill file; no build or test change.

Related: PostHog/wizard#1572 (wizard install line), PostHog/posthog.com#22475 (docs).

🤖 Generated with Claude Code

…e Rust blocking client

The Rust SDK 1.x.x turns TLS off with `default-features = false`. The
Rust test step told the agent to mirror a blocking-client build with
only `error-tracking` added back, so the test capture never reaches
PostHog. Tell it to add `tls` on 1.x.x and leave 0.x.x alone.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

🧙 Wizard CI

Run the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands:

Test all apps:

  • /wizard-ci all

Test all apps in a directory:

  • /wizard-ci ai-observability
  • /wizard-ci basic-integration
  • /wizard-ci feature-flags
  • /wizard-ci mcp-analytics
  • /wizard-ci replay-vision
  • /wizard-ci revenue
  • /wizard-ci self-driving
  • /wizard-ci warehouse
  • /wizard-ci warehouse-seeded

Test an individual app:

  • /wizard-ci ai-observability/anthropic
  • /wizard-ci ai-observability/google-adk
  • /wizard-ci ai-observability/groq
Show more apps
  • /wizard-ci ai-observability/manual-capture
  • /wizard-ci ai-observability/openai
  • /wizard-ci ai-observability/openai-agents
  • /wizard-ci ai-observability/opentelemetry
  • /wizard-ci ai-observability/vercel-ai
  • /wizard-ci basic-integration/android
  • /wizard-ci basic-integration/angular
  • /wizard-ci basic-integration/astro
  • /wizard-ci basic-integration/django
  • /wizard-ci basic-integration/fastapi
  • /wizard-ci basic-integration/flask
  • /wizard-ci basic-integration/flutter
  • /wizard-ci basic-integration/javascript-node
  • /wizard-ci basic-integration/javascript-web
  • /wizard-ci basic-integration/laravel
  • /wizard-ci basic-integration/next-js
  • /wizard-ci basic-integration/nuxt
  • /wizard-ci basic-integration/python
  • /wizard-ci basic-integration/rails
  • /wizard-ci basic-integration/react-native
  • /wizard-ci basic-integration/react-router
  • /wizard-ci basic-integration/sveltekit
  • /wizard-ci basic-integration/swift
  • /wizard-ci basic-integration/tanstack-router
  • /wizard-ci basic-integration/tanstack-start
  • /wizard-ci basic-integration/vue
  • /wizard-ci feature-flags/django
  • /wizard-ci feature-flags/next-js
  • /wizard-ci mcp-analytics/custom-dispatcher
  • /wizard-ci mcp-analytics/go-sdk
  • /wizard-ci mcp-analytics/python-sdk
  • /wizard-ci mcp-analytics/ruby-sdk
  • /wizard-ci mcp-analytics/rust-sdk
  • /wizard-ci mcp-analytics/typescript-sdk
  • /wizard-ci replay-vision/javascript-node
  • /wizard-ci replay-vision/next-js
  • /wizard-ci replay-vision/react-vite
  • /wizard-ci revenue/stripe
  • /wizard-ci self-driving/astro
  • /wizard-ci self-driving/fastapi
  • /wizard-ci self-driving/nuxt
  • /wizard-ci self-driving/react-router
  • /wizard-ci self-driving/sveltekit
  • /wizard-ci warehouse/monorepo-env
  • /wizard-ci warehouse/multi-source-next
  • /wizard-ci warehouse/stripe-node
  • /wizard-ci warehouse/zero-source
  • /wizard-ci warehouse-seeded/next-stripe
  • /wizard-ci warehouse-seeded/next-stripe-declined

Test against a wizard branch:

  • /wizard-ci all wizard:my-branch

Add wizard:<branch> to any command above to pin the wizard branch. It defaults to main.

Results will be posted here when complete.

@gewenyu99
gewenyu99 marked this pull request as ready for review November 17, 2026 22:54
@gewenyu99
gewenyu99 requested a review from a team as a code owner November 17, 2026 22:54
gewenyu99 and others added 3 commits November 17, 2026 17:55
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rectly

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant