Repository navigation
docs: add network timing to metrics spec - #66
pauldambra wants to merge 3 commits into
Conversation
Generated-By: PostHog Desktop Task-Id: 9d0220e6-7dd2-4178-ab32-75f4f5a0df11
319e8dd to
429e02b
Compare
Generated-By: PostHog Desktop Task-Id: 9d0220e6-7dd2-4178-ab32-75f4f5a0df11
|
we dont use the sdk-specs as RFC but rather the already approved/agreed spec so make sure this PR archives the current spec and change the spec directly in the PR |
Sync the network request timing requirements into openspec/specs/metrics/spec.md and move the change to the archive, as asked in review. Also fix the metrics spec so `openspec validate --specs --strict` passes: - replace a literal NUL byte with the text `\0` (git treated the file as binary) - put SHALL on the first line of the type-collision warning requirement - put MUST on the first line of the safe dimensions requirement Generated-By: PostHog Desktop Task-Id: 4805f701-2902-4ced-8fbd-e75e250fd319
|
🤖 (robot reply on behalf of @pauldambra) Thanks @marandaneto. Done in 3414b36:
I also fixed the |
|
🤖 (robot comment on behalf of @pauldambra) Closing this PR. Network request timing should follow the OpenTelemetry HTTP client semantic conventions ( |
Why
SDK maintainers need one clear Metrics contract and support record for network request timing. This prevents Session Replay support from being reported as Metrics support.
Changes
Adds Network Request Timing requirements directly to the Metrics spec, and archives the change.
Defines safe data handling and separates verified SDK support from future candidates.
Fixes the Metrics spec so strict validation passes (a NUL byte and one requirement wording).
Depends on #30.
Created with PostHog from a Slack thread