Repository navigation
refactor(plugin-server): yeet redis queue - #9865
Merged
Merged
Conversation
tiina303
force-pushed
the
yeet-plugin-server-redis-queue
branch
from
May 19, 2022 19:36
9a1d017 to
63f40ec
Compare
Twixes
marked this pull request as ready for review
May 23, 2022 18:45
Twixes
reviewed
May 23, 2022
|
|
||
| jest.mock('../../src/main/ingestion-queues/kafka-queue') | ||
|
|
||
| describe('queue', () => { |
Contributor
There was a problem hiding this comment.
This is what I refactored queue.test.ts as that was just a tiny suite making sure the Redis queue works + an even smaller suite verifying that capability settings are used. I only kept the latter as the former is already covered very well for Kafka ingestion and I don't really see the value in adapting that exact test for Kafka.
6 of 11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
For #9763
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?