Skip to content

fix(warehouse-sources): pin the parent snapshot test to a stable clock #93192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gantoine wants to merge 1 commit into from
Closed

fix(warehouse-sources): pin the parent snapshot test to a stable clock #93192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions ...s/backend/temporal/data_imports/sources/common/rest_source/tests/test_warehouse_parent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import json
import os
from datetime import UTC, datetime, timedelta
from pathlib import Path
from types import SimpleNamespace
Expand Down Expand Up @@ -66,6 +66,12 @@ def _write_multi_fragment_table(tmp_path: Path, fragments: int = 3, rows_per_fra
return uri


def _set_delta_commit_log_mtimes(uri: str, times_by_version: dict[int, datetime]) -> None:
for version, committed_at in times_by_version.items():
log = Path(uri) / "_delta_log" / f"{version:020d}.json"
os.utime(log, (committed_at.timestamp(), committed_at.timestamp()))


def _patched_resolve(uri: str, snapshot_timestamp=None, row_filter=None):
parent_schema = SimpleNamespace(
id="parent-id", normalized_s3_folder_name="issues", folder_path=lambda: "team_1_sentry_x"
Expand Down Expand Up @@ -177,19 +183,15 @@ def test_resolve_raises_when_parent_has_no_synced_table(tmp_path: Path) -> None:

def test_resolve_pins_to_last_completed_snapshot_while_parent_is_syncing(tmp_path: Path) -> None:
uri = _write_parent_table(tmp_path)
v0_table = deltalake.DeltaTable(uri)
v0 = v0_table.version()
v0_timestamp = datetime.fromtimestamp(v0_table.history()[0]["timestamp"] / 1000, tz=UTC)
v0 = deltalake.DeltaTable(uri).version()

# An in-flight full refresh has already committed a partial overwrite on top of v0.
deltalake.write_deltalake(uri, pa.table({"id": ["partial"], "last_seen": ["x"], "title": ["y"]}), mode="overwrite")
partial_refresh_log = Path(uri) / "_delta_log" / "00000000000000000001.json"
entries = partial_refresh_log.read_text().splitlines()
partial_refresh_commit = json.loads(entries[0])
partial_refresh_commit["commitInfo"]["timestamp"] = int(v0_timestamp.timestamp() * 1000) + 1
partial_refresh_log.write_text("\n".join([json.dumps(partial_refresh_commit), *entries[1:]]) + "\n")

pinned = _patched_resolve(uri, snapshot_timestamp=v0_timestamp)
snapshot_committed_at = datetime(2026, 3, 1, 12, 0, tzinfo=UTC)
_set_delta_commit_log_mtimes(uri, {v0: snapshot_committed_at, v0 + 1: snapshot_committed_at + timedelta(minutes=2)})

pinned = _patched_resolve(uri, snapshot_timestamp=snapshot_committed_at + timedelta(minutes=1))

assert pinned.version == v0

Expand Down
Loading