Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion frontend/src/scenes/experiments/ExperimentFlagKeyInput.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,14 @@ import { LemonBanner, LemonInput, LemonTable, Link } from '@posthog/lemon-ui'
import { IconOpenInNew } from 'lib/lemon-ui/icons'
import { LemonButton } from 'lib/lemon-ui/LemonButton'
import { PaginationManual } from 'lib/lemon-ui/PaginationControl'
import { hasEnded, isLaunched } from 'scenes/experiments/experimentStatus'
import { FeatureFlagFiltersSection } from 'scenes/feature-flags/FeatureFlagFilters'
import { FeatureFlagsFilters } from 'scenes/feature-flags/featureFlagsLogic'
import { urls } from 'scenes/urls'

import { Experiment, FeatureFlagType } from '~/types'

import { hasEnded, isLaunched } from 'products/experiments/frontend/experimentStatus'

import { featureFlagEligibleForExperiment } from './utils'

interface ExperimentFlagKeyInputProps {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@ import { atColumn, createdAtColumn, createdByColumn } from 'lib/lemon-ui/LemonTa
import { LemonTableLink } from 'lib/lemon-ui/LemonTable/LemonTableLink'
import type { LemonTableColumn } from 'lib/lemon-ui/LemonTable/types'
import stringWithWBR from 'lib/utils/stringWithWBR'
import { getExperimentStatus } from 'scenes/experiments/experimentStatus'
import { urls } from 'scenes/urls'

import { isLegacyExperiment } from '~/scenes/experiments/utils'
import type { Experiment } from '~/types'
import { ExperimentStatus } from '~/types'

import { StatusTag } from 'products/experiments/frontend/components/StatusTag'
import { getExperimentStatus } from 'products/experiments/frontend/experimentStatus'
import { getShippedVariantKey, isSingleVariantShipped } from 'products/experiments/frontend/scenes/experimentsLogic'

type RelatedExperimentsTableProps = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@ import { cn } from 'lib/utils/css-classes'
import { humanFriendlyDuration } from 'lib/utils/durations'
import { humanFriendlyNumber } from 'lib/utils/numbers'
import { pluralize } from 'lib/utils/strings'
import { hasEnded } from 'scenes/experiments/experimentStatus'
import { asDisplay } from 'scenes/persons/person-utils'

import { Experiment } from '~/types'

import { hasEnded } from 'products/experiments/frontend/experimentStatus'
import {
ExperimentWatchCardStrengthEnumApi,
ExperimentWatchCardKindEnumApi,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ import { LemonRadio } from 'lib/lemon-ui/LemonRadio'
import { Spinner } from 'lib/lemon-ui/Spinner'
import { Label } from 'lib/ui/Label/Label'
import { humanFriendlyDuration } from 'lib/utils/durations'
import { hasEnded } from 'scenes/experiments/experimentStatus'

import { hasEnded } from 'products/experiments/frontend/experimentStatus'

import { experimentLogic } from '../experimentLogic'

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@ import { LemonButton } from 'lib/lemon-ui/LemonButton'
import { Link } from 'lib/lemon-ui/Link'
import { Tooltip } from 'lib/lemon-ui/Tooltip'
import { pluralize } from 'lib/utils/strings'
import { isLaunched } from 'scenes/experiments/experimentStatus'
import { SessionRecordingsPlaylist } from 'scenes/session-recordings/playlist/SessionRecordingsPlaylist'
import { sessionRecordingsPlaylistLogic } from 'scenes/session-recordings/playlist/sessionRecordingsPlaylistLogic'
import { urls } from 'scenes/urls'

import { Experiment } from '~/types'

import { isLaunched } from 'products/experiments/frontend/experimentStatus'
import { experimentScannerParams } from 'products/replay_vision/frontend/replay_scanners/experimentTargeting'
import { scannerTypeLabel } from 'products/replay_vision/frontend/replay_scanners/types'

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import { featureFlagLogic } from 'lib/logic/featureFlagLogic'
import { userHasAccess } from 'lib/utils/accessControlUtils'
import { newInternalTab } from 'lib/utils/newInternalTab'
import { addProductIntentForCrossSell } from 'lib/utils/product-intents'
import { isExperimentExposureFrozen, isExperimentPaused } from 'scenes/experiments/experimentStatus'
import { organizationLogic } from 'scenes/organizationLogic'
import { projectLogic } from 'scenes/projectLogic'
import { urls } from 'scenes/urls'
Expand All @@ -39,6 +38,8 @@ import {
import { ProductIntentContext, ProductKey } from '~/queries/schema/schema-general'
import { AccessControlLevel, AccessControlResourceType } from '~/types'

import { isExperimentExposureFrozen, isExperimentPaused } from 'products/experiments/frontend/experimentStatus'

import {
canArchiveExperiment,
canFreezeExposure,
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/scenes/experiments/ExperimentView/Info.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@ import { LemonButton, LemonTag, Link, ProfilePicture, Tooltip } from '@posthog/l
import { CopyToClipboardInline } from 'lib/components/CopyToClipboard'
import { IconOpenInNew } from 'lib/lemon-ui/icons'
import { Label } from 'lib/ui/Label/Label'
import { getExperimentStatus, isExperimentPaused } from 'scenes/experiments/experimentStatus'
import { urls } from 'scenes/urls'

import { ExperimentStatsMethod, ExperimentStatus } from '~/types'

import { StatusTag } from 'products/experiments/frontend/components/StatusTag'
import { getExperimentStatus, isExperimentPaused } from 'products/experiments/frontend/experimentStatus'

import { CONCLUSION_DISPLAY_CONFIG } from '../constants'
import { experimentLogic } from '../experimentLogic'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,15 @@ import { LemonMenuItemLeafCallback } from 'lib/lemon-ui/LemonMenu'
import { userHasAccess } from 'lib/utils/accessControlUtils'
import { newInternalTab } from 'lib/utils/newInternalTab'
import { addProductIntentForCrossSell } from 'lib/utils/product-intents'
import { isExperimentExposureFrozen, isExperimentPaused } from 'scenes/experiments/experimentStatus'
import { organizationLogic } from 'scenes/organizationLogic'
import { projectLogic } from 'scenes/projectLogic'
import { urls } from 'scenes/urls'

import { ProductIntentContext, ProductKey } from '~/queries/schema/schema-general'
import { AccessControlLevel, AccessControlResourceType } from '~/types'

import { isExperimentExposureFrozen, isExperimentPaused } from 'products/experiments/frontend/experimentStatus'

import {
canArchiveExperiment,
canFreezeExposure,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import { LemonCollapse } from 'lib/lemon-ui/LemonCollapse'
import { LemonSkeleton } from 'lib/lemon-ui/LemonSkeleton'
import { featureFlagLogic } from 'lib/logic/featureFlagLogic'
import { humanFriendlyLargeNumber } from 'lib/utils/numbers'
import { isLaunched } from 'scenes/experiments/experimentStatus'
import { VariantTag } from 'scenes/experiments/ExperimentView/VariantTag'
import { MetricBreakdownError } from 'scenes/experiments/MetricBreakdowns/MetricBreakdownError'
import { MetricBreakdowns } from 'scenes/experiments/MetricBreakdowns/MetricBreakdowns'
Expand Down Expand Up @@ -56,6 +55,8 @@ import {
} from '~/scenes/experiments/MetricsView/shared/utils'
import { Experiment, InsightType, BreakdownAttributionType } from '~/types'

import { isLaunched } from 'products/experiments/frontend/experimentStatus'

import { ChartCell } from './ChartCell'
import {
CELL_HEIGHT,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import { SortableContext, arrayMove, sortableKeyboardCoordinates, verticalListSo
import { useActions, useValues } from 'kea'

import { verticalSortableListCollisionDetection } from 'lib/sortable'
import { isLaunched } from 'scenes/experiments/experimentStatus'
import { experimentsConfigLogic } from 'scenes/settings/environment/experimentsConfigLogic'

import {
Expand All @@ -15,6 +14,8 @@ import {
} from '~/queries/schema/schema-general'
import { ExperimentStatsMethod, InsightType } from '~/types'

import { isLaunched } from 'products/experiments/frontend/experimentStatus'

import { experimentLogic } from '../../experimentLogic'
import { experimentMetricsLogic } from '../../experimentMetricsLogic'
import { resolveSequentialEnabled } from '../../ExperimentView/sequential'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,13 @@ import { LemonBanner, LemonButton, LemonDialog, LemonDivider, LemonModal, Link,
import { dayjs } from 'lib/dayjs'
import { More } from 'lib/lemon-ui/LemonButton/More'
import { Spinner } from 'lib/lemon-ui/Spinner'
import { hasEnded, isLaunched } from 'scenes/experiments/experimentStatus'
import { urls } from 'scenes/urls'

import { ExperimentMetric, isExperimentRatioMetric } from '~/queries/schema/schema-general'
import type { Experiment } from '~/types'

import { hasEnded, isLaunched } from 'products/experiments/frontend/experimentStatus'

import { EXPERIMENT_RECALCULATION_MAX_AGE_DAYS } from '../../constants'
import { experimentTimeseriesLogic } from '../../experimentTimeseriesLogic'
import { VariantTag } from '../../ExperimentView/VariantTag'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,11 @@ import { LemonBanner, LemonButton, LemonInput, LemonModal, LemonSegmentedButton

import { LemonSlider } from 'lib/lemon-ui/LemonSlider'
import { Label } from 'lib/ui/Label/Label'
import { isLaunched } from 'scenes/experiments/experimentStatus'

import { Experiment } from '~/types'

import { isLaunched } from 'products/experiments/frontend/experimentStatus'

import { ManualCalculatorMetricType } from './calculations'
import { runningTimeLogic } from './runningTimeLogic'

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ import { FEATURE_FLAGS } from 'lib/constants'
import { lemonToast } from 'lib/lemon-ui/LemonToast/LemonToast'
import { featureFlagLogic } from 'lib/logic/featureFlagLogic'
import { objectsEqual } from 'lib/utils/objects'
import { isLaunched } from 'scenes/experiments/experimentStatus'

import { experimentsConfigLogic } from '~/scenes/settings/environment/experimentsConfigLogic'
import { ConversionRateInputType, Experiment } from '~/types'

import { isLaunched } from 'products/experiments/frontend/experimentStatus'
import { experimentsCalculateRunningTimeCreate } from 'products/experiments/frontend/generated/api'
import type {
RunningTimeCalculationInputApi,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@ import { IconSparkles } from '@posthog/icons'
import { Tooltip } from '@posthog/lemon-ui'

import { addProductIntent } from 'lib/utils/product-intents'
import { isLaunched } from 'scenes/experiments/experimentStatus'
import { useMaxTool } from 'scenes/max/useMaxTool'

import { iconForType } from '~/layout/panel-layout/ProjectTree/defaultTree'
import { ProductIntentContext, ProductKey } from '~/queries/schema/schema-general'

import { isLaunched } from 'products/experiments/frontend/experimentStatus'
import { useAttachedContext } from 'products/posthog_ai/frontend/api/logics'

import { experimentLogic } from '../experimentLogic'
Expand Down
7 changes: 4 additions & 3 deletions frontend/src/scenes/experiments/experimentActions.tsx
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
import { LemonCheckbox, LemonDialog } from '@posthog/lemon-ui'

import { deleteWithUndo } from 'lib/utils/deleteWithUndo'

import { Experiment } from '~/types'

import {
hasEnded,
isExperimentExposureFrozen,
isExperimentPaused,
isLaunched,
} from 'scenes/experiments/experimentStatus'

import { Experiment } from '~/types'
} from 'products/experiments/frontend/experimentStatus'

/** Whether an experiment is in a state where it can be archived (ignoring permissions). */
export function canArchiveExperiment(
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/scenes/experiments/experimentLogic.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ import { showApprovalRequiredToast } from 'scenes/approvals/ApprovalRequiredBann
import { dispatchChangeRequestCreated } from 'scenes/approvals/utils'
import { billingLogic } from 'scenes/billing/billingLogic'
import { runWithLimit } from 'scenes/dashboard/dashboardUtils'
import { hasEnded, isLaunched } from 'scenes/experiments/experimentStatus'
import {
hasMultipleVariantsActive,
hasZeroRollout,
Expand Down Expand Up @@ -88,6 +87,7 @@ import {
PropertyMathType,
} from '~/types'

import { hasEnded, isLaunched } from 'products/experiments/frontend/experimentStatus'
import {
legacyExpectedRunningTime,
legacyMinimumSampleSizePerVariant,
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/scenes/experiments/experimentMetricsLogic.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,14 @@ import { lemonToast } from '@posthog/lemon-ui'
import { FEATURE_FLAGS } from 'lib/constants'
import { featureFlagLogic } from 'lib/logic/featureFlagLogic'
import { eventUsageLogic } from 'lib/utils/eventUsageLogic'
import { isLaunched } from 'scenes/experiments/experimentStatus'
import { projectLogic } from 'scenes/projectLogic'

import type { FeatureFlagsSet } from '~/lib/logic/featureFlagLogic'
import type { Breakdown, CachedNewExperimentQueryResponse, ExperimentMetric } from '~/queries/schema/schema-general'
import { Experiment } from '~/types'
import type { ExperimentIdType } from '~/types'

import { isLaunched } from 'products/experiments/frontend/experimentStatus'
import {
experimentsMetricsRecalculationCreate,
experimentsMetricsRecalculationLatestRetrieve,
Expand Down
3 changes: 2 additions & 1 deletion frontend/src/scenes/experiments/experimentSceneLogic.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ import { FEATURE_FLAGS } from 'lib/constants'
import { type FeatureFlagsSet, featureFlagLogic } from 'lib/logic/featureFlagLogic'
import { trackedActionToUrl } from 'lib/logic/scenes/trackedActionToUrl'
import { eventUsageLogic } from 'lib/utils/eventUsageLogic'
import { isLaunched } from 'scenes/experiments/experimentStatus'
import { sceneConfigurations } from 'scenes/scenes'
import { Scene } from 'scenes/sceneTypes'
import { urls } from 'scenes/urls'
Expand All @@ -28,6 +27,8 @@ import { SIDE_PANEL_CONTEXT_KEY, SidePanelSceneContext } from '~/layout/navigati
import { ActivityScope, Breadcrumb, Experiment, ProjectTreeRef } from '~/types'
import type { ExperimentIdType } from '~/types'

import { isLaunched } from 'products/experiments/frontend/experimentStatus'

import { NEW_EXPERIMENT } from './constants'
import {
type ExperimentLogicProps,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ import { LemonInput, LemonTag, Tooltip } from '@posthog/lemon-ui'
import { TZLabel } from 'lib/components/TZLabel'
import { LemonTable, LemonTableColumn, LemonTableColumns } from 'lib/lemon-ui/LemonTable'
import { createdByColumn } from 'lib/lemon-ui/LemonTable/columnUtils'
import { getExperimentStatus } from 'scenes/experiments/experimentStatus'

import { Experiment } from '~/types'

import { StatusTag } from 'products/experiments/frontend/components/StatusTag'
import { getExperimentStatus } from 'products/experiments/frontend/experimentStatus'

import { addExperimentsToNotebookModalLogic } from './addExperimentsToNotebookModalLogic'

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ import { useEffect } from 'react'

import { IconFlag } from '@posthog/icons'

import { getExperimentStatus } from 'scenes/experiments/experimentStatus'

import { experimentLogic } from '~/scenes/experiments/experimentLogic'
import { NotebookExperimentComponent } from '~/scenes/experiments/notebook'
import {
Expand All @@ -16,6 +14,7 @@ import { getNotebookWidgetDefaultView } from '~/scenes/notebooks/notebookWidgetC
import { type NotebookNodeProps, NotebookNodeType } from '~/scenes/notebooks/types'
import { urls } from '~/scenes/urls'

import { getExperimentStatus } from 'products/experiments/frontend/experimentStatus'
import {
getExperimentStatusColor,
getExperimentStatusLabel,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@ import { IconOpenInNew } from 'lib/lemon-ui/icons'
import { Label } from 'lib/ui/Label/Label'
import { cn } from 'lib/utils/css-classes'
import { CONCLUSION_DISPLAY_CONFIG } from 'scenes/experiments/constants'
import { getExperimentStatus, isExperimentPaused } from 'scenes/experiments/experimentStatus'
import { urls } from 'scenes/urls'

import { SceneContent } from '~/layout/scenes/components/SceneContent'
import { ExperimentStatsMethod, ExperimentStatus } from '~/types'

import { StatusTag } from 'products/experiments/frontend/components/StatusTag'
import { getExperimentStatus, isExperimentPaused } from 'products/experiments/frontend/experimentStatus'
import { LegacyExperimentDates, legacyExperimentLogic } from 'products/experiments/frontend/legacy'
import { isSingleVariantShipped, getShippedVariantKey } from 'products/experiments/frontend/scenes/experimentsLogic'
/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,13 @@ import { createContext, useContext, useState } from 'react'
import { IconGraph } from '@posthog/icons'
import { LemonButton } from '@posthog/lemon-ui'

import { isLaunched } from 'scenes/experiments/experimentStatus'

import {
EXPERIMENT_MIN_EXPOSURES_FOR_RESULTS,
EXPERIMENT_MIN_METRIC_VALUE_FOR_RESULTS,
} from '~/scenes/experiments/constants'
import { Experiment, FunnelExperimentVariant, InsightType, TrendExperimentVariant } from '~/types'

import { isLaunched } from 'products/experiments/frontend/experimentStatus'
import {
legacyCalculateDelta,
legacyConversionRateForVariant,
Expand Down
2 changes: 1 addition & 1 deletion products/experiments/frontend/scenes/ExperimentsScene.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ import {
confirmArchiveExperiment,
confirmDeleteExperiment,
} from 'scenes/experiments/experimentActions'
import { getExperimentStatus } from 'scenes/experiments/experimentStatus'
import MaxTool from 'scenes/max/MaxTool'
import { useMaxTool } from 'scenes/max/useMaxTool'
import { organizationLogic } from 'scenes/organizationLogic'
Expand All @@ -59,6 +58,7 @@ import { DuplicateExperimentModal } from 'products/experiments/frontend/componen
import { ExperimentVelocityStats } from 'products/experiments/frontend/components/ExperimentVelocityStats'
import { StatusTag } from 'products/experiments/frontend/components/StatusTag'
import { experimentsEmptyState } from 'products/experiments/frontend/emptyState/experimentsEmptyState'
import { getExperimentStatus } from 'products/experiments/frontend/experimentStatus'
/**
* these scenes are handled as child components. This works fine, but breaks the expectation of scenes
* having their own routes.
Expand Down
12 changes: 6 additions & 6 deletions products/experiments/frontend/scenes/experimentsLogic.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,19 +4,19 @@ import { router } from 'kea-router'
import { expectLogic } from 'kea-test-utils'

import { lemonToast } from 'lib/lemon-ui/LemonToast/LemonToast'
import {
getExperimentStatus,
hasEnded,
isExperimentExposureFrozen,
isExperimentPaused,
} from 'scenes/experiments/experimentStatus'
import { NEW_FLAG } from 'scenes/feature-flags/featureFlagLogic'
import { urls } from 'scenes/urls'

import { resumeKeaLoadersErrors, silenceKeaLoadersErrors } from '~/initKea'
import { initKeaTests } from '~/test/init'
import { Experiment, ExperimentStatus, ExperimentsTabs, FeatureFlagType } from '~/types'

import {
getExperimentStatus,
hasEnded,
isExperimentExposureFrozen,
isExperimentPaused,
} from 'products/experiments/frontend/experimentStatus'
import {
experimentsLogic,
getExperimentStatusColor,
Expand Down
Loading