Skip to content

feat(error-tracking): remove severity feature flag gates - #89886

Merged
trunk-io[bot] merged 3 commits into
masterfrom
posthog/remove-error-tracking-severity-gates
Aug 27, 2026
Merged

trunk-io[bot] merged 3 commits into
masterfrom
posthog/remove-error-tracking-severity-gates

Conversation

@hpouillot

Copy link
Copy Markdown
Contributor

Summary

  • show severity controls and filters without a feature flag
  • expose severity rule settings to all projects
  • remove the retired feature flag constant and story configuration

Stack

Tests

  • pnpm exec oxfmt --check <changed files>
  • pnpm exec oxlint --quiet <changed files>
  • pnpm --filter @posthog/frontend jest --runInBand products/error_tracking/frontend/components/ErrorTrackingIssueList/ErrorTrackingIssueList.test.tsx

@github-actions

Copy link
Copy Markdown
Contributor

Hey @hpouillot! 👋

It looks like your git author email on this PR isn't your @posthog.com address (hpouillot@gmail.com). Since you're on the PostHog team, it's worth pointing your local git author email at your @posthog.com address. Why it matters:

  • Consistent work identity in git history — internal tooling that attributes commits to team members keys off your @posthog.com address.
  • Keeps team contributions easy to tell apart from external community ones when scanning history.

You can fix it for this repo with:

git config user.email "you@posthog.com"

Or set it globally with git config --global user.email "you@posthog.com". No need to redo this PR — just a nudge for next time. 🙂

@github-actions

github-actions Bot commented Aug 27, 2026 •

Copy link
Copy Markdown
Contributor

🤖 CI report

✅ Trunk lane — non-backend lane

This PR is assigned to the non-backend lane. It does not run backend Python tests and may merge in parallel with PRs in other lanes.

✅ Bundle size — 🟢 -258 B (-0.0%)

Uncompressed size of every built .js bundle, compared against the base branch.

Total: 68.02 MiB · 🟢 -258 B (-0.0%)

No file changed by more than 1000 B.

Posted automatically by build-bundle-size-report · uncompressed bytes from dist-report

✅ Eager graph — within budget

How much code each root ships on the eager path — downloaded and parsed before the surface is interactive. Measured from the esbuild output chunks (post-tree-shake, static imports only); lazy import() / React.lazy chunks are not counted.

Root Eager (shipped) Δ vs base Budget
entry (logged-out pages, app bootstrap)
src/index.tsx
1.37 MiB · 22 files no change ███░░░░░░░ 30.3% of 4.51 MiB
authenticated shell (every logged-in page)
src/scenes/AuthenticatedShell.tsx
8.80 MiB · 3,243 files 🟢 -220 B (-0.0%) █████████░ 90.6% of 9.71 MiB

🟢 node_modules/monaco-editor/ stays out of src/index.tsx
🟢 src/lib/components/ActivityLog/describers stays out of src/index.tsx
🟢 [object Object] stays out of src/index.tsx
🟢 [object Object] stays out of src/index.tsx
🟢 node_modules/monaco-editor/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/lib/components/ActivityLog/describers stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx

Largest files eagerly shipped from src/index.tsx
Size File
126.8 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
24.6 KiB ../node_modules/.pnpm/buffer@6.0.3/node_modules/buffer/index.js
6.3 KiB ../node_modules/.pnpm/react@18.3.1/node_modules/react/cjs/react.production.min.js
4.5 KiB ../node_modules/.pnpm/@jspm+core@2.1.0/node_modules/@jspm/core/nodelibs/browser/process.js
3.9 KiB ../node_modules/.pnpm/scheduler@0.23.2/node_modules/scheduler/cjs/scheduler.production.min.js
1.4 KiB ../node_modules/.pnpm/base64-js@1.5.1/node_modules/base64-js/index.js
1.3 KiB src/RootErrorBoundary.tsx
912 B ../node_modules/.pnpm/ieee754@1.2.1/node_modules/ieee754/index.js
789 B src/scenes/ChunkLoadErrorBoundary.tsx
762 B src/index.tsx
Largest files eagerly shipped from src/scenes/AuthenticatedShell.tsx
Size File
306.9 KiB ../node_modules/.pnpm/posthog-js@1.420.0_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/rrweb.js
267.7 KiB ../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js
260.9 KiB ../node_modules/.pnpm/posthog-js@1.420.0_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.js
250.4 KiB src/taxonomy/core-filter-definitions-by-group.json
154.2 KiB ../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js
126.8 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
104.7 KiB src/lib/api.ts
95.2 KiB ../packages/quill/packages/quill/dist/index.js
93.3 KiB ../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js
90.6 KiB ../node_modules/.pnpm/@tiptap+core@3.20.6_@tiptap+pm@3.20.6/node_modules/@tiptap/core/dist/index.js

Posted automatically by check-eager-graph · sizes are eager output bytes (shipped, post-tree-shake) from the esbuild metafile · part of #32479

✅ Toolbar bundle — eager 2.25 MiB within budget

What the toolbar ships to customer pages, measured from the esbuild output (minified, post-tree-shake). The eager set is the entry plus everything statically imported from it — fetched before any feature runs; deferred chunks load lazily. The eager guardrail is 5.72 MiB. Each output file must also stay below 10 MB, where CloudFront stops compressing it. The module boundary is enforced separately by check-toolbar-graph.

Metric Size Δ vs base Budget
Eager (shipped)
entry + static imports
2.25 MiB · 18 files 🟢 -62 B (-0.0%) ████░░░░░░ 39.4% of 5.72 MiB
Deferred (lazy) 2.11 MiB · 45 files no change n/a — loads on demand
Loader dist/toolbar.js 1.1 KiB no change █░░░░░░░░░ 5.8% of 19.5 KiB
Largest eagerly-shipped chunks
Size File
748.8 KiB dist/toolbar/toolbar-app-XYGAYFW6.css
585.3 KiB dist/toolbar/chunk-chunk-2U5H2OGY.js
484.7 KiB dist/toolbar/chunk-chunk-YWUNJNKA.js
133.8 KiB dist/toolbar/chunk-chunk-PZ5U4WN6.js
131.8 KiB dist/toolbar/chunk-chunk-FDH2IBXT.js
71.3 KiB dist/toolbar/toolbar-app-MQABX4XP.js
69.0 KiB dist/toolbar/chunk-chunk-TSAL54PB.js
35.6 KiB dist/toolbar/chunk-chunk-656PM2R7.js
20.9 KiB dist/toolbar/chunk-chunk-O5DZXSDZ.js
6.8 KiB dist/toolbar/chunk-chunk-DV7IWQNF.js

Posted automatically by check-toolbar-size · sizes are toolbar output bytes (shipped, post-tree-shake) from the esbuild metafile

✅ Dist folder size — 🟢 -5.0 KiB (-0.0%)

Total size of the built frontend/dist folder (all assets), compared against the base branch.

Total: 1449.36 MiB · 🟢 -5.0 KiB (-0.0%)

✅ Playwright — all passed

All tests passed.

View test results →

@github-actions

github-actions Bot commented Aug 27, 2026 •

Copy link
Copy Markdown
Contributor

🦔 Hogbox preview · ✅ ready

▶ Open the preview

🔑 Login test@posthog.com / 12345678 (demo data)
🧩 Running this PR's backend and frontend, on the PostHog :master base
🔗 Link stable across rebuilds — a re-push swaps the box underneath, the URL stays
🔒 Access tailnet only (PostHog VPN)
🛠️ Admin inspect & debug state in hogland
💤 Idle sleeps after ~30 min idle (snapshot to S3, zero node cost) and wakes on your next visit in ~30s, behind a brief "waking up" screen

commit e0a0757 · box box-4a8f4d3c61ae · ready in 678s (push → usable) · build log · rebuilds on every push, torn down on close

@greptile-apps

greptile-apps Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "feat(error-tracking): remove severity fe..." | Re-trigger Greptile

@posthog

posthog Bot commented Aug 27, 2026 •

Copy link
Copy Markdown
Contributor

✅ Visual changes approved by @hpouillot — baseline updated in 9b4eacd.

View this run in PostHog

4 changed.

@trunk-io

trunk-io Bot commented Aug 27, 2026 •

Copy link
Copy Markdown

Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

@hpouillot
hpouillot force-pushed the hp/error-tracking-issue-list-filters branch from 65d441e to ce3ae59 Compare August 27, 2026 10:25
@hpouillot
hpouillot force-pushed the posthog/remove-error-tracking-severity-gates branch from 379290d to 1caac81 Compare August 27, 2026 10:26
Base automatically changed from hp/error-tracking-issue-list-filters to master August 27, 2026 11:27
@trunk-io

trunk-io Bot commented Aug 27, 2026 •

Copy link
Copy Markdown

😎 Merged successfully - details.

hpouillot and others added 3 commits August 27, 2026 13:31
Make severity controls, filters, and settings available without the rollout flag. Remove the retired flag constant and update affected tests and stories.

Generated-By: PostHog Desktop
Task-Id: e5e0d821-a9c7-4b96-9ade-55c378a59fbc
8 updated
Run: be75d635-fd5e-43e9-9022-76cd056ea9f0

Co-authored-by: hpouillot <3455883+hpouillot@users.noreply.github.com>
4 updated
Run: 40e5c001-3352-49ba-9030-f30f9f5ebde8

Co-authored-by: hpouillot <3455883+hpouillot@users.noreply.github.com>
@hpouillot
hpouillot force-pushed the posthog/remove-error-tracking-severity-gates branch from 9b4eacd to e0a0757 Compare August 27, 2026 11:31
@trunk-io
trunk-io Bot merged commit 3f52a6f into master Aug 27, 2026
216 checks passed
@trunk-io
trunk-io Bot deleted the posthog/remove-error-tracking-severity-gates branch August 27, 2026 12:35
@deployment-status-posthog

deployment-status-posthog Bot commented Aug 27, 2026 •

Copy link
Copy Markdown

Deploy status

Environment Status Deployed At Workflow
dev ✅ Deployed 2026-08-27 14:12 UTC Run
prod-us ✅ Deployed 2026-08-27 14:31 UTC Run
prod-eu ✅ Deployed 2026-08-28 07:22 UTC Run

This branch was successfully deployed

1 active deployment
preview-pr-89886 — e0a07573 Deployed Aug 27, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants