Repository navigation
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R8Uyj628NgticUdB6DJJ7x
Contributor
🤖 CI report
|
aspicer
merged commit Aug 25, 2026
ac5568d
into
aspicer/hogql-shared-database-trends
190 checks passed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#88183 shares one HogQL database across an insight run's query threads. If the sharing misbehaves in production, the only rollback is a revert and a redeploy.
Changes
HOGQL_SHARED_INSIGHT_DATABASE_ENABLED, default on, editable via the instance settings API. Workers pick up a change within 60 seconds.shared_databasereturns a fresh database per access, so query threads never share schema state. Every wired runner falls back to per-call builds, the pre-perf(insights): build the hogql database once per insight run #88183 threading profile.HogQLTimingsis not thread-safe.How did you test this code?
test_shared_database_kill_switch_disables_sharing: with the setting off, two property accesses return different instances; back on, the same instance. Catches a refactor that silently drops the switch and with it the emergency lever.Automatic notifications
Docs update
None. Staff-only instance setting.
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Built with Claude Code as a decision aid layered on #88183: the assignee will judge whether the runtime switch earns its complexity, then fold this into the base PR or close it. Skills invoked: /writing-tests, /writing-code-comments, /writing-pr-descriptions.