Repository navigation
#59 Fix funnels not always saving and allow updating of name - #66
Merged
Merged
Conversation
yakkomajuri
pushed a commit
that referenced
this pull request
Oct 1, 2021
neilkakkar
pushed a commit
that referenced
this pull request
Jun 10, 2024
neilkakkar
pushed a commit
that referenced
this pull request
Jun 10, 2024
orian
added a commit
that referenced
this pull request
Jun 26, 2026
…x parsers Replace the three text parsers (engine_map's `hclexp load` STDERR scrape, parse_diff's statement/UNSAFE splitting, classify's op/table regex) and the separate `hclexp load` call with a single `hclexp diff -format json` per node (chschema #66). Each structured operation carries kind/object/sql/engine/ replicated/order/unsafe, so node_roles, sharded, is_alter_on_replicated_table, and the CLOUD_DEPLOYMENT env-gating notes are derived from fields instead of parsed from DDL text. Statements keep hclexp's per-node dependency order (first-seen across the manifest) instead of an alphabetical sort. 226 -> 174 LOC.
2 tasks
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.