Skip to content

feat(oauth): add authenticator to existing api key endpoints - #40246

Merged
joshsny merged 18 commits into
masterfrom
oauth/add-authenticators-to-endpoints
Oct 24, 2025
Merged

joshsny merged 18 commits into
masterfrom
oauth/add-authenticators-to-endpoints

Conversation

@joshsny

@joshsny joshsny commented Oct 23, 2025

Copy link
Copy Markdown
Contributor

This adds OAuth to existing endpoints that explicitly specify authenticators.

It also fixes an issue where access tokens are treated as personal api keys if a personal api key authenticator comes first

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

13 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

Comment thread posthog/auth.py Resolved
Comment thread posthog/auth.py Resolved
@joshsny
joshsny requested review from a team and Piccirello October 23, 2025 17:09
Comment thread posthog/auth.py Resolved
Comment thread posthog/auth.py Resolved
Comment thread posthog/auth.py Resolved
Comment thread posthog/auth.py Resolved
Comment thread posthog/auth.py Resolved
@joshsny
joshsny enabled auto-merge (squash) October 23, 2025 20:32
@github-actions

Copy link
Copy Markdown
Contributor

Size Change: 0 B

Total Size: 3.31 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 3.31 MB

compressed-size-action

@joshsny
joshsny disabled auto-merge October 23, 2025 21:09
@joshsny
joshsny enabled auto-merge (squash) October 24, 2025 15:14
@joshsny
joshsny merged commit 561dc01 into master Oct 24, 2025
@joshsny
joshsny deleted the oauth/add-authenticators-to-endpoints branch October 24, 2025 15:32
joshsny added a commit that referenced this pull request Oct 24, 2025
MarconLP added a commit that referenced this pull request Apr 29, 2026
PR #38921 narrowed the integrations endpoint to only return GitHub
integrations when authenticated via personal API key (and #40246
extended the same restriction to OAuth access tokens). The intent was
to scope the surface to GitHub for the Tasks product, but the side
effect was that any other tool authenticating via API key — MCP,
future products, custom scripts — could no longer read Slack, Stripe,
Hubspot, or any other integration kind despite holding the
`integration:read` scope.

Drop the kind filter so the endpoint returns whatever the scope
permission grants. The serializer already excludes `sensitive_config`,
so this change exposes the same metadata-only view (id, kind, config,
created_at, errors, display_name) for all kinds rather than just
github.

Per #38921 (comment).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants