Repository navigation
fix(ci): temporarily disable taxonomy check - #31950
Merged
Merged
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
Temporarily disables the taxonomy file validation check in the Python code quality GitHub Action while maintaining all other code quality checks.
- Commented out the
Check if "taxonomy.json/taxonomy.tsx" is up to datestep in/.github/actions/python-code-quality/action.yml - This change should be treated as temporary to avoid potential inconsistencies between source and generated taxonomy files
- Consider adding a tracking issue or timeline for re-enabling this check to maintain code quality standards
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+67
to
+70
| # - name: Check if "taxonomy.json/taxonomy.tsx" is up to date | ||
| # shell: bash | ||
| # run: | | ||
| # npm run taxonomy:build:json && git diff --exit-code |
Contributor
There was a problem hiding this comment.
style: Disabling CI checks should include a TODO comment with a timeline or ticket reference for re-enabling
timgl
approved these changes
May 6, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
https://posthog.slack.com/archives/C0113360FFV/p1746531608269629?thread_ts=1744218127.802669&cid=C0113360FFV
Changes
Temporarily disables the CI check.
How did you test this code?
CI run