Skip to content

chore: Reinstate changed-files steps - #30000

Merged
rafaeelaudibert merged 1 commit into
masterfrom
replace-changed-files-github-action
Mar 17, 2025
Merged

rafaeelaudibert merged 1 commit into
masterfrom
replace-changed-files-github-action

Conversation

@rafaeelaudibert

@rafaeelaudibert rafaeelaudibert commented Mar 16, 2025 •

Copy link
Copy Markdown
Member

Step Security released a new version of the action that's not compromised. It'll act as a substitute for now, allowing us to go back to using our CI

https://github.com/step-security/changed-files

Follow-up steps: pin all of our Actions following https://michaelheap.com/pin-your-github-actions/

Step Security released a new version of the lib that's not compromised. It'll act as a substitute for now, allowing us to go back to using our CI

Follow-up steps: pin all of our Actions following https://michaelheap.com/pin-your-github-actions/
@rafaeelaudibert
rafaeelaudibert requested a review from frankh March 16, 2025 17:14

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR replaces the compromised tj-actions/changed-files GitHub Action with the secure step-security/changed-files@v45 alternative in two CI workflows.

  • Updated .github/workflows/build-hogql-parser.yml to use step-security/changed-files@v45 for detecting hogql_parser directory changes
  • Updated .github/workflows/container-images-ci.yml to use step-security/changed-files@v45 for checking modified Dockerfiles
  • PR notes that follow-up work is needed to pin all GitHub Actions to specific commit hashes for improved security

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@rafaeelaudibert
rafaeelaudibert merged commit 7b13007 into master Mar 17, 2025
@rafaeelaudibert
rafaeelaudibert deleted the replace-changed-files-github-action branch March 17, 2025 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants