Repository navigation
feat: new scene for new pipeline configuration creation - #21306
Merged
Merged
Conversation
Contributor
|
Size Change: +59 B (0%) Total Size: 1.04 MB ℹ️ View Unchanged
|
tiina303
marked this pull request as ready for review
April 8, 2024 21:54
tiina303
force-pushed
the
pipeline-new-separate
branch
2 times, most recently
from
April 8, 2024 22:34
3287ca2 to
2ab46ef
Compare
tiina303
force-pushed
the
pipeline-new-separate
branch
from
April 18, 2024 19:11
19dcf96 to
bde84a4
Compare
Twixes
approved these changes
Apr 24, 2024
Twixes
left a comment
Twixes
left a comment
Contributor
There was a problem hiding this comment.
The shape of this solution makes sense. Would love to do add some UI polish, but this doesn't need to block for now, as I don't think we have anyone frontendy with capacity right now (busy with HogQL rollout in product analytics)
tiina303
force-pushed
the
pipeline-new-separate
branch
from
April 24, 2024 13:30
bde84a4 to
d888b4c
Compare
tiina303
force-pushed
the
pipeline-new-separate
branch
from
April 25, 2024 13:18
7fe36b5 to
fef17c0
Compare
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Having the node non existent in pipelineNode started to get really confusing, so this is the starting point for having new node initial creation as a separate scene.
The idea is to have links like
pipeline/new/destinationandpipeline/new/transformationshow options to pick what new node the user wants to create.Follow-up PR will make links like
pipeline/new/destination/S3and for nowpipeline/new/destination/4for plugins, but longer term it would be the repo URL path suffix there.Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?