Repository navigation
Conversation
…ript tests The four "replays a moved run past 24 hours" cases drive replayUntilDayAfter through MARK_QUEUED_SCRIPT branches that dedicated tests already cover: the longer window kept on a second write, the absent key written, and the end-to-end replay of a moved send in the CDP API suite. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
🤖 CI report✅ Trunk lane — non-backend laneThis PR is assigned to the non-backend lane. It does not run backend Python tests and may merge in parallel with PRs in other lanes. ✅ Duplication (Python) — cleanNew Python code duplication introduced by this branch. Fails at 70+ tokens in app code, or 150+ tokens when both copies live in test files. Advisory while the gate proves itself: extract a shared helper instead of copying. ✅ Duplication (TypeScript) — cleanNew TypeScript code duplication introduced by this branch. Fails at 70+ tokens in app code, or 150+ tokens when both copies live in test files. Advisory while the gate proves itself: extract a shared helper instead of copying. |
![posthog[bot]](https://avatars.githubusercontent.com/in/1203049?s=60&v=4){kind=small}
|
Risk: No findings This PR deletes four redundant "replays a moved run past 24 hours" test cases from the HogFlows idempotency-key test file; it is a test-only change with no production, config, or routing edits. The production duplicate-send guard from #134438 is untouched, so there is no security-relevant surface change to review. Sentinel reviewed |
PR overviewNo security issues were found in this pull request. Reviews
|
![stamphog[bot]](https://avatars.githubusercontent.com/in/3000332?s=60&v=4){kind=small}
There was a problem hiding this comment.
Approved.
The diff only removes tests and leaves production behavior unchanged; related replay-window and delayed-write coverage remains. No unresolved review concerns or other refusal grounds are present.
- PostHog Review (Standard) reviewed the current head: no findings.
- posthog[bot] reviewed the current head.
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 0L, 0F substantive, 77L/1F incl. docs/generated/snapshots — within ceiling |
| tier | ✓ | T0 auto-approve: T0-deterministic (77L, 1F, single-area, chore) |
| stamphog 2.8.0 | .stamphog/policy.yml @ 7dc24a0 · reviewed head 7dc24a0 |
Problem
Changes
Note
🔵 Merge risk: low · two-way door
nodejs/src/cdp/services/hogflows/)How did you test this code?
Test rationale: no new test; the remaining cases in
idempotency-keys.test.tspass.7dc24a07dc24a0Not checked: the CDP API serial suite, which the deletion does not touch
Full receipt (PostHog team): https://artifacts.posthog.com/a/rAGePyfSklAEzFDHWftsZ1
Release status
Docs update
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Agent: Claude Code, Claude Opus 5.5
Skills:
/full-stop,/impact,/writing-pr-descriptions,/pr-description,/merge-risk,/qa-swarmSecurity review: not needed
More context for AI agents
nodejs/src/cdp/services/hogflows/idempotency-keys.test.tsNo load-bearing decisions.
🤖 Generated with Claude Code