feat(logs): offer group by on a team's first logs alert by jzhu13 · Pull Request #127858 · PostHog/posthog

jzhu13 · 2026-11-02T22:32:05Z

Problem

A team creating its first logs alert can't pick Group by, although the API accepts grouping for that alert.
Since feat(logs): start a team's first logs alert on the alerts platform #127773, the backend puts a new alert on the alerts platform when the team has no other alerts. The form only checked for an existing platform-owned alert.

Changes

With the logs-alerts-grouping flag on (feat(logs): gate logs alert grouping behind a feature flag #127708), the new alert form now offers Group by when the team has no logs alerts.
A team whose alerts all stay on logs, such as one that was rolled back, still can't group.
The form keeps Group by off until the alert list loads, because an empty list during that load says nothing.
A created-by filter on the alert list hides some alerts, so an empty filtered list no longer counts as "no alerts". A platform-owned alert in the filtered list still turns grouping on.
Background polls keep the loaded state, so a save during a poll keeps the grouping.

Not rendered in the app: the change only enables an existing control.

How did you test this code?

Ran logsAlertFormLogic.test.ts and the other logs alerting and alert scene Jest suites locally.
Ran the frontend typecheck. No errors in the changed files.
CI report complexity warning: submit and buildFormDefaults predate this PR, which does not change either function.

Test rationale: One new row in the existing canGroup table, "new alert in a team that has no alerts". It fails if the form stops offering grouping on a team's first alert. The load guard and the created-by filter case have no test.

Release status

No feature flag controls this change

Docs update

None.

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

Agent: Claude Code, Claude Opus 5.5 (claude-opus-5-5)

Skills: /writing-tests, /writing-pr-descriptions

No duplicate: the open PR search found only feat(logs): gate logs alert grouping behind a feature flag #127708, which added the grouping flag to the same function and has since merged.

More context for AI agents

Decisions: the created-by filter handling goes past the original ask; it stops a filtered empty list from offering grouping the API would reject.
Decisions: an alertsLoaded reducer in logsAlertingLogic replaces alertsLoading, which flips on every 30 s poll.
Decisions: master merged in after feat(logs): gate logs alert grouping behind a feature flag #127708; the flag check runs before the new-alert rule, so the flag still gates grouping.
Read closely: canGroupAlert in logsAlertGrouping.ts and the alertsLoaded reducer.

🤖 Generated with Claude Code

The backend puts a new logs alert on the alerts platform when the team has no other alerts, so the form now offers Group by there too. A team whose alerts all stay on logs keeps it off. Until the alert list loads for the current filter, the form keeps Group by off, and a created-by filter means an empty list no longer says the team has no alerts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

trunk-io · 2026-11-02T22:32:10Z

😎 Merged successfully - details.

github-actions · 2026-11-02T22:33:22Z

🤖 CI report

✅ Trunk lane — non-backend lane (fe:product:logs)

This PR is assigned to the non-backend lane (fe:product:logs). It does not run backend Python tests and may merge in parallel with PRs in other lanes.

⚠️

Complexity (TypeScript) — 2 functions above the limit (max 16)

Cyclomatic complexity above the limit in changed typescript files (10 for production files, 15 for test files). Warn only: worth simplifying when you next touch these functions.

Function	Location	Complexity	Limit
`submit`	`products/logs/frontend/components/LogsAlerting/logsAlertFormLogic.ts:458`	16	10
`buildFormDefaults`	`products/logs/frontend/components/LogsAlerting/logsAlertFormLogic.ts:97`	15	10

✅ Duplication (Python) — clean

New Python code duplication introduced by this branch. Fails at 70+ tokens in app code, or 150+ tokens when both copies live in test files. Advisory while the gate proves itself: extract a shared helper instead of copying.

✅ Duplication (TypeScript) — clean

New TypeScript code duplication introduced by this branch. Fails at 70+ tokens in app code, or 150+ tokens when both copies live in test files. Advisory while the gate proves itself: extract a shared helper instead of copying.

🚨 Comment density — 14% of added code lines are comments (7 of 50)

This section warns when comments are more than 3% of the code lines a PR adds, and alerts above 6%. Before agent-assisted PRs, the typical share was about 2%. Only full-line comments count. Docstrings, generated files, snapshots, migrations, and workflow files are left out.

Comments that restate the code, record how the change came about, or narrate the next line add noise for the next reader. Keep the comments that explain a reason the code cannot show, and remove the rest. See .agents/skills/writing-code-comments/SKILL.md for the house rules.

Files with the most added comment lines:

File	Comment lines	Added lines
`products/logs/frontend/components/LogsAlerting/logsAlertGrouping.ts`	6	21
`products/logs/frontend/components/LogsAlerting/logsAlertingLogic.ts`	1	9

This check does not block merging. It updates on every push and clears when the share drops.

✅ Bundle size — no change

Uncompressed size of every built .js bundle, compared against the base branch.

Total: 76.50 MiB · no change

No file changed by more than 1000 B.

_{Posted automatically by build-bundle-size-report · uncompressed bytes from dist-report}

✅ Eager graph — within budget

How much code each root ships on the eager path — downloaded and parsed before the surface is interactive. Measured from the esbuild output chunks (post-tree-shake, static imports only); lazy import() / React.lazy chunks are not counted.

Root	Eager (shipped)	Δ vs base	Budget
entry (logged-out pages, app bootstrap) `src/index.tsx`	1.01 MiB · 25 files	no change	`█████████░` 88.3% of 1.14 MiB
logged-out boot: index + App + bootApp (preloaded by every page, including /login) `src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts`	2.96 MiB · 622 files	no change	`██████████` 97.5% of 3.03 MiB
authenticated shell (every logged-in page) `src/scenes/AuthenticatedShell.tsx`	3.83 MiB · 1,238 files	no change	`██████████` 95.6% of 4.01 MiB
dashboard scene `src/scenes/dashboard/Dashboard.tsx`	8.26 MiB · 3,060 files	no change	`████████░░` 83.9% of 9.84 MiB
today home path `src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx`	4.66 MiB · 1,757 files	no change	`█████████░` 94.5% of 4.93 MiB
AI-first home path `src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/ai-first/AiFirstHomepage.tsx`	5.90 MiB · 2,253 files	no change	`█████████░` 94.1% of 6.27 MiB
events scene `src/scenes/activity/explore/EventsScene.tsx`	7.31 MiB · 2,623 files	no change	`████████░░` 77.7% of 9.41 MiB
web analytics scene `src/scenes/web-analytics/WebAnalyticsScene.tsx`	8.19 MiB · 2,948 files	no change	`████████░░` 78.1% of 10.49 MiB
replay detail scene `src/scenes/session-recordings/detail/SessionRecordingDetail.tsx`	7.36 MiB · 2,652 files	no change	`█████████░` 90.6% of 8.13 MiB

🟢 node_modules/monaco-editor/ stays out of src/index.tsx
🟢 products/product_analytics/frontend/insights/activityDescriptions stays out of src/index.tsx
🟢 node_modules/@posthog/brand/dist/generated/hoggies/svg/ stays out of src/index.tsx
🟢 node_modules/@posthog/brand/dist/generated/hoggies/components/ stays out of src/index.tsx
🟢 node_modules/monaco-editor/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/layout/navigation-3000/navigationLogic.tsx stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/scenes/dashboard/dashboardLogic.tsx stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/lemon-ui/LemonMarkdown/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/components/RichContentEditor/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/components/CodeSnippet/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/taxonomy/core-filter-definitions-by-group.json stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 node_modules/zod/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/logic/billing/billingLogic.tsx stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/components/ProductEmptyState/productSetupPreloadLogic.ts stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 node_modules/kea-test-utils/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 node_modules/monaco-editor/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 products/product_analytics/frontend/insights/activityDescriptions stays out of src/scenes/AuthenticatedShell.tsx
🟢 node_modules/kea-test-utils/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 products/dashboards/frontend/widgets/previews/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/scenes/session-recordings/player/sessionRecordingPlayerLogic.ts stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/layout/panel-layout/ProjectTree/menus/SessionReplayMenuItems.tsx stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/taxonomy/core-filter-definitions-by-group.json stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/layout/navigation/projectNoticeLogic.tsx stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/layout/navigation/ImpersonationNotice/ImpersonationNotice.tsx stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/scenes/cohorts/cohortSavedToast.ts stays out of src/scenes/AuthenticatedShell.tsx
🟢 products/wizard/frontend/runs/WizardRunDetailsDrawer.tsx stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/layout/today/TodayShell.tsx stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/layout/today/TodayContextPanelFloating.tsx stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/layout/today/TodaySidePanel.tsx stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/layout/today/TodayTopBar.tsx stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/layout/today/todayRailItems.tsx stays out of src/scenes/AuthenticatedShell.tsx
🟢 products/subscriptions/frontend/components/Subscriptions/exportNudge/exportNudgeLogic.ts stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/scenes/billing/paymentEntryLogic.ts stays out of src/scenes/AuthenticatedShell.tsx
🟢 products/conversations/frontend/components/SidePanel/sidepanelTicketsLogic.ts stays out of src/scenes/AuthenticatedShell.tsx
🟢 node_modules/zod/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/scenes/authentication/auth/loginLogic.ts stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/scenes/authentication/shared/passkeyLogic.ts stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/scenes/surveys/constants.tsx stays out of src/scenes/AuthenticatedShell.tsx
🟢 node_modules/@tiptap/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 node_modules/prosemirror- stays out of src/scenes/AuthenticatedShell.tsx
🟢 node_modules/re2js/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 node_modules/react-markdown/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/lib/components/Command/Command.tsx stays out of src/scenes/AuthenticatedShell.tsx
🟢 packages/quill/packages/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 zod/v4/locales/de.js stays out of src/scenes/AuthenticatedShell.tsx
🟢 node_modules/@posthog/brand/dist/generated/hoggies/svg/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 node_modules/@posthog/brand/dist/generated/hoggies/components/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 packages/quill/packages/quill/dist/ stays out of src/scenes/dashboard/Dashboard.tsx
🟢 src/scenes/session-recordings/playlist/SessionRecordingsPlaylist.tsx stays out of src/scenes/dashboard/Dashboard.tsx
🟢 src/scenes/web-analytics/tiles/WebAnalyticsTile.tsx stays out of src/scenes/dashboard/Dashboard.tsx
🟢 src/queries/validators.js stays out of src/scenes/dashboard/Dashboard.tsx
🟢 src/queries/web-analytics-validators.js stays out of src/scenes/dashboard/Dashboard.tsx
🟢 node_modules/re2js/ stays out of src/scenes/dashboard/Dashboard.tsx
🟢 node_modules/kea-test-utils/ stays out of src/scenes/dashboard/Dashboard.tsx
🟢 src/scenes/debug/HogDebug.tsx stays out of src/scenes/dashboard/Dashboard.tsx
🟢 src/queries/QueryEditor/QueryEditor.tsx stays out of src/scenes/dashboard/Dashboard.tsx
🟢 packages/quill/packages/quill/dist/ stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx
🟢 src/scenes/project-homepage/ai-first/AiFirstHomepage.tsx stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx
🟢 src/scenes/project-homepage/today/TodayReportPage.tsx stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx
🟢 src/queries/Query/Query.tsx stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx
🟢 packages/quill/packages/charts/ stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx
🟢 packages/quill/packages/quill/dist/ stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/ai-first/AiFirstHomepage.tsx
🟢 products/posthog_ai/frontend/components/tool/widgets/VisualizationWidget.tsx stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/ai-first/AiFirstHomepage.tsx
🟢 products/posthog_ai/frontend/components/tool/widgets/RecordingsWidget.tsx stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/ai-first/AiFirstHomepage.tsx
🟢 src/queries/Query/Query.tsx stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/ai-first/AiFirstHomepage.tsx
🟢 products/posthog_ai/frontend/api/primitives.ts stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/ai-first/AiFirstHomepage.tsx
🟢 src/scenes/notebooks/Notebook/notebookLogic.ts stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/ai-first/AiFirstHomepage.tsx
🟢 packages/quill/packages/quill/dist/ stays out of src/scenes/activity/explore/EventsScene.tsx
🟢 src/scenes/session-recordings/playlist/SessionRecordingsPlaylist.tsx stays out of src/scenes/activity/explore/EventsScene.tsx
🟢 src/scenes/web-analytics/tiles/WebAnalyticsTile.tsx stays out of src/scenes/activity/explore/EventsScene.tsx
🟢 src/queries/validators.js stays out of src/scenes/activity/explore/EventsScene.tsx
🟢 src/queries/web-analytics-validators.js stays out of src/scenes/activity/explore/EventsScene.tsx
🟢 node_modules/re2js/ stays out of src/scenes/activity/explore/EventsScene.tsx
🟢 node_modules/kea-test-utils/ stays out of src/scenes/activity/explore/EventsScene.tsx
🟢 src/queries/nodes/InsightViz/InsightViz.tsx stays out of src/scenes/activity/explore/EventsScene.tsx
🟢 src/queries/nodes/DataVisualization/DataVisualization.tsx stays out of src/scenes/activity/explore/EventsScene.tsx
🟢 src/queries/nodes/WebOverview/WebOverview.tsx stays out of src/scenes/activity/explore/EventsScene.tsx
🟢 src/scenes/debug/HogDebug.tsx stays out of src/scenes/activity/explore/EventsScene.tsx
🟢 src/queries/QueryEditor/QueryEditor.tsx stays out of src/scenes/activity/explore/EventsScene.tsx
🟢 packages/quill/packages/quill/dist/ stays out of src/scenes/web-analytics/WebAnalyticsScene.tsx
🟢 src/scenes/web-analytics/LiveMetricsDashboard/LiveWebAnalyticsMetrics.tsx stays out of src/scenes/web-analytics/WebAnalyticsScene.tsx
🟢 products/product_analytics/frontend/insights/trends/WorldMap/countryVectors.tsx stays out of src/scenes/web-analytics/WebAnalyticsScene.tsx
🟢 src/queries/validators.js stays out of src/scenes/web-analytics/WebAnalyticsScene.tsx
🟢 node_modules/re2js/ stays out of src/scenes/web-analytics/WebAnalyticsScene.tsx
🟢 node_modules/kea-test-utils/ stays out of src/scenes/web-analytics/WebAnalyticsScene.tsx
🟢 src/scenes/debug/HogDebug.tsx stays out of src/scenes/web-analytics/WebAnalyticsScene.tsx
🟢 src/queries/QueryEditor/QueryEditor.tsx stays out of src/scenes/web-analytics/WebAnalyticsScene.tsx
🟢 packages/quill/packages/quill/dist/ stays out of src/scenes/session-recordings/detail/SessionRecordingDetail.tsx
🟢 src/scenes/settings/SettingsMap.tsx stays out of src/scenes/session-recordings/detail/SessionRecordingDetail.tsx
🟢 @jspm/core/nodelibs/browser/fs stays out of src/scenes/session-recordings/detail/SessionRecordingDetail.tsx
🟢 node_modules/re2js/ stays out of src/scenes/session-recordings/detail/SessionRecordingDetail.tsx
🟢 node_modules/kea-test-utils/ stays out of src/scenes/session-recordings/detail/SessionRecordingDetail.tsx
🟢 node_modules/d3/src/ stays out of src/scenes/session-recordings/detail/SessionRecordingDetail.tsx

Largest files eagerly shipped from src/index.tsx

Size	File
126.8 KiB	`../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js`
24.6 KiB	`../node_modules/.pnpm/buffer@6.0.3/node_modules/buffer/index.js`
6.3 KiB	`../node_modules/.pnpm/react@18.3.1/node_modules/react/cjs/react.production.min.js`
4.7 KiB	`../node_modules/.pnpm/@jspm+core@2.1.0/node_modules/@jspm/core/nodelibs/browser/process.js`
4.0 KiB	`../node_modules/.pnpm/scheduler@0.23.2/node_modules/scheduler/cjs/scheduler.production.min.js`
1.9 KiB	`src/lib/utils/bootTiming.ts`
1.7 KiB	`src/index.tsx`
1.7 KiB	`../node_modules/.pnpm/base64-js@1.5.1/node_modules/base64-js/index.js`
1.2 KiB	`src/RootErrorBoundary.tsx`
1.1 KiB	`src/lib/utils/deferredAppContext.ts`

Largest files eagerly shipped from src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts

Size	File
325.3 KiB	`../node_modules/.pnpm/posthog-js@1.444.1_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs`
224.1 KiB	`../node_modules/.pnpm/@posthog+icons@0.39.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js`
126.8 KiB	`../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js`
104.2 KiB	`src/products.tsx`
88.3 KiB	`src/lib/api.ts`
68.7 KiB	`src/lib/lemon-ui/icons/icons.tsx`
41.9 KiB	`../node_modules/.pnpm/@dnd-kit+core@6.0.8_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@dnd-kit/core/dist/core.esm.js`
36.4 KiB	`../node_modules/.pnpm/kea@4.0.0-pre.6_patch_hash=139b8d1f1304f9d9da452a9a1244c94ea679dbcb85687d8999563146879fb6f5_react@18.3.1/node_modules/kea/lib/index.cjs.js`
28.2 KiB	`src/lib/constants.tsx`
24.6 KiB	`../node_modules/.pnpm/buffer@6.0.3/node_modules/buffer/index.js`

Largest files eagerly shipped from src/scenes/AuthenticatedShell.tsx

Size	File
325.3 KiB	`../node_modules/.pnpm/posthog-js@1.444.1_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs`
224.1 KiB	`../node_modules/.pnpm/@posthog+icons@0.39.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js`
126.8 KiB	`../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js`
104.2 KiB	`src/products.tsx`
88.3 KiB	`src/lib/api.ts`
68.7 KiB	`src/lib/lemon-ui/icons/icons.tsx`
41.9 KiB	`../node_modules/.pnpm/@dnd-kit+core@6.0.8_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@dnd-kit/core/dist/core.esm.js`
36.4 KiB	`../node_modules/.pnpm/kea@4.0.0-pre.6_patch_hash=139b8d1f1304f9d9da452a9a1244c94ea679dbcb85687d8999563146879fb6f5_react@18.3.1/node_modules/kea/lib/index.cjs.js`
32.7 KiB	`src/lib/utils/eventUsageLogic.ts`
28.2 KiB	`src/lib/constants.tsx`

Largest files eagerly shipped from src/scenes/dashboard/Dashboard.tsx

Size	File
325.3 KiB	`../node_modules/.pnpm/posthog-js@1.444.1_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs`
224.1 KiB	`../node_modules/.pnpm/@posthog+icons@0.39.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js`
126.8 KiB	`../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js`
108.9 KiB	`../packages/quill/packages/primitives/dist/index.js`
104.2 KiB	`src/products.tsx`
94.6 KiB	`../node_modules/.pnpm/@tiptap+core@3.20.6_@tiptap+pm@3.20.6/node_modules/@tiptap/core/dist/index.js`
92.6 KiB	`../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js`
90.4 KiB	`../packages/quill/packages/components/dist/index.js`
88.3 KiB	`src/lib/api.ts`
84.9 KiB	`../node_modules/.pnpm/posthog-js@1.444.1_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/surveys-preview.js`

Largest files eagerly shipped from

src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx

Size	File
325.3 KiB	`../node_modules/.pnpm/posthog-js@1.444.1_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs`
224.1 KiB	`../node_modules/.pnpm/@posthog+icons@0.39.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js`
126.8 KiB	`../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js`
108.9 KiB	`../packages/quill/packages/primitives/dist/index.js`
104.2 KiB	`src/products.tsx`
88.3 KiB	`src/lib/api.ts`
68.7 KiB	`src/lib/lemon-ui/icons/icons.tsx`
68.0 KiB	`../products/posthog_ai/frontend/logics/runStreamLogic.ts`
41.9 KiB	`../node_modules/.pnpm/@dnd-kit+core@6.0.8_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@dnd-kit/core/dist/core.esm.js`
36.4 KiB	`../node_modules/.pnpm/kea@4.0.0-pre.6_patch_hash=139b8d1f1304f9d9da452a9a1244c94ea679dbcb85687d8999563146879fb6f5_react@18.3.1/node_modules/kea/lib/index.cjs.js`

Largest files eagerly shipped from

src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/ai-first/AiFirstHomepage.tsx

Size	File
325.3 KiB	`../node_modules/.pnpm/posthog-js@1.444.1_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs`
224.1 KiB	`../node_modules/.pnpm/@posthog+icons@0.39.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js`
126.8 KiB	`../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js`
108.9 KiB	`../packages/quill/packages/primitives/dist/index.js`
104.2 KiB	`src/products.tsx`
88.3 KiB	`src/lib/api.ts`
68.7 KiB	`src/lib/lemon-ui/icons/icons.tsx`
68.0 KiB	`../products/posthog_ai/frontend/logics/runStreamLogic.ts`
41.9 KiB	`../node_modules/.pnpm/@dnd-kit+core@6.0.8_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@dnd-kit/core/dist/core.esm.js`
41.7 KiB	`src/scenes/hog-functions/sub-templates/sub-templates.ts`

Largest files eagerly shipped from src/scenes/activity/explore/EventsScene.tsx

Size	File
325.3 KiB	`../node_modules/.pnpm/posthog-js@1.444.1_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs`
224.1 KiB	`../node_modules/.pnpm/@posthog+icons@0.39.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js`
126.8 KiB	`../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js`
108.9 KiB	`../packages/quill/packages/primitives/dist/index.js`
104.2 KiB	`src/products.tsx`
94.6 KiB	`../node_modules/.pnpm/@tiptap+core@3.20.6_@tiptap+pm@3.20.6/node_modules/@tiptap/core/dist/index.js`
92.6 KiB	`../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js`
90.4 KiB	`../packages/quill/packages/components/dist/index.js`
88.3 KiB	`src/lib/api.ts`
75.3 KiB	`src/scenes/dashboard/dashboardLogic.tsx`

Largest files eagerly shipped from src/scenes/web-analytics/WebAnalyticsScene.tsx

Size	File
325.3 KiB	`../node_modules/.pnpm/posthog-js@1.444.1_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs`
224.1 KiB	`../node_modules/.pnpm/@posthog+icons@0.39.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js`
126.8 KiB	`../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js`
108.9 KiB	`../packages/quill/packages/primitives/dist/index.js`
104.2 KiB	`src/products.tsx`
94.6 KiB	`../node_modules/.pnpm/@tiptap+core@3.20.6_@tiptap+pm@3.20.6/node_modules/@tiptap/core/dist/index.js`
92.6 KiB	`../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js`
90.4 KiB	`../packages/quill/packages/components/dist/index.js`
88.3 KiB	`src/lib/api.ts`
84.9 KiB	`../node_modules/.pnpm/posthog-js@1.444.1_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/surveys-preview.js`

Largest files eagerly shipped from src/scenes/session-recordings/detail/SessionRecordingDetail.tsx

Size	File
325.3 KiB	`../node_modules/.pnpm/posthog-js@1.444.1_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs`
320.2 KiB	`../node_modules/.pnpm/posthog-js@1.444.1_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/rrweb.js`
224.1 KiB	`../node_modules/.pnpm/@posthog+icons@0.39.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js`
126.8 KiB	`../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js`
108.9 KiB	`../packages/quill/packages/primitives/dist/index.js`
104.2 KiB	`src/products.tsx`
94.6 KiB	`../node_modules/.pnpm/@tiptap+core@3.20.6_@tiptap+pm@3.20.6/node_modules/@tiptap/core/dist/index.js`
92.6 KiB	`../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js`
90.4 KiB	`../packages/quill/packages/components/dist/index.js`
88.3 KiB	`src/lib/api.ts`

_{Posted automatically by check-eager-graph · sizes are eager output bytes (shipped, post-tree-shake) from the esbuild metafile · part of #32479}

✅ Frontend layers — no new upward imports, 0 removed

Static imports from a lower frontend layer into a higher one (layers, lowest first: kernel, shell, query, features). Compared with the base branch, so an import that a PR also adds to layer-baseline.txt still shows here. Sizes are the source bytes on the eager path of every logged-in page.

Layer	Eager source bytes	Δ vs base
kernel	2.97 MiB	no change
shell	2.39 MiB	no change
query	56.4 KiB	no change
features	378.4 KiB	no change

Download the interactive layer graph for this PR.

_{Posted automatically by check-layers}

✅ Toolbar bundle — eager 2.34 MiB within budget

What the toolbar ships to customer pages, measured from the esbuild output (minified, post-tree-shake). The eager set is the entry plus everything statically imported from it — fetched before any feature runs; deferred chunks load lazily. The eager guardrail is 5.72 MiB. Each output file must also stay below 10 MB, where CloudFront stops compressing it. The module boundary is enforced separately by check-toolbar-graph.

Metric	Size	Δ vs base	Budget
Eager (shipped) entry + static imports	2.34 MiB · 19 files	no change	`████░░░░░░` 40.9% of 5.72 MiB
Deferred (lazy)	2.11 MiB · 42 files	no change	n/a — loads on demand
Loader `dist/toolbar.js`	1.2 KiB	no change	`█░░░░░░░░░` 6.0% of 19.5 KiB

Largest eagerly-shipped chunks

Size	File
945.3 KiB	`dist/toolbar/toolbar-app-QS4Q6LXG.css`
696.3 KiB	`dist/toolbar/chunk-chunk-2XISQML6.js`
261.2 KiB	`dist/toolbar/chunk-chunk-3AAXJSHY.js`
131.8 KiB	`dist/toolbar/chunk-chunk-FDH2IBXT.js`
130.3 KiB	`dist/toolbar/chunk-chunk-5SRACUKB.js`
75.7 KiB	`dist/toolbar/toolbar-app-HEBYI3O7.js`
69.0 KiB	`dist/toolbar/chunk-chunk-TSAL54PB.js`
33.8 KiB	`dist/toolbar/chunk-chunk-D3RCKWKR.js`
21.7 KiB	`dist/toolbar/chunk-chunk-2EHJZ2UI.js`
6.8 KiB	`dist/toolbar/chunk-chunk-DV7IWQNF.js`

_{Posted automatically by check-toolbar-size · sizes are toolbar output bytes (shipped, post-tree-shake) from the esbuild metafile}

✅ Dist folder size — 🔺 +4.4 KiB (+0.0%)

Total size of the built frontend/dist folder (all assets), compared against the base branch.

Total: 967.07 MiB · 🔺 +4.4 KiB (+0.0%)

✅ Playwright — all passed

All tests passed.

View test results →

posthog

PostHog Review · Standard · reviewed 54129ac: 1 Should fix.

This is the only automatic review while this pull request is a draft. Comment @posthog review to review new changes sooner. Otherwise, a review of the new changes runs when you mark it ready for review.

See this review and its findings in PostHog Review. Comment @posthog review --deep for a Deep review. A Deep review takes longer and looks deeper than a Standard review.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

parameterai · 2026-11-03T01:05:00Z

Risk: No findings

The increment since the last review adds a feature-flag gate (groupingFlagEnabled) and a lockedGroupBy selector to the logs alert form, making the purely cosmetic frontend grouping gate more restrictive, plus tests. Backend enforcement in platform_ownership.py (_refuse_grouping_on_logs, on_created, and the update path at lines 93-94) still rejects grouping for logs-owned alerts, so no security-relevant behavior changed.

_{Sentinel reviewed 6cc31a2 · Review settings}

…up-by-first-alert # Conflicts: # products/logs/frontend/components/LogsAlerting/logsAlertFormLogic.ts # products/logs/frontend/components/LogsAlerting/logsAlertGrouping.ts

stamphog

Approved.

The alert write-path change has owning-team authorship and strong familiarity as assurance, with a regression test added. No actionable unresolved review concern or other refusal ground is evidenced in the supplied context and current code.

Author wrote 100% of the modified lines and has 3 merged PRs in these paths (familiarity STRONG).

Gate mechanics and policy version

Gate		Result
prerequisites	✓	all clear
deny-list	✓	no deny categories matched
size	✓	59L, 3F substantive, 60L/4F incl. docs/generated/snapshots — within ceiling
tier	✓	T1-agent / T1b-small (60L, 4F, single-area, feat)
stamphog 2.7.0		`.stamphog/policy.yml` @ `6cc31a2` · reviewed head `6cc31a2`

jzhu13 · 2026-11-03T02:14:34Z

/trunk merge

deployment-status-posthog · 2026-11-03T03:00:18Z

Deploy status

Environment	Status	Deployed At	Workflow
dev	✅ Deployed	2026-11-03 03:00 UTC	Run
prod-us	✅ Deployed	2026-11-03 03:19 UTC	Run
prod-eu	✅ Deployed	2026-11-03 03:12 UTC	Run

jzhu13 self-assigned this Nov 2, 2026

posthog Bot reviewed Nov 2, 2026

View reviewed changes

Comment thread products/logs/frontend/components/LogsAlerting/logsAlertGrouping.ts Resolved

chore(logs): regenerate logs alert form logic types

f93d76d

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

jzhu13 marked this pull request as ready for review November 3, 2026 01:04

pr-assigner-resolver-posthog Bot requested a review from a team November 3, 2026 01:05

Merge remote-tracking branch 'origin/master' into feat/logs-alert-gro…

6cc31a2

…up-by-first-alert # Conflicts: # products/logs/frontend/components/LogsAlerting/logsAlertFormLogic.ts # products/logs/frontend/components/LogsAlerting/logsAlertGrouping.ts

jzhu13 added the stamphog Request AI approval (no full review) label Nov 3, 2026

stamphog Bot approved these changes Nov 3, 2026

View reviewed changes

trunk-io Bot merged commit 3631a2f into master Nov 3, 2026
241 checks passed

trunk-io Bot deleted the feat/logs-alert-group-by-first-alert branch November 3, 2026 02:34

This was referenced Nov 3, 2026

perf(ci): scan only the formats a change set touches #126727

Merged

perf(ci): size a narrowed Storybook run from the timing manifest #127960

Merged

Navigation Menu

Repository navigation

feat(logs): offer group by on a team's first logs alert - #127858

feat(logs): offer group by on a team's first logs alert#127858
trunk-io[bot] merged 3 commits into
masterfrom
feat/logs-alert-group-by-first-alert

jzhu13 commented Nov 2, 2026 •

edited

Loading

Uh oh!

trunk-io Bot commented Nov 2, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Nov 2, 2026 •

edited

Loading

Uh oh!

posthog Bot left a comment

Uh oh!

Uh oh!

parameterai Bot commented Nov 3, 2026 •

edited

Loading

Uh oh!

stamphog Bot left a comment

Uh oh!

jzhu13 commented Nov 3, 2026

Uh oh!

Uh oh!

deployment-status-posthog Bot commented Nov 3, 2026 •

edited

Loading

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

jzhu13 commented Nov 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Changes

How did you test this code?

Release status

Docs update

🤖 Agent context

Uh oh!

trunk-io Bot commented Nov 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Nov 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 CI report

Uh oh!

posthog Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

parameterai Bot commented Nov 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stamphog Bot left a comment

Choose a reason for hiding this comment

Uh oh!

jzhu13 commented Nov 3, 2026

Uh oh!

Uh oh!

deployment-status-posthog Bot commented Nov 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploy status

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

jzhu13 commented Nov 2, 2026 •

edited

Loading

trunk-io Bot commented Nov 2, 2026 •

edited

Loading

github-actions Bot commented Nov 2, 2026 •

edited

Loading

parameterai Bot commented Nov 3, 2026 •

edited

Loading

deployment-status-posthog Bot commented Nov 3, 2026 •

edited

Loading