Skip to content

chore(ci): use the vendored paths-filter in the desktop workflows - #127397

Merged
trunk-io[bot] merged 1 commit into
masterfrom
claude/desktop-vendored-paths-filter
Nov 2, 2026
Merged

trunk-io[bot] merged 1 commit into
masterfrom
claude/desktop-vendored-paths-filter

Conversation

@robbie-c

@robbie-c robbie-c commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Problem

Changes

  • desktop-ci, desktop-build, desktop-quality, desktop-test and desktop-typecheck run the vendored action. The desktop suites that a PR runs do not change.
  • Each changes job gets a sparse checkout of .github/actions/paths-filter, because a local action must be on disk. The job gets contents: read for that checkout.
  • The predicate-quantifier: every input goes away, because the vendored action has none.
  • Each desktop filter has one include and some excludes. For that shape, every and the vendored include/exclude matching select the same files.
  • Mechanical: the filters, the outputs, the app token and the job conditions do not change.

How did you test this code?

Test rationale: No new test. The workflow-plan suite already pins the desktop filters, and the comparison above checks the matching.

Release status

  • No feature flag controls this change

Docs update

  • None. No doc describes the desktop change detection.

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

Agent: Claude Code, Claude Opus 5.5 (claude-opus-5-5)

Skills: /authoring-ci-workflows, /writing-pr-descriptions, /asd-ste100

  • No duplicate: a search of open PRs found none.
  • CodeRabbit: skipped.
More context for AI agents
  • Session: the Claude Code session behind chore(ci): stop the rust crate version checks from timing out #127240 found the upstream action while it checked which change detector the repo approves.
  • Decisions: the checkout step copies the filter step's if:, so a master push, a schedule or a dispatch run does not check out anything.
  • Decisions: persist-credentials: false on the new checkouts, to match every other checkout in these files.
  • Decisions: no new App token. The existing GH_APP_POSTHOG_PATHS_FILTER token goes to the vendored action through the same token input.

🤖 Generated with Claude Code

The five desktop workflows ran upstream dorny/paths-filter, which every
other workflow left for the vendored copy in .github/actions/paths-filter.
Each change-detection job now checks out only that action and runs it,
and gains contents: read for the checkout.

The predicate-quantifier input goes away because the vendored action has
none. Each desktop filter has one include and some excludes, so `every`
and the vendored include/exclude matching select the same files.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@trunk-io

trunk-io Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

😎 Merged successfully - details.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

🤖 CI report

⚠️ Trunk lane — backend Python lane

This PR is assigned to the backend Python lane. It runs backend Python tests and may merge in parallel with PRs in other lanes.

@hosthog

hosthog Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

HostHog preview — posthog-desktop-web

The previews for this PR have been torn down and no longer serve.

@robbie-c
robbie-c marked this pull request as ready for review November 2, 2026 16:50
@robbie-c robbie-c added the stamphog Request AI approval (no full review) label Nov 2, 2026
@parameterai

parameterai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Risk: No findings

This PR swaps the upstream dorny/paths-filter action for the repo-vendored copy in the five desktop CI workflows, adding a sparse, pinned checkout of the action directory and the minimal contents: read permission for it. I verified the dropped predicate-quantifier: every cannot skip suites: the vendored per-file include/exclude matching is a superset of every for these one-include-plus-excludes filters, so desktop jobs can only run more often, and the child workflows stay fail-closed when detection fails.

Sentinel reviewed 5296251 · Review settings

@stamphog stamphog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not approved — this change needs a human reviewer.

Re-adding the stamphog label gives the same result unless the changed files change.

stamphog can't approve this pull request. The deny-list gate refused it because all five changed files (desktop-build.yml, desktop-ci.yml, desktop-quality.yml, desktop-test.yml and desktop-typecheck.yml) are CI workflow files under .github/workflows/. stamphog approves those paths only for authors on team-devex. The tier gate also classified the change as T2-never, so it is not eligible for automated review.

The next step is to ask a human reviewer, ideally someone on team-devex, to review this pull request.

Gate mechanics and policy version
Gate Result
prerequisites ✓ all clear
deny-list ✗ matches: ci_workflows (stamphog approves these paths only for authors on team-devex)
size ✓ 55L, 5F substantive — within ceiling
tier ✗ classified as T2-never: T2-never (55L, 5F, single-area, chore)
stamphog 2.7.0 .stamphog/policy.yml @ unknown · reviewed head 5296251

@stamphog stamphog Bot removed the stamphog Request AI approval (no full review) label Nov 2, 2026
@pr-assigner-resolver-posthog
pr-assigner-resolver-posthog Bot requested a review from a team November 2, 2026 16:51
@trunk-io
trunk-io Bot merged commit 109c342 into master Nov 2, 2026
330 checks passed
@trunk-io
trunk-io Bot deleted the claude/desktop-vendored-paths-filter branch November 2, 2026 21:31
@deployment-status-posthog

deployment-status-posthog Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Deploy status

Environment Status Deployed At Workflow
dev ✅ Deployed 2026-11-02 21:59 UTC Run
prod-us ✅ Deployed 2026-11-02 22:24 UTC Run
prod-eu ✅ Deployed 2026-11-02 22:18 UTC Run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants