Repository navigation
chore(ci): use the vendored paths-filter in the desktop workflows - #127397
Conversation
The five desktop workflows ran upstream dorny/paths-filter, which every other workflow left for the vendored copy in .github/actions/paths-filter. Each change-detection job now checks out only that action and runs it, and gains contents: read for the checkout. The predicate-quantifier input goes away because the vendored action has none. Each desktop filter has one include and some excludes, so `every` and the vendored include/exclude matching select the same files. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
😎 Merged successfully - details. |
🤖 CI report
|
HostHog preview —
|
|
Risk: No findings This PR swaps the upstream Sentinel reviewed |
There was a problem hiding this comment.
Not approved — this change needs a human reviewer.
Re-adding the stamphog label gives the same result unless the changed files change.
stamphog can't approve this pull request. The deny-list gate refused it because all five changed files (desktop-build.yml, desktop-ci.yml, desktop-quality.yml, desktop-test.yml and desktop-typecheck.yml) are CI workflow files under .github/workflows/. stamphog approves those paths only for authors on team-devex. The tier gate also classified the change as T2-never, so it is not eligible for automated review.
The next step is to ask a human reviewer, ideally someone on team-devex, to review this pull request.
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✗ | matches: ci_workflows (stamphog approves these paths only for authors on team-devex) |
| size | ✓ | 55L, 5F substantive — within ceiling |
| tier | ✗ | classified as T2-never: T2-never (55L, 5F, single-area, chore) |
| stamphog 2.7.0 | .stamphog/policy.yml @ unknown · reviewed head 5296251 |
Problem
dorny/paths-filteraction..github/actions/paths-filter. That gave the repo one change detector and removed the external supply-chain pin.Changes
desktop-ci,desktop-build,desktop-quality,desktop-testanddesktop-typecheckrun the vendored action. The desktop suites that a PR runs do not change.changesjob gets a sparse checkout of.github/actions/paths-filter, because a local action must be on disk. The job getscontents: readfor that checkout.predicate-quantifier: everyinput goes away, because the vendored action has none.everyand the vendored include/exclude matching select the same files.How did you test this code?
bin/hogli lint:workflows, actionlint 1.7.12 andhogli test:workflowspass. The last one includes the test that keeps the desktop filters in sync.hogli ci:plangives the same job table as master for all five workflows. The new checkout runs only in the scenarios where the filter step runs.codeandquality_codestay false. This checks the excludes.desktop-cidetector fails, so this PR's run covers thedesktop-cidetector alone.desktop-*.ymlthe desktop product's two lanes,py:product:desktopandfe:product:desktop. The report calls any lane set with apy:target the backend Python lane. No change to this diff moves it.Test rationale: No new test. The workflow-plan suite already pins the desktop filters, and the comparison above checks the matching.
Release status
Docs update
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Agent: Claude Code, Claude Opus 5.5 (
claude-opus-5-5)Skills:
/authoring-ci-workflows,/writing-pr-descriptions,/asd-ste100More context for AI agents
if:, so a master push, a schedule or a dispatch run does not check out anything.persist-credentials: falseon the new checkouts, to match every other checkout in these files.GH_APP_POSTHOG_PATHS_FILTERtoken goes to the vendored action through the sametokeninput.🤖 Generated with Claude Code