Repository navigation
fix(workflows): report a test send with no recipient as skipped - #127281
Conversation
…result Every other skip branch sets emailSendResult, so test send surfaces can tell the user nothing went out. The missing-recipient branch did not, and the workflow step test panel showed Success. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
😎 Merged successfully - details. |
🤖 CI report✅ Trunk lane — non-backend laneThis PR is assigned to the non-backend lane. It does not run backend Python tests and may merge in parallel with PRs in other lanes. ✅ Duplication (Python) — cleanNew Python code duplication introduced by this branch. Fails at 70+ tokens in app code, or 150+ tokens when both copies live in test files. Advisory while the gate proves itself: extract a shared helper instead of copying. ✅ Duplication (TypeScript) — cleanNew TypeScript code duplication introduced by this branch. Fails at 70+ tokens in app code, or 150+ tokens when both copies live in test files. Advisory while the gate proves itself: extract a shared helper instead of copying. |
HostHog preview —
|
…ng-recipient-result
|
Risk: No findings The PR makes the worker's missing-recipient skip path in EmailService report an Sentinel reviewed |
There was a problem hiding this comment.
Approved.
The response change enters API territory, with assurance supplied by owning-team authorship and a targeted test assertion. No unresolved review concerns or other refusal grounds were found.
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 6L, 1F substantive, 10L/2F incl. docs/generated/snapshots — within ceiling |
| tier | ✓ | T1-agent / T1a-trivial (10L, 2F, single-area, fix) |
| stamphog 2.7.0 | .stamphog/policy.yml @ ee1f371 · reviewed head ee1f371 |
|
/trunk merge |
Problem
Note
🔵 Merge risk: low · two-way door (merge-risk rubric)
git revertthe merge commit.Changes
emailSendResult, like the other skip branches.How did you test this code?
Local stack at ee1f371, invented data:
Test rationale: the empty-recipient
it.eachnow assertsemailSendResult, which fails on master.Raw test endpoint response at ee1f371 (trimmed)
Release status
Docs update
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Agent: Claude Code, Claude Opus 5.5
Skills:
/writing-tests,/writing-pr-descriptionsMore context for AI agents
skippedsemantics.executeSendEmailskip branches, with a stated rule for whenskippedis set.emailSendResult. Expect a small textual conflict.🤖 Generated with Claude Code