Repository navigation
feat(cdp): deliver a code send's content on its own transactional email route #127122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,336
β294
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
969011f
feat(cdp): deliver a code send's content on its own transactional emaβ¦
Silthus 920e7c9
fix(cdp): read the primary once for concurrent jobs of a missing workβ¦
Silthus 4c7375d
Merge remote-tracking branch 'upstream/master' into email-v2/01-cdp-cβ¦
Silthus b5889c9
Merge remote-tracking branch 'upstream/master' into email-v2/01-cdp-cβ¦
Silthus 27bfa23
fix(cdp): mint no distinct_id in tracking codes of a capture-off send
Silthus b9b0865
test(cdp): cover the capture choice in dev/test pixel and redirect codes
Silthus 28d56e7
refactor(cdp): drop the dormant v3 tracking-code format
Silthus e7fc40c
fix(cdp): cache and batch confirmed primary misses
Silthus b7e2f40
fix(cdp): cache primary hits during replica lag
Silthus 4255bac
fix(cdp): keep no primary result from a read a reload overtook
Silthus 9a9eb8d
fix(cdp): resolve email feedback for a workflow only the primary has
Silthus 4f0d3d7
fix(cdp): keep workflows found when a feedback lookup fails
Silthus ac6e18c
Merge remote-tracking branch 'origin/master' into rhs3-cdp-code-send-fix
Silthus abbf035
fix(cdp): count a failed primary lookup for email feedback
Silthus e2fd437
chore: merge master into email-v2/01-cdp-code-send
Silthus fc855c3
fix(cdp): refuse a code send field this version does not know
Silthus 34347b2
fix(cdp): refuse unknown fields inside a code send's content, sender β¦
Silthus 474a766
chore(cdp): drop the comment on the strict send schema
Silthus 272024a
fix(cdp): accept only a code-send token on the code send route
Silthus 8be4b84
Merge remote-tracking branch 'origin/master' into email-v2/01-cdp-codβ¦
Silthus ddea17d
refactor(cdp): lay a code send over the email step in the send hand-off
Silthus 1be8e50
fix(cdp): replay a code send on rerun only when the request allows it
Silthus b5c9e59
refactor(cdp): read the capture choice in one place
Silthus 2eac306
fix(cdp): keep a code send's choices when a step resumes from saved sβ¦
Silthus 0aa7884
fix(cdp): accept every dot-atom recipient the email pipeline can send to
Silthus 3639e5d
fix(cdp): keep dots between the characters of a recipient's local part
Silthus ccdd9ff
fix(cdp): tell the user why a sensitive run was not re-run
Silthus 75f7a34
Merge remote-tracking branch 'origin/master' into HEAD
Silthus 20fb623
fix(cdp): call a skipped sensitive run's content a message, not an email
Silthus eb26545
chore(cdp): send the executor's email routing tests through a mocked SES
Silthus 6f4136c
fix(cdp): refuse a code send token on the template send route
Silthus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.