Skip to content

ci(playwright): run queue gate jobs on depot runners - #125810

Merged
trunk-io[bot] merged 3 commits into
masterfrom
raul/pw-gate-jobs-depot
Oct 30, 2026
Merged

trunk-io[bot] merged 3 commits into
masterfrom
raul/pw-gate-jobs-depot

Conversation

@rnegron

@rnegron rnegron commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

Problem

  • Merge-queue runs wait twice for a GitHub-hosted runner before Playwright tests pass reports.
p90 runner wait, 7 days GitHub-hosted Depot
All jobs, 6:00-11:59 PT 214 s 1-2 s
This workflow, queue runs 99.5-123 s 1 s
  • Gate median on 2026-10-29: 17.3 min at 12-13 UTC, 24.0 min at 16-17 UTC.

Changes

Queue runs move the two GitHub-hosted gate-path jobs to Depot.

flowchart LR
    A[changes<br/>GitHub-hosted] --> B[playwright<br/>Depot] --> C[vr-complete<br/>Depot] --> D[Playwright tests pass<br/>GitHub-hosted]
    class A,D phRed;
    class B,C phBlue;
    classDef phBlue fill:#1d4aff,stroke:#1d4aff,color:#fff;
    classDef phRed fill:#f54e00,stroke:#f54e00,color:#fff;
Loading
flowchart LR
    A[changes<br/>Depot] --> B[playwright<br/>Depot] --> C[vr-complete<br/>Depot] --> D[Playwright tests pass<br/>Depot]
    class A,B,C,D phBlue;
    classDef phBlue fill:#1d4aff,stroke:#1d4aff,color:#fff;
Loading
  • changes and the gate pick depot-ubuntu-24.04 on trunk-merge/ runs only.
  • Cost at list price: about +$38 a month.
  • The authoring skill notes the exception.

Warning

Depot 2-vCPU jobs hang with 0 steps 59 times per 10k, against 1.6 on GitHub-hosted (14 days). A hung gate fails the queue attempt (example), so expect about 1% more kicks.

How did you test this code?

  • The gate ran on Depot on this draft (run).
  • Not run: the trunk-merge/ expression, which only a queue run exercises.

Test rationale: No job condition changes.

Release status

  • None.

Docs update

  • None.

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

Agent: Claude Code, claude-opus-5-5

@trunk-io

trunk-io Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

😎 Merged successfully - details.

@rnegron
rnegron added this pull request to stack #125812 October 29, 2026 19:19
@rnegron rnegron changed the title raul/pw gate jobs depot ci(playwright): run gate-path 1x jobs on depot runners Oct 29, 2026
@rnegron rnegron self-assigned this Oct 29, 2026
@hosthog

hosthog Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

HostHog preview — posthog-desktop-web

The previews for this PR have been torn down and no longer serve.

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

🤖 CI report

⚠️ Trunk lane — backend Python lane

This PR is assigned to the backend Python lane. It runs backend Python tests and may merge in parallel with PRs in other lanes.

✅ Playwright — all passed

All tests passed.

View test results →

@parameterai

parameterai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Risk: No findings

This increment adds !startsWith(github.head_ref, 'trunk-merge/') to the debounce step's condition, so merge-queue runs skip the 60-second supersession wait and go straight to the gate. The change only removes a cost-saving veto on queue runs — it makes the gate more likely to run, never less — and the concurrency group (cancel-in-progress on pull_request) handles queue re-pushes. No security-relevant surface is added or weakened.

Sentinel reviewed b6d5cb2 · Review settings

@pr-assigner-resolver-posthog
pr-assigner-resolver-posthog Bot requested a review from a team October 30, 2026 13:53
@rnegron rnegron added the stamphog Request AI approval (no full review) label Oct 30, 2026
stamphog[bot]

This comment was marked as outdated.

@stamphog
stamphog Bot dismissed their stale review October 30, 2026 15:22

A new stamphog review started for this PR — the fresh verdict replaces this approval.

@rnegron rnegron changed the title ci(playwright): run gate-path 1x jobs on depot runners ci(playwright): run queue gate jobs on depot runners Oct 30, 2026

@stamphog stamphog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

The change enters CI territory, with owning-team authorship providing the policy's assurance path. No unresolved review concerns or other refusal grounds are present.

  • Author wrote 33% of the modified lines and has 98 merged PRs in these paths (familiarity MODERATE).
Gate mechanics and policy version
Gate Result
prerequisites ✓ all clear
deny-list ✓ no deny categories matched
size ✓ 7L, 1F substantive, 9L/2F incl. docs/generated/snapshots — within ceiling
tier ✓ T1-agent / T1b-small (9L, 2F, two-areas, ci)
stamphog 2.6.1 .stamphog/policy.yml @ 7918cbd · reviewed head 7918cbd

@trunk-io
trunk-io Bot merged commit 3e19729 into master Oct 30, 2026
201 checks passed
@trunk-io
trunk-io Bot deleted the raul/pw-gate-jobs-depot branch October 30, 2026 19:35
@deployment-status-posthog

deployment-status-posthog Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Deploy status

Environment Status Deployed At Workflow
dev ✅ Deployed 2026-10-30 20:02 UTC Run
prod-us ✅ Deployed 2026-10-30 20:23 UTC Run
prod-eu ✅ Deployed 2026-10-30 20:14 UTC Run

fuziontech added a commit that referenced this pull request Nov 2, 2026
Master condensed the Runners section of the skill and moved the e2e queue jobs
onto the trunk-merge-only Depot rule (#125810), so its text and its runs-on
expressions win here; this branch's job is the debounce hardening, not a runner
strategy change.

Correct the timeout rationale to the 120s the merged debounce step actually
sleeps, and record that the window is anchored to the run's created_at.

Co-authored-by: Shelley <shelley@exe.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stamphog Request AI approval (no full review)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant