Skip to content

feat(ingestion): treat the Freebuff bfcid as a campaign property - #117217

Merged
trunk-io[bot] merged 1 commit into
masterfrom
feat/freebuff-bfcid
Oct 14, 2026
Merged

feat(ingestion): treat the Freebuff bfcid as a campaign property#117217
trunk-io[bot] merged 1 commit into
masterfrom
feat/freebuff-bfcid

Conversation

@rafaeelaudibert

@rafaeelaudibert rafaeelaudibert commented Oct 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Problem

Freebuff appends a signed click ID, bfcid, to ad click URLs (https://example.com/?bfcid=bfc_1...). PostHog treats every other network's click ID as a campaign property (gclid, fbclid, msclkid, oppref and more) but not this one. A bfcid that reaches ingestion today arrives as an ordinary custom property: no latest-touch bfcid or first-touch $initial_bfcid on the person, no taxonomy label, and no first-touch flag targeting.

This is the server half. The SDK half is PostHog/posthog-js#5300, which captures the parameter from the URL. It also helps teams that already capture it by hand with custom_campaign_params: ['bfcid'].

Changes

Each service keeps its own copy of the campaign property list, so bfcid is added to all of them, right after oppref, the same set of files #103854 touched:

  • nodejs/src/common/persons/person-property-utils.ts: ingestion now writes bfcid to $set and $initial_bfcid to $set_once.
  • posthog/taxonomy/taxonomy.py: the campaign list plus a property definition ("Freebuff Click ID"), so bfcid, $initial_bfcid and the latest-touch form are labelled in filters. The generated frontend/src/taxonomy/core-filter-definitions-by-group.json is rebuilt from it.
  • rust/personhog-common/src/properties.rs: the event-to-person property allowlist.
  • rust/feature-flags/src/flags/flag_matching_utils.rs: the event property to $initial_ mapping used when evaluating flags.
  • rust/property-defs-rs/src/api/v1/constants.rs: the label alias mirror of the Django taxonomy, array size bumped to 246.

Deliberately out of scope, the same split as oppref:

  • Session columns: $entry_bfcid and $entry_has_bfcid come from feat(sessions): ship the sessions v3 schema with more ad click ids #104566 (sessions v3 ad IDs), which is stacked on this PR. Channel-type classification is unchanged.
  • ignore_custom_properties in posthog/clickhouse/property_groups.py, which is baked into column DDL.
  • products/marketing_analytics attribution health, which maps click IDs to native ad integrations. Freebuff has none.

Reference: Freebuff conversion tracking docs.

How did you test this code?

Test rationale: No new tests. The change is six list entries, and each list is already covered by tests of campaign-property behaviour as a whole (for example the $initial_gclid assertions in flag_matching_utils.rs). A test per entry would assert the entry, not a behaviour.

What ran locally:

  • The taxonomy JSON was regenerated through posthog/taxonomy/projection.py render() and formatted with the locked oxfmt 0.57.0. The JSON diff is the three expected bfcid entries only.
  • ruff format --check and ruff check (locked 0.15.20) on taxonomy.py, and rustfmt --check on the three Rust files.
  • PROPERTY_DEFINITION_ALIASES holds 246 entries, matching the declared size.
  • No Python, Rust or nodejs test suite was run locally, and the Node file was not run through its prettier config. CI is the check for those.

Release status

  • No feature flag controls this change

Docs update

None needed for this PR. The UTM segmentation docs list the auto-captured click IDs and can mention bfcid once both halves ship.

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

Agent: Claude Code, Claude Opus 5.5

  • No duplicate: searches of open and closed PRs in both repos for bfcid and freebuff found nothing.
  • Modelled on feat(ingestion): treat the OpenAI Ads oppref as a campaign property #103854 (oppref). A repo-wide search for lists that contain sccid found no other non-migration campaign list that oppref also lives in.
  • The commit hook could not run in a light worktree without node_modules, so the commit used --no-verify after the manual checks above.
  • No repo skills were invoked. Nothing here comes from a non-public source: the parameter name and behaviour come from Freebuff's public docs.

@rafaeelaudibert @claude
feat(ingestion): treat the Freebuff bfcid as a campaign property
369e208 
Freebuff appends a signed click ID, `bfcid`, to ad click URLs. Add it to every
service's copy of the campaign property list, next to `oppref`, so ingestion
sets `bfcid` and `$initial_bfcid`, the taxonomy labels it, feature flags can
target on first touch, and the person property allowlist keeps it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@rafaeelaudibert rafaeelaudibert self-assigned this Oct 14, 2026
@trunk-io

trunk-io Bot commented Oct 14, 2026 •
edited
Loading

Copy link
Copy Markdown

😎 Stack merged successfully - details.

@rafaeelaudibert rafaeelaudibert mentioned this pull request Oct 14, 2026
Merged
7 of 23 tasks
@github-actions

github-actions Bot commented Oct 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🤖 CI report

⚠️ Trunk lane — backend Python lane, mixes lanes

This PR is assigned to the backend Python lane. It runs backend Python tests and may merge in parallel with PRs in other lanes.

This PR changes Python or frontend code (frontend/src/taxonomy/core-filter-definitions-by-group.json, posthog/taxonomy/taxonomy.py) and Node or Rust code (nodejs/src/common/persons/person-property-utils.ts, rust/feature-flags/src/flags/flag_matching_utils.rs, rust/personhog-common/src/properties.rs and 1 more) together. In the merge queue, every Node or Rust PR behind it in the same lane then runs the Django and frontend suites too, so the cross-lane check fails. Split it, or add the cross-lane-change label if the halves must land together.

✅ Duplication (Python) — clean

New Python code duplication introduced by this branch. Fails at 70+ tokens in app code, or 150+ tokens when both copies live in test files. Advisory while the gate proves itself: extract a shared helper instead of copying.

✅ Duplication (TypeScript) — clean

New TypeScript code duplication introduced by this branch. Fails at 70+ tokens in app code, or 150+ tokens when both copies live in test files. Advisory while the gate proves itself: extract a shared helper instead of copying.

⚠️ Bundle size — 🔺 +550 B (+0.0%)

Uncompressed size of every built .js bundle, compared against the base branch.

Total: 76.51 MiB · 🔺 +550 B (+0.0%)

No file changed by more than 1000 B.

Posted automatically by build-bundle-size-report · uncompressed bytes from dist-report

✅ Eager graph — within budget

How much code each root ships on the eager path — downloaded and parsed before the surface is interactive. Measured from the esbuild output chunks (post-tree-shake, static imports only); lazy import() / React.lazy chunks are not counted.

Root Eager (shipped) Δ vs base Budget
entry (logged-out pages, app bootstrap)
src/index.tsx		 1005.4 KiB · 23 files no change █████████░ 85.8% of 1.14 MiB
logged-out boot: index + App + bootApp (preloaded by every page, including /login)
src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts		 2.87 MiB · 606 files no change █████████░ 94.6% of 3.03 MiB
authenticated shell (every logged-in page)
src/scenes/AuthenticatedShell.tsx		 7.49 MiB · 2,560 files 🔺 +275 B (+0.0%) ██████████ 98.0% of 7.64 MiB
dashboard scene
src/scenes/dashboard/Dashboard.tsx		 9.63 MiB · 3,614 files 🔺 +275 B (+0.0%) █████████░ 93.5% of 10.30 MiB
today home path
src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx		 7.51 MiB · 2,570 files 🔺 +275 B (+0.0%) ██████████ 95.3% of 7.89 MiB
events scene
src/scenes/activity/explore/EventsScene.tsx		 9.21 MiB · 3,441 files 🔺 +275 B (+0.0%) █████████░ 93.3% of 9.88 MiB
replay detail scene
src/scenes/session-recordings/detail/SessionRecordingDetail.tsx		 11.95 MiB · 4,288 files 🔺 +275 B (+0.0%) ████████░░ 79.4% of 15.05 MiB

🟢 node_modules/monaco-editor/ stays out of src/index.tsx
🟢 src/lib/components/ActivityLog/describers stays out of src/index.tsx
🟢 node_modules/@posthog/brand/dist/generated/hoggies/svg/ stays out of src/index.tsx
🟢 node_modules/@posthog/brand/dist/generated/hoggies/components/ stays out of src/index.tsx
🟢 node_modules/monaco-editor/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/layout/navigation-3000/navigationLogic.tsx stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/scenes/dashboard/dashboardLogic.tsx stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/lemon-ui/LemonMarkdown/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/components/RichContentEditor/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/components/CodeSnippet/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/taxonomy/core-filter-definitions-by-group.json stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 node_modules/zod/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/scenes/billing/billingLogic.tsx stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/components/ProductEmptyState/productSetupPreloadLogic.ts stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 node_modules/monaco-editor/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/lib/components/ActivityLog/describers stays out of src/scenes/AuthenticatedShell.tsx
🟢 products/dashboards/frontend/widgets/previews/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/scenes/session-recordings/player/sessionRecordingPlayerLogic.ts stays out of src/scenes/AuthenticatedShell.tsx
🟢 zod/v4/locales/de.js stays out of src/scenes/AuthenticatedShell.tsx
🟢 node_modules/@posthog/brand/dist/generated/hoggies/svg/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 node_modules/@posthog/brand/dist/generated/hoggies/components/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/scenes/session-recordings/playlist/SessionRecordingsPlaylist.tsx stays out of src/scenes/dashboard/Dashboard.tsx
🟢 src/scenes/web-analytics/tiles/WebAnalyticsTile.tsx stays out of src/scenes/dashboard/Dashboard.tsx
🟢 src/scenes/project-homepage/ai-first/AiFirstHomepage.tsx stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx
🟢 src/scenes/project-homepage/today/TodayReportPage.tsx stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx
🟢 src/queries/Query/Query.tsx stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx
🟢 src/scenes/session-recordings/playlist/SessionRecordingsPlaylist.tsx stays out of src/scenes/activity/explore/EventsScene.tsx
🟢 src/scenes/web-analytics/tiles/WebAnalyticsTile.tsx stays out of src/scenes/activity/explore/EventsScene.tsx

Largest files eagerly shipped from src/index.tsx
Size File
126.8 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
24.6 KiB ../node_modules/.pnpm/buffer@6.0.3/node_modules/buffer/index.js
6.3 KiB ../node_modules/.pnpm/react@18.3.1/node_modules/react/cjs/react.production.min.js
4.5 KiB ../node_modules/.pnpm/@jspm+core@2.1.0/node_modules/@jspm/core/nodelibs/browser/process.js
3.9 KiB ../node_modules/.pnpm/scheduler@0.23.2/node_modules/scheduler/cjs/scheduler.production.min.js
1.4 KiB ../node_modules/.pnpm/base64-js@1.5.1/node_modules/base64-js/index.js
1.3 KiB src/RootErrorBoundary.tsx
1.3 KiB src/index.tsx
912 B ../node_modules/.pnpm/ieee754@1.2.1/node_modules/ieee754/index.js
839 B src/scenes/ChunkLoadErrorBoundary.tsx
Largest files eagerly shipped from src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
Size File
319.8 KiB ../node_modules/.pnpm/posthog-js@1.438.8_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs
220.8 KiB ../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js
126.8 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
105.7 KiB src/products.tsx
99.6 KiB src/lib/api.ts
69.0 KiB src/lib/lemon-ui/icons/icons.tsx
38.7 KiB ../node_modules/.pnpm/@dnd-kit+core@6.0.8_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@dnd-kit/core/dist/core.esm.js
33.9 KiB ../node_modules/.pnpm/kea@4.0.0-pre.6_patch_hash=139b8d1f1304f9d9da452a9a1244c94ea679dbcb85687d8999563146879fb6f5_react@18.3.1/node_modules/kea/lib/index.cjs.js
28.7 KiB src/scenes/scenes.ts
27.6 KiB src/lib/constants.tsx
Largest files eagerly shipped from src/scenes/AuthenticatedShell.tsx
Size File
319.8 KiB ../node_modules/.pnpm/posthog-js@1.438.8_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs
281.1 KiB src/taxonomy/core-filter-definitions-by-group.json
220.8 KiB ../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js
185.5 KiB ../packages/quill/packages/quill/dist/index.js
153.7 KiB ../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js
139.9 KiB ../packages/quill/packages/primitives/dist/index.js
126.8 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
105.7 KiB src/products.tsx
99.6 KiB src/lib/api.ts
93.3 KiB ../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js
Largest files eagerly shipped from src/scenes/dashboard/Dashboard.tsx
Size File
319.8 KiB ../node_modules/.pnpm/posthog-js@1.438.8_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs
281.1 KiB src/taxonomy/core-filter-definitions-by-group.json
220.8 KiB ../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js
185.5 KiB ../packages/quill/packages/quill/dist/index.js
181.9 KiB src/queries/validators.js
153.7 KiB ../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js
139.9 KiB ../packages/quill/packages/primitives/dist/index.js
126.8 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
105.7 KiB src/products.tsx
99.6 KiB src/lib/api.ts
Largest files eagerly shipped from src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx
Size File
319.8 KiB ../node_modules/.pnpm/posthog-js@1.438.8_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs
281.1 KiB src/taxonomy/core-filter-definitions-by-group.json
220.8 KiB ../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js
185.5 KiB ../packages/quill/packages/quill/dist/index.js
153.7 KiB ../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js
139.9 KiB ../packages/quill/packages/primitives/dist/index.js
126.8 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
105.7 KiB src/products.tsx
99.6 KiB src/lib/api.ts
93.3 KiB ../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js
Largest files eagerly shipped from src/scenes/activity/explore/EventsScene.tsx
Size File
319.8 KiB ../node_modules/.pnpm/posthog-js@1.438.8_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs
281.1 KiB src/taxonomy/core-filter-definitions-by-group.json
220.8 KiB ../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js
185.5 KiB ../packages/quill/packages/quill/dist/index.js
181.9 KiB src/queries/validators.js
153.7 KiB ../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js
139.9 KiB ../packages/quill/packages/primitives/dist/index.js
126.8 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
105.7 KiB src/products.tsx
99.6 KiB src/lib/api.ts
Largest files eagerly shipped from src/scenes/session-recordings/detail/SessionRecordingDetail.tsx
Size File
319.8 KiB ../node_modules/.pnpm/posthog-js@1.438.8_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs
316.0 KiB ../node_modules/.pnpm/posthog-js@1.438.8_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/rrweb.js
281.1 KiB src/taxonomy/core-filter-definitions-by-group.json
220.8 KiB ../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js
185.5 KiB ../packages/quill/packages/quill/dist/index.js
181.9 KiB src/queries/validators.js
153.7 KiB ../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js
126.8 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
105.7 KiB src/products.tsx
99.6 KiB src/lib/api.ts

Posted automatically by check-eager-graph · sizes are eager output bytes (shipped, post-tree-shake) from the esbuild metafile · part of #32479

✅ Toolbar bundle — eager 2.23 MiB within budget

What the toolbar ships to customer pages, measured from the esbuild output (minified, post-tree-shake). The eager set is the entry plus everything statically imported from it — fetched before any feature runs; deferred chunks load lazily. The eager guardrail is 5.72 MiB. Each output file must also stay below 10 MB, where CloudFront stops compressing it. The module boundary is enforced separately by check-toolbar-graph.

Metric Size Δ vs base Budget
Eager (shipped)
entry + static imports		 2.23 MiB · 19 files no change ████░░░░░░ 39.0% of 5.72 MiB
Deferred (lazy) 2.10 MiB · 40 files 🔺 +275 B (+0.0%) n/a — loads on demand
Loader dist/toolbar.js 1.2 KiB no change █░░░░░░░░░ 6.0% of 19.5 KiB
Largest eagerly-shipped chunks
Size File
874.4 KiB dist/toolbar/toolbar-app-CJ67DKKN.css
664.0 KiB dist/toolbar/chunk-chunk-L6DWFRG6.js
257.8 KiB dist/toolbar/chunk-chunk-IVAG7WAO.js
131.8 KiB dist/toolbar/chunk-chunk-FDH2IBXT.js
129.6 KiB dist/toolbar/chunk-chunk-3SJHY2HV.js
74.7 KiB dist/toolbar/toolbar-app-S65JCOHI.js
69.0 KiB dist/toolbar/chunk-chunk-TSAL54PB.js
35.6 KiB dist/toolbar/chunk-chunk-GYJS6WES.js
21.7 KiB dist/toolbar/chunk-chunk-Z6TKEIXJ.js
6.8 KiB dist/toolbar/chunk-chunk-DV7IWQNF.js

Posted automatically by check-toolbar-size · sizes are toolbar output bytes (shipped, post-tree-shake) from the esbuild metafile

✅ Dist folder size — 🔺 +4.5 KiB (+0.0%)

Total size of the built frontend/dist folder (all assets), compared against the base branch.

Total: 1014.03 MiB · 🔺 +4.5 KiB (+0.0%)

✅ Playwright — all passed

All tests passed.

View test results →

✅ Hogbox preview — ready, open the preview

▶ Open the preview
🔑 Login test@posthog.com / 12345678 (demo data)
🧩 Running this PR's backend and frontend, on the PostHog :master base
🔗 Link stable across rebuilds: a re-push swaps the box underneath, the URL stays
🔒 Access tailnet only (PostHog VPN)
🛠️ Admin inspect & debug state in hogland
💤 Idle sleeps after ~30 min idle (snapshot to S3, zero node cost) and wakes on your next visit in ~30s, behind a brief "waking up" screen

commit 369e208 · box box-1df9858e4bbd · ready in 1399s (push → usable) · build log · rebuilds on every push, torn down on close

@trunk-io

trunk-io Bot commented Oct 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Static Badge   Static Badge   Static Badge

Failed Test Failure Summary Logs
Scenes-App/Project Homepage ProjectHomepage smoke-test The test timed out while waiting for loading indicators or spinners to disappear. Logs ↗︎
Scenes-App/Experiments ExperimentWithHealthFindings play-test The Storybook test could not find the text “Why?” because the story remained on a loading spinner. Logs ↗︎
Scenes-Other/Startup program NeedsBillingDetails smoke-test The test timed out while waiting for loading indicators or spinners to disappear. Logs ↗︎
Scenes-App/People/Person PersonNotFound smoke-test The test timed out while waiting for loading indicators or spinners to disappear. Logs ↗︎

View Full Report ↗︎ ⋅ Docs

@rafaeelaudibert rafaeelaudibert mentioned this pull request Oct 14, 2026
Merged
@rafaeelaudibert
rafaeelaudibert marked this pull request as ready for review October 14, 2026 18:56
@graphite-app graphite-app Bot added the stamphog Request AI approval (no full review) label Oct 14, 2026
@parameterai

parameterai Bot commented Oct 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Risk: No findings

This PR registers the Freebuff bfcid click-ID as a campaign property across the ingestion pipeline: nodejs person-property mapping, personhog's trim-protection allowlist, flag-matching $initial_ mapping, and taxonomy labels (Python plus generated JSON and the Rust alias mirror). The change is purely additive and mirrors the existing oppref entry exactly; every list it touches is a data-labeling or property-promotion concern, not an authorization or injection boundary, and I found no security impact.

Sentinel reviewed 369e208 · Review settings

@pr-assigner-resolver-posthog
pr-assigner-resolver-posthog Bot requested a review from a team October 14, 2026 18:57
@pr-assigner-resolver-posthog

pr-assigner-resolver-posthog Bot commented Oct 14, 2026

Copy link
Copy Markdown

👀 Auto-assigned reviewers

These soft owners were skipped because they only have minor changes here. Nothing blocks merge, so self-assign if you'd like a look:

  • @PostHog/team-ingestion (rust/owners.yaml)
  • @PostHog/team-feature-flags (rust/owners.yaml)

Soft owners come from each directory's owners.yaml and each product's product.yaml (resolved nearest-file-wins). For a skipped owner, the locator is the file that decided it. Generated files and lockfiles are ignored when deciding ownership.

stamphog[bot]
stamphog Bot approved these changes Oct 14, 2026
View reviewed changes

@stamphog stamphog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Touches ingestion behavior, with independent current-head assurance reported by the trusted context. No unresolved substantive concerns or other refusal grounds were found.

  • PostHog Review (Standard) reviewed the current head: no findings.
Gate mechanics and policy version
Gate Result
prerequisites ✓ all clear
deny-list ✓ no deny categories matched
size ✓ 23L, 6F substantive — within ceiling
tier ✓ T1-agent / T1d-complex (23L, 6F, cross-cutting, feat)
stamphog 2.5.1 .stamphog/policy.yml @ 369e208 · reviewed head 369e208

@trunk-io
trunk-io Bot merged commit fcee5a8 into master Oct 14, 2026
@trunk-io
trunk-io Bot deleted the feat/freebuff-bfcid branch October 14, 2026 19:51
@deployment-status-posthog

deployment-status-posthog Bot commented Oct 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Deploy status

Environment Status Deployed At Workflow
dev ✅ Deployed 2026-10-14 20:13 UTC Run
prod-us ✅ Deployed 2026-10-14 20:32 UTC Run
prod-eu ✅ Deployed 2026-10-14 20:31 UTC Run

This branch was successfully deployed

1 active deployment
hogbox-preview — 369e2084 Deployed Oct 14, 2026 by github-actions[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lricoy lricoy lricoy approved these changes
@stamphog stamphog[bot] stamphog[bot] approved these changes

Assignees

@rafaeelaudibert rafaeelaudibert

Labels

stamphog Request AI approval (no full review)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rafaeelaudibert @lricoy