Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Contributor
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, please remove the |
Contributor
|
This PR was closed due to lack of activity. Feel free to reopen if it's still relevant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
cdp-functions-create,cdp-functions-partial-update,error-tracking-alerts-createanderror-tracking-alerts-partial-updateMCP tools can set four internal input fields:templating,order,bytecodeandtranspiled.inputs.*.templating), but the generated schema still exposes them. The*segment steps only into arrays, andinputsis a dict.exclude_paramsentry that names no field, so a typo or a stale name also leaves a field exposed.Supersedes #112291 (closed), rebased on current master. Fork handoff: Silthus/posthog#346. The open draft #112861 stacks on #112291 and can rebase onto this PR.
Note
🔵 Merge risk: low · two-way door (merge-risk rubric)
Changes
templating,order,bytecodeortranspiledoninputs.*andmappings.*.inputs.*.*in an exclusion path now steps into dict values (additionalProperties) as well as array items.exclude_paramsentry names no query parameter or request body path. The error names the tool and the entry.dashboard-updatelist that master kept.How did you test this code?
Test rationale:
exclusions.test.mjsgains dict-traversal cases that fail on the old array-only*.generate-tools.test.tsgains cases for the no-field error. The schema snapshots prove the four fields leave the tool schemas.generate-tools.test.tsandexclusions.test.mjslocally on the rebased branch: they pass.hogli build:openapion the rebased branch: it succeeds and changes no generated file, so no stale exclusion is left on master.Release status
Docs update
Updated
docs/published/handbook/engineering/ai/implementing-mcp-tools.mdwith the dict traversal and the new error.🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Agent: T3 Code with Claude Code, Claude Opus 5.5 (
claude-opus-5-5). Cross-family review: Codex, GPT-6.1 Sol (gpt-6.1-sol), high reasoning effort, read-only.60187c17de7. Master expanded thedashboard-updatedescription. That text stays, and its stale exclusion list goes.