Skip to content

fix(workflows): retry ses-throttled emails instead of dropping them #112295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trunk-io merged 2 commits into from
Oct 8, 2026
Merged

fix(workflows): retry ses-throttled emails instead of dropping them #112295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ebb06a
fix(workflows): retry ses-throttled emails instead of dropping them
Silthus Oct 6, 2026
9668491
chore(workflows): drop comments on the ses throttle retry
Silthus Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions nodejs/src/cdp/services/messaging/email.service.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,6 +420,7 @@ describe('EmailService', () => {
// than the upper bound + scheduler overhead.
expect(scheduledMs).toBeGreaterThanOrEqual(before + 400)
expect(scheduledMs).toBeLessThan(before + 2000)
expect(result.invocation.queueParameters).toEqual(invocation.queueParameters)
// No business metric emitted on throttle — the eventual retry
// will produce email_sent.
expect(result.metrics ?? []).toEqual([])
Expand Down
1 change: 1 addition & 0 deletions nodejs/src/cdp/services/messaging/email.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,6 +627,7 @@ export class EmailService {
// catches the cases where SES disagrees with our estimate.
throttled = true
result.finished = false
result.invocation.queueParameters = params
result.invocation.queueScheduledAt = DateTime.utc().plus({ milliseconds: error.retryAfterMs })
addLog('warn', `SES rate-limited (${error.errorCode}); rescheduling email in ${error.retryAfterMs}ms`)
} else {
Expand Down