Skip to content

chore(data-warehouse): remove data quality tab from data ops - #110906

Merged
trunk-io[bot] merged 2 commits into
masterfrom
ux/data-ops-remove-data-quality-tab
Oct 2, 2026
Merged

trunk-io[bot] merged 2 commits into
masterfrom
ux/data-ops-remove-data-quality-tab

Conversation

@sakce

@sakce sakce commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Data Ops shows a Data quality tab that duplicates the Data quality tab on the Models scene. Two homes for one overview splits where people look for check health.

Changes

  • Data Ops no longer shows a Data quality tab.
  • The overview stays on the Models scene, unchanged.
  • Old links with ?tab=data-quality on Data Ops fall back to the default tab.

How did you test this code?

  • Ran the Data Ops scene Jest tests on a devbox. No test referenced the removed tab.
  • No browser check of the Data Ops scene.

Release status

  • No feature flag controls this change
  • This change is behind a feature flag and is not available to users
  • This change makes a previously flagged feature available to everyone

Automatic notifications

  • Publish to changelog?

Docs update

None.

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

Agent: Claude Code, Opus 5.5

  • Written with Claude Code on a devbox. Skills: /setting-up-devbox, /writing-pr-descriptions.
  • The CodeRabbit local pass is paused, so this PR opened without one.
  • Duplicate search (gh pr list --search "data ops data quality tab") found nothing.
  • First of a small batch of data modeling UX edits; the rest ship in feat(data-modeling): add endpoint lineage tab and metric scene polish #110915.

🤖 Generated with Claude Code

The same overview lives on the models scene's data quality tab.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sakce sakce added the skip-agent-review Save $$$, skip auto agent reviews (Greptile) — use for trivial or chore PRs label Oct 2, 2026
@sakce sakce self-assigned this Oct 2, 2026
@trunk-io

trunk-io Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

😎 Merged successfully - details.

@sakce
sakce requested a review from thiagosalvatore October 2, 2026 14:38
@sakce
sakce marked this pull request as ready for review October 2, 2026 14:40
@parameterai

parameterai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Risk: No findings

The PR removes the duplicate Data quality tab from the Data Ops scene and updates the e2e test to exercise the same edit/delete flow on the Models scene overview. The only delta since the last review is that Playwright spec change; it introduces no security surface.

Sentinel reviewed 2f99c86 · Review settings

@github-actions

github-actions Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

🦔 Hogbox preview · ✅ ready

▶ Open the preview

🔑 Login test@posthog.com / 12345678 (demo data)
🧩 Running this PR's backend and frontend, on the PostHog :master base
🔗 Link stable across rebuilds — a re-push swaps the box underneath, the URL stays
🔒 Access tailnet only (PostHog VPN)
🛠️ Admin inspect & debug state in hogland
💤 Idle sleeps after ~30 min idle (snapshot to S3, zero node cost) and wakes on your next visit in ~30s, behind a brief "waking up" screen

commit 2f99c86 · box box-26763324323e · ready in 822s (push → usable) · build log · rebuilds on every push, torn down on close

@coderabbitai

coderabbitai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

🧰 Additional context used
📚 Code guidelines (3)
.agents/security.md — configured
.agents/skills/writing-tests/SKILL.md — configured
.agents/skills/writing-code-comments/SKILL.md — configured

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: PostHog/posthog/.coderabbit.yaml

Review profile: QUIET

Plan: Enterprise

Run ID: 7735c119-e309-469e-b055-7c4f046cdbed

📥 Commits

Reviewing files that changed from the base of the PR and between fcf0b83 and 2f99c86.

📒 Files selected for processing (1)
  • playwright/e2e/data-quality-overview.spec.ts

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The Data Warehouse scene no longer defines or offers the Data Quality tab. It also no longer maps a label to the tab or renders DataQualityOverview. The Playwright test now navigates to the data-quality tab from Models and does not enable DATA_WAREHOUSE_SCENE.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 2f99c

Data Quality remains available from Models, and the updated test uses that route and exercises the overview controls. No actionable merge-blocking risk is identified.

Architecture Summary

Architecture risk: 🔵 Low · up to 2f99c

The change affects 2 systems.

Changed systems: products, playwright

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — products (ui) was modified; 2 changed files map to changed impact.
  • observed — playwright (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in products/data_warehouse/frontend/scenes/DataOpsScene/DataWarehouseScene.tsx: The DataQualityOverview import was removed.
  • observed — Modified behavior in products/data_warehouse/frontend/scenes/DataOpsScene/DataWarehouseScene.tsx: The DATA_QUALITY tab’s Data quality label mapping was removed.
  • observed — Modified behavior in products/data_warehouse/frontend/scenes/DataOpsScene/DataWarehouseScene.tsx: The DATA_QUALITY switch case that rendered DataQualityOverview was removed.
  • observed — Modified behavior in products/data_warehouse/frontend/scenes/DataOpsScene/dataWarehouseSceneLogic.ts: Removed the DATA_QUALITY member from the exported DataWarehouseTab enum.
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The description covers the problem, user-visible changes, testing, release status, notifications, documentation, and agent context. It does not include the required Test rationale entry, a screenshot …
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

🤖 CI report

✅ Trunk lane — non-backend lane

This PR is assigned to the non-backend lane. It does not run backend Python tests and may merge in parallel with PRs in other lanes.

✅ Complexity (TypeScript) — clean

Cyclomatic complexity above the limit in changed typescript files (10 for production files, 15 for test files). Warn only: worth simplifying when you next touch these functions.

✅ Duplication (Python) — clean

New Python code duplication introduced by this branch. Fails at 70+ tokens in app code, or 150+ tokens when both copies live in test files. Advisory while the gate proves itself: extract a shared helper instead of copying.

✅ Duplication (TypeScript) — clean

New TypeScript code duplication introduced by this branch. Fails at 70+ tokens in app code, or 150+ tokens when both copies live in test files. Advisory while the gate proves itself: extract a shared helper instead of copying.

⚠️ Bundle size — 🔺 +135.5 KiB (+0.2%)

Uncompressed size of every built .js bundle, compared against the base branch.

Total: 69.77 MiB · 🔺 +135.5 KiB (+0.2%)

File Size Δ vs base
posthog-app/src/scenes/project-homepage/ProjectHomepage.js 1.6 KiB 🟢 -58.3 KiB (-97.3%)
posthog-app/src/scenes/project-homepage/ai-first/AiFirstHomepage.js 43.4 KiB 🔺 +43.4 KiB (new)
posthog-app/src/scenes/AuthenticatedShell.js 266.7 KiB 🟢 -36.6 KiB (-12.1%)
posthog-app/src/layout/today/TodaySpacesPane.js 31.8 KiB 🔺 +31.8 KiB (new)
posthog-app/src/scenes/project-homepage/today/TodayReportPage.js 18.9 KiB 🔺 +18.9 KiB (new)
posthog-app/_parent/products/data_modeling/frontend/ModelsScene.js 58.3 KiB 🔺 +18.1 KiB (+44.8%)
posthog-app/src/scenes/project-homepage/today/TodayHome.js 10.3 KiB 🔺 +10.3 KiB (new)
posthog-app/src/layout/today/TodayViewsSidebar.js 8.5 KiB 🔺 +8.5 KiB (new)
posthog-app/src/layout/today/TodaySessionHoverCard.js 8.2 KiB 🔺 +8.2 KiB (new)
posthog-app/src/scenes/project-homepage/today/TodayReportHoverCard.js 6.8 KiB 🔺 +6.8 KiB (new)
posthog-app/src/layout/today/TodaySpaceHoverCard.js 6.6 KiB 🔺 +6.6 KiB (new)
posthog-app/_parent/products/tasks/frontend/spaces/NewSpaceDialog.js 5.5 KiB 🔺 +5.5 KiB (new)
posthog-app/src/layout/today/TodayToolsSidebar.js 2.1 KiB 🔺 +2.1 KiB (new)
posthog-app/src/layout/today/TodayChatHoverCard.js 2.0 KiB 🔺 +2.0 KiB (new)
posthog-app/src/layout/today/TodayLibrarySidebar.js 1.8 KiB 🔺 +1.8 KiB (new)

Posted automatically by build-bundle-size-report · uncompressed bytes from dist-report

✅ Eager graph — within budget

How much code each root ships on the eager path — downloaded and parsed before the surface is interactive. Measured from the esbuild output chunks (post-tree-shake, static imports only); lazy import() / React.lazy chunks are not counted.

Root Eager (shipped) Δ vs base Budget
entry (logged-out pages, app bootstrap)
src/index.tsx
1.63 MiB · 22 files 🟢 -98 B (-0.0%) █████████░ 88.6% of 1.84 MiB
logged-out boot: index + App + bootApp (preloaded by every page, including /login)
src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
3.72 MiB · 660 files 🔺 +408 B (+0.0%) █████████░ 92.3% of 4.03 MiB
authenticated shell (every logged-in page)
src/scenes/AuthenticatedShell.tsx
7.58 MiB · 2,405 files 🟢 -240.0 KiB (-3.0%) █████████░ 90.9% of 8.34 MiB
dashboard scene
src/scenes/dashboard/Dashboard.tsx
9.66 MiB · 3,389 files 🔺 +2.8 KiB (+0.0%) ███████░░░ 71.7% of 13.48 MiB
today home path
src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx
7.60 MiB · 2,413 files (no base measurement) █████████░ 88.5% of 8.58 MiB
events scene
src/scenes/activity/explore/EventsScene.tsx
9.28 MiB · 3,241 files 🔺 +2.7 KiB (+0.0%) ███████░░░ 73.4% of 12.64 MiB
replay detail scene
src/scenes/session-recordings/detail/SessionRecordingDetail.tsx
12.12 MiB · 4,129 files 🔺 +16.8 KiB (+0.1%) ████████░░ 77.1% of 15.72 MiB

🟢 node_modules/monaco-editor/ stays out of src/index.tsx
🟢 src/lib/components/ActivityLog/describers stays out of src/index.tsx
🟢 [object Object] stays out of src/index.tsx
🟢 [object Object] stays out of src/index.tsx
🟢 node_modules/monaco-editor/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/layout/navigation-3000/navigationLogic.tsx stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/scenes/dashboard/dashboardLogic.tsx stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/lemon-ui/LemonMarkdown/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/components/RichContentEditor/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/components/CodeSnippet/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/taxonomy/core-filter-definitions-by-group.json stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 node_modules/monaco-editor/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/lib/components/ActivityLog/describers stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/scenes/session-recordings/player/sessionRecordingPlayerLogic.ts stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/scenes/project-homepage/ai-first/AiFirstHomepage.tsx stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx
🟢 src/scenes/project-homepage/today/TodayReportPage.tsx stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx

Largest files eagerly shipped from src/index.tsx
Size File
126.8 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
24.6 KiB ../node_modules/.pnpm/buffer@6.0.3/node_modules/buffer/index.js
6.3 KiB ../node_modules/.pnpm/react@18.3.1/node_modules/react/cjs/react.production.min.js
4.5 KiB ../node_modules/.pnpm/@jspm+core@2.1.0/node_modules/@jspm/core/nodelibs/browser/process.js
3.9 KiB ../node_modules/.pnpm/scheduler@0.23.2/node_modules/scheduler/cjs/scheduler.production.min.js
1.4 KiB ../node_modules/.pnpm/base64-js@1.5.1/node_modules/base64-js/index.js
1.3 KiB src/index.tsx
1.3 KiB src/RootErrorBoundary.tsx
912 B ../node_modules/.pnpm/ieee754@1.2.1/node_modules/ieee754/index.js
854 B src/scenes/ChunkLoadErrorBoundary.tsx
Largest files eagerly shipped from src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
Size File
306.2 KiB ../node_modules/.pnpm/posthog-js@1.435.5_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs
220.3 KiB ../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js
126.8 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
100.5 KiB src/lib/api.ts
92.5 KiB src/products.tsx
69.4 KiB src/lib/lemon-ui/icons/icons.tsx
40.1 KiB src/lib/utils/eventUsageLogic.ts
38.7 KiB ../node_modules/.pnpm/@dnd-kit+core@6.0.8_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@dnd-kit/core/dist/core.esm.js
33.9 KiB ../node_modules/.pnpm/kea@4.0.0-pre.6_patch_hash=139b8d1f1304f9d9da452a9a1244c94ea679dbcb85687d8999563146879fb6f5_react@18.3.1/node_modules/kea/lib/index.cjs.js
29.0 KiB ../node_modules/.pnpm/zod@4.3.6/node_modules/zod/v4/core/schemas.js
Largest files eagerly shipped from src/scenes/AuthenticatedShell.tsx
Size File
306.2 KiB ../node_modules/.pnpm/posthog-js@1.435.5_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs
279.9 KiB src/taxonomy/core-filter-definitions-by-group.json
220.3 KiB ../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js
153.7 KiB ../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js
126.8 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
110.0 KiB ../packages/quill/packages/quill/dist/index.js
100.5 KiB src/lib/api.ts
93.3 KiB ../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js
92.5 KiB src/products.tsx
90.6 KiB ../node_modules/.pnpm/@tiptap+core@3.20.6_@tiptap+pm@3.20.6/node_modules/@tiptap/core/dist/index.js
Largest files eagerly shipped from src/scenes/dashboard/Dashboard.tsx
Size File
306.2 KiB ../node_modules/.pnpm/posthog-js@1.435.5_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs
279.9 KiB src/taxonomy/core-filter-definitions-by-group.json
220.3 KiB ../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js
181.8 KiB src/queries/validators.js
153.7 KiB ../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js
126.8 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
110.0 KiB ../packages/quill/packages/quill/dist/index.js
100.5 KiB src/lib/api.ts
93.3 KiB ../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js
92.5 KiB src/products.tsx
Largest files eagerly shipped from src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx
Size File
306.2 KiB ../node_modules/.pnpm/posthog-js@1.435.5_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs
279.9 KiB src/taxonomy/core-filter-definitions-by-group.json
220.3 KiB ../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js
153.7 KiB ../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js
126.8 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
110.0 KiB ../packages/quill/packages/quill/dist/index.js
100.5 KiB src/lib/api.ts
93.3 KiB ../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js
92.5 KiB src/products.tsx
90.6 KiB ../node_modules/.pnpm/@tiptap+core@3.20.6_@tiptap+pm@3.20.6/node_modules/@tiptap/core/dist/index.js
Largest files eagerly shipped from src/scenes/activity/explore/EventsScene.tsx
Size File
306.2 KiB ../node_modules/.pnpm/posthog-js@1.435.5_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs
279.9 KiB src/taxonomy/core-filter-definitions-by-group.json
220.3 KiB ../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js
181.8 KiB src/queries/validators.js
153.7 KiB ../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js
126.8 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
110.0 KiB ../packages/quill/packages/quill/dist/index.js
100.5 KiB src/lib/api.ts
93.3 KiB ../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js
92.5 KiB src/products.tsx
Largest files eagerly shipped from src/scenes/session-recordings/detail/SessionRecordingDetail.tsx
Size File
315.5 KiB ../node_modules/.pnpm/posthog-js@1.435.5_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/rrweb.js
306.2 KiB ../node_modules/.pnpm/posthog-js@1.435.5_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs
279.9 KiB src/taxonomy/core-filter-definitions-by-group.json
220.3 KiB ../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js
181.8 KiB src/queries/validators.js
153.7 KiB ../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js
126.8 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
110.0 KiB ../packages/quill/packages/quill/dist/index.js
100.5 KiB src/lib/api.ts
93.3 KiB ../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js

Posted automatically by check-eager-graph · sizes are eager output bytes (shipped, post-tree-shake) from the esbuild metafile · part of #32479

✅ Toolbar bundle — eager 2.20 MiB within budget

What the toolbar ships to customer pages, measured from the esbuild output (minified, post-tree-shake). The eager set is the entry plus everything statically imported from it — fetched before any feature runs; deferred chunks load lazily. The eager guardrail is 5.72 MiB. Each output file must also stay below 10 MB, where CloudFront stops compressing it. The module boundary is enforced separately by check-toolbar-graph.

Metric Size Δ vs base Budget
Eager (shipped)
entry + static imports
2.20 MiB · 19 files 🟢 -54 B (-0.0%) ████░░░░░░ 38.4% of 5.72 MiB
Deferred (lazy) 2.11 MiB · 44 files no change n/a — loads on demand
Loader dist/toolbar.js 1.2 KiB no change █░░░░░░░░░ 6.0% of 19.5 KiB
Largest eagerly-shipped chunks
Size File
834.2 KiB dist/toolbar/toolbar-app-LXAUZCP3.css
657.4 KiB dist/toolbar/chunk-chunk-PDXEE7YG.js
259.4 KiB dist/toolbar/chunk-chunk-EXS5VGKQ.js
138.2 KiB dist/toolbar/chunk-chunk-YTISI4G3.js
131.8 KiB dist/toolbar/chunk-chunk-FDH2IBXT.js
75.2 KiB dist/toolbar/toolbar-app-6G7F6XL7.js
69.0 KiB dist/toolbar/chunk-chunk-TSAL54PB.js
35.6 KiB dist/toolbar/chunk-chunk-U65TWWSR.js
21.0 KiB dist/toolbar/chunk-chunk-JYRTCG7P.js
6.8 KiB dist/toolbar/chunk-chunk-DV7IWQNF.js

Posted automatically by check-toolbar-size · sizes are toolbar output bytes (shipped, post-tree-shake) from the esbuild metafile

✅ Dist folder size — 🔺 +527.3 KiB (+0.1%)

Total size of the built frontend/dist folder (all assets), compared against the base branch.

Total: 959.79 MiB · 🔺 +527.3 KiB (+0.1%)

✅ Playwright — all passed

All tests passed.

View test results →

@pr-assigner-resolver-posthog
pr-assigner-resolver-posthog Bot requested a review from a team October 2, 2026 14:41
@greptile-apps

greptile-apps Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Retrigger

[Medium risk] Removes data quality tab from data warehouse UI.

The PR should not merge until the end-to-end test targets the Models data-quality tab.

Reviews (1) · Last reviewed commit: "chore(data-warehouse): remove data quali..."

@benben benben left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review generated on behalf of @benben.

Approve. Removes the Data quality tab from the Data Ops scene by dropping the enum member, label, render case, and flag-gated push. The TypeScript side is consistent and the URL fallback works via the existing tab clamping, but a Playwright e2e spec still drives the removed tab and will fail.

  • major playwright/e2e/data-quality-overview.spec.ts:48 Playwright spec still navigates to removed Data Ops data-quality tab. Spec goes to /data-ops?tab=data-quality and expects the checks overview, which now falls back to the default tab.

Model: fable, PR authored with opus.

@trunk-io

trunk-io Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

The Data Ops scene no longer has a data quality tab, so /data-ops?tab=data-quality falls back to the default tab and the spec timed out waiting for the check controls. The same overview still renders on the Models scene, so the test navigates there instead and only needs the data quality checks flag.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Generated-By: PostHog Desktop
Task-Id: 789f88f8-021d-4728-8b98-92c94b145315
@trunk-io
trunk-io Bot merged commit 5e6ba34 into master Oct 2, 2026
@trunk-io
trunk-io Bot deleted the ux/data-ops-remove-data-quality-tab branch October 2, 2026 16:40
@deployment-status-posthog

deployment-status-posthog Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Deploy status

Environment Status Deployed At Workflow
dev ✅ Deployed 2026-10-02 17:09 UTC Run
prod-us ✅ Deployed 2026-10-02 17:24 UTC Run
prod-eu ✅ Deployed 2026-10-02 17:21 UTC Run

This branch was successfully deployed

1 active deployment
preview-pr-110906 — 2f99c866 Deployed Oct 2, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-agent-review Save $$$, skip auto agent reviews (Greptile) — use for trivial or chore PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants