feat(flags): skip events writes for flag evaluations only orgs by haacked · Pull Request #110254 · PostHog/posthog

haacked · 2026-10-01T18:21:51Z

Problem

Organizations on the FLAG_EVALUATIONS_ONLY mode still get every $feature_flag_called event written to the events table.
New organizations are about to start on that mode. The rollout waits for ingestion to stop the events writes.
The flag readers move to flag_evaluations in feat(flags): read flag last_called_at for data freshness #110143, feat(flags): count projects tab evaluations from flag_evaluations #110148, feat(flags): read flag calls from flag_evaluations on the activity page #110149 and feat(flags): read last_called_at sync calls from flag_evaluations behind a setting #110150. This PR ships after them.
Experiments read $feature_flag_called from events while the experiment-exposure-event flag gates $experiment_exposure. chore(experiments): drop the exposure-event rollout flag check #106333 removes that flag, so on Cloud every experiment started after the cutoff counts exposures on $experiment_exposure, which still reaches events. Experiments started before the cutoff keep reading $feature_flag_called.

Changes

For a team whose organization is on FLAG_EVALUATIONS_ONLY, a $feature_flag_called call now lands only in flag_evaluations.
The fork step removes a call from eventsToEmit only after it queued that call's flag_evaluations row.
Every path that queues no row still writes to events: a team outside the ingestion allowlist, a call without a flag key, a mapping error, or a lane without the fork.
The $experiment_exposure copy still reaches events, and person processing still runs, because both happen before the fork.
INGESTION_FLAG_EVALUATIONS_ONLY_DISABLED=true makes ingestion treat the mode as READ_FLAG_EVALUATIONS for every team. One config change restores the events writes.
ingestion_flag_evaluations_events_total gains two outcomes: flag_evaluations_only and lost_message_too_large.
An oversized row for one of these teams now sends the message_size_too_large ingestion warning that emit-event would have sent.
create-event now passes team on to later steps, so the fork reads the mode without a team lookup. All three pipelines that use create-event already had team.
The staff mode modal warns about the events gap when it would lower an organization from FLAG_EVALUATIONS_ONLY.
Before a move to FLAG_EVALUATIONS_ONLY, the staff preview and set_flag_evaluations_mode show each organization's running experiments that count exposures on $feature_flag_called, and warn that those exposures stop for teams in the ingestion allowlist. A new experiments facade function counts them with the exposure query's own resolver, so it follows chore(experiments): drop the exposure-event rollout flag check #106333 once that lands.
The FlagEvaluationsMode docstrings, the staff API help_text and the parity check guide now describe the real behavior. These are text changes only, so there is no Django migration.

Warning

For these teams the flag_evaluations row is the only copy of the call. A produce that fails after the step returns loses the call. produce_failed counts it, and the FlagEvaluationsForkProduceFailing alert fires on it. A fallback write to events is out of scope.

Note

The CDP events consumer reads the same events topic. A destination or workflow triggered on $feature_flag_called stops seeing calls from these organizations.

Rollout prerequisites

Done in PostHog/charts#16740: the FlagEvaluationsForkStalled outcome regex includes flag_evaluations_only and lost_message_too_large, and the fork runbooks say a produce failure loses the call for these teams and name INGESTION_FLAG_EVALUATIONS_ONLY_DISABLED.
Before setting FLAG_EVALUATIONS_NEW_ORG_MODE, chore(experiments): drop the exposure-event rollout flag check #106333 merges or the experiment-exposure-event flag reaches every team, so new orgs' experiments count on $experiment_exposure. This PR itself can merge before either. After that, only an experiment started before the cutoff still reads $feature_flag_called from events, so no organization running one moves to FLAG_EVALUATIONS_ONLY. The staff preview and the command warn about such experiments.
No organization is on FLAG_EVALUATIONS_ONLY yet in either region, so the deploy itself stops no organization's events writes. Each organization moved to that mode afterwards stops them when it moves.

After deploy: move one internal test organization to FLAG_EVALUATIONS_ONLY with the staff tool, verify, then set FLAG_EVALUATIONS_NEW_ORG_MODE.

How did you test this code?

Test rationale: The fork step tests extend the existing fork-flag-evaluations-step.test.ts. They catch a call that leaves events when it should not, an $experiment_exposure copy that leaves with it, and a kill switch that does nothing. The service test catches createFlagEvaluationsService dropping the env kill switch, which the step tests cannot see because they build the service directly. One case in flag-evaluations-e2e.test.ts checks the whole pipeline for a mode-2 team: the person update lands, flag_evaluations gets the row, and events holds only the exposure copy.

Ran the fork step, flag evaluations service and create-event Jest suites locally.
Not run: the e2e case. The local ClickHouse lacks the test schema, so CI is its first run.
Not added: the test-new-events-schema label. The Python changes are docstrings and comments, and Backend CI does not run Node ingestion.

Release status

No feature flag controls this change
This change is behind a feature flag and is not available to users
This change makes a previously flagged feature available to everyone

The stored organization mode gates the behavior, and only organizations already on FLAG_EVALUATIONS_ONLY see it.

Automatic notifications

Publish to changelog?

Docs update

None. No doc under docs/ covers how ingestion writes these events.

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

Agent: Claude Code, Claude Opus 5.5 (Sonnet 5.5 for comment cleanup and the description)

Claude Code wrote the code from a plan the user wrote, running unattended through the /go pipeline. Session: https://claude.ai/code/session_012LLLo3Hxxc1Vhne69sC9Hi
Skills: /writing-tests, /writing-code-comments, /writing-user-facing-copy, /simplify, /reviewing-with-coderabbit, /writing-pr-descriptions. The pipeline-step and pipeline-result doctor agents reviewed the ingestion step.
An earlier version looked the team up with TeamManager.getTeam inside the fork. Simplify and the step doctor both pointed at create-event dropping team, so create-event now passes it through.
Declined: rethrowing produce errors for these teams. The plan accepts the loss, and a rejected side effect stops the pod on most hosts.
CodeRabbit CLI ran with --deep and reported no findings.
The /review-code runner stopped at synthesis after all eight reviewers reported, because it wanted a production query. The fixes in the second commit come from those reports. The experiments gap and the charts changes are listed under Rollout prerequisites.
Duplicate search: the open flag_evaluations PRs move readers. None changes ingestion writes.
Public artifact: nothing from the session beyond this repository is in the diff or this description.

trunk-io · 2026-10-01T18:21:55Z

😎 Merged successfully - details.

github-actions · 2026-10-01T18:22:04Z

🤖 CI report

⚠️

Trunk lane — backend Python lane

This PR is assigned to the backend Python lane. It runs backend Python tests and may merge in parallel with PRs in other lanes.

⚠️

Complexity (TypeScript) — 1 function above the limit (max 12)

Cyclomatic complexity above the limit in changed typescript files (10 for production files, 15 for test files). Warn only: worth simplifying when you next touch these functions.

Function	Location	Complexity	Limit
`StaffFlagEvaluationsModeModal`	`products/feature_flags/frontend/staff/StaffFlagEvaluationsModeModal.tsx:26`	12	10

✅ Duplication (Python) — clean

New Python code duplication introduced by this branch. Fails at 70+ tokens in app code, or 150+ tokens when both copies live in test files. Advisory while the gate proves itself: extract a shared helper instead of copying.

✅ Duplication (TypeScript) — clean

New TypeScript code duplication introduced by this branch. Fails at 70+ tokens in app code, or 150+ tokens when both copies live in test files. Advisory while the gate proves itself: extract a shared helper instead of copying.

🚨 Comment density — 10% of added code lines are comments (55 of 547)

This section warns when comments are more than 3% of the code lines a PR adds, and alerts above 6%. Before agent-assisted PRs, the typical share was about 2%. Only full-line comments count. Docstrings, generated files, snapshots, migrations, and workflow files are left out.

Comments that restate the code, record how the change came about, or narrate the next line add noise for the next reader. Keep the comments that explain a reason the code cannot show, and remove the rest. See .agents/skills/writing-code-comments/SKILL.md for the house rules.

Files with the most added comment lines:

File	Comment lines	Added lines
`nodejs/src/ingestion/common/steps/event-processing/fork-flag-evaluations-step.ts`	23	56
`nodejs/src/ingestion/common/steps/event-processing/fork-flag-evaluations-step.test.ts`	8	145
`nodejs/src/ingestion/common/flag-evaluations/flag-evaluations-service.ts`	6	21
`products/feature_flags/frontend/staff/featureFlagsStaffToolsLogic.test.ts`	4	20
`nodejs/tests/ingestion/flag-evaluations-e2e.test.ts`	3	41
`products/feature_flags/backend/facade/enums.py`	3	7
`nodejs/src/ingestion/config.ts`	2	4
`posthog/settings/feature_flags.py`	2	2

This check does not block merging. It updates on every push and clears when the share drops.

⚠️

Bundle size — 🔺 +1.1 KiB (+0.0%)

Uncompressed size of every built .js bundle, compared against the base branch.

Total: 70.71 MiB · 🔺 +1.1 KiB (+0.0%)

File	Size	Δ vs base
`posthog-app/_parent/products/feature_flags/frontend/staff/FeatureFlagsStaffToolsScene.js`	60.3 KiB	🔺 +1.1 KiB (+1.8%)

_{Posted automatically by build-bundle-size-report · uncompressed bytes from dist-report}

✅ Eager graph — within budget

How much code each root ships on the eager path — downloaded and parsed before the surface is interactive. Measured from the esbuild output chunks (post-tree-shake, static imports only); lazy import() / React.lazy chunks are not counted.

Root	Eager (shipped)	Δ vs base	Budget
entry (logged-out pages, app bootstrap) `src/index.tsx`	1.62 MiB · 22 files	no change	`█████████░` 87.9% of 1.84 MiB
logged-out boot: index + App + bootApp (preloaded by every page, including /login) `src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts`	3.58 MiB · 630 files	no change	`█████████░` 88.8% of 4.03 MiB
authenticated shell (every logged-in page) `src/scenes/AuthenticatedShell.tsx`	7.76 MiB · 2,486 files	no change	`█████████░` 93.0% of 8.34 MiB
dashboard scene `src/scenes/dashboard/Dashboard.tsx`	11.67 MiB · 4,475 files	no change	`█████████░` 86.6% of 13.48 MiB
project home scene `src/scenes/project-homepage/ProjectHomepage.tsx`	14.44 MiB · 5,365 files	no change	`█████████░` 87.9% of 16.44 MiB
events scene `src/scenes/activity/explore/EventsScene.tsx`	10.90 MiB · 4,134 files	no change	`█████████░` 86.3% of 12.64 MiB
replay detail scene `src/scenes/session-recordings/detail/SessionRecordingDetail.tsx`	13.79 MiB · 5,056 files	no change	`█████████░` 87.7% of 15.72 MiB

🟢 node_modules/monaco-editor/ stays out of src/index.tsx
🟢 src/lib/components/ActivityLog/describers stays out of src/index.tsx
🟢 [object Object] stays out of src/index.tsx
🟢 [object Object] stays out of src/index.tsx
🟢 node_modules/monaco-editor/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/layout/navigation-3000/navigationLogic.tsx stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/scenes/dashboard/dashboardLogic.tsx stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/lemon-ui/LemonMarkdown/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/components/RichContentEditor/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/components/CodeSnippet/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/taxonomy/core-filter-definitions-by-group.json stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 node_modules/monaco-editor/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/lib/components/ActivityLog/describers stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/scenes/session-recordings/player/sessionRecordingPlayerLogic.ts stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx

Largest files eagerly shipped from src/index.tsx

Size	File
126.8 KiB	`../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js`
24.6 KiB	`../node_modules/.pnpm/buffer@6.0.3/node_modules/buffer/index.js`
6.3 KiB	`../node_modules/.pnpm/react@18.3.1/node_modules/react/cjs/react.production.min.js`
4.5 KiB	`../node_modules/.pnpm/@jspm+core@2.1.0/node_modules/@jspm/core/nodelibs/browser/process.js`
3.9 KiB	`../node_modules/.pnpm/scheduler@0.23.2/node_modules/scheduler/cjs/scheduler.production.min.js`
1.4 KiB	`../node_modules/.pnpm/base64-js@1.5.1/node_modules/base64-js/index.js`
1.3 KiB	`src/index.tsx`
1.3 KiB	`src/RootErrorBoundary.tsx`
912 B	`../node_modules/.pnpm/ieee754@1.2.1/node_modules/ieee754/index.js`
854 B	`src/scenes/ChunkLoadErrorBoundary.tsx`

Largest files eagerly shipped from src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts

Size	File
306.2 KiB	`../node_modules/.pnpm/posthog-js@1.435.5_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs`
219.9 KiB	`../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js`
126.8 KiB	`../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js`
100.5 KiB	`src/lib/api.ts`
92.0 KiB	`src/products.tsx`
69.4 KiB	`src/lib/lemon-ui/icons/icons.tsx`
40.1 KiB	`src/lib/utils/eventUsageLogic.ts`
38.7 KiB	`../node_modules/.pnpm/@dnd-kit+core@6.0.8_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@dnd-kit/core/dist/core.esm.js`
33.9 KiB	`../node_modules/.pnpm/kea@4.0.0-pre.6_patch_hash=139b8d1f1304f9d9da452a9a1244c94ea679dbcb85687d8999563146879fb6f5_react@18.3.1/node_modules/kea/lib/index.cjs.js`
28.7 KiB	`src/scenes/scenes.ts`

Largest files eagerly shipped from src/scenes/AuthenticatedShell.tsx

Size	File
306.2 KiB	`../node_modules/.pnpm/posthog-js@1.435.5_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs`
279.9 KiB	`src/taxonomy/core-filter-definitions-by-group.json`
219.9 KiB	`../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js`
153.7 KiB	`../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js`
126.8 KiB	`../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js`
109.9 KiB	`../packages/quill/packages/quill/dist/index.js`
100.5 KiB	`src/lib/api.ts`
93.3 KiB	`../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js`
92.0 KiB	`src/products.tsx`
90.6 KiB	`../node_modules/.pnpm/@tiptap+core@3.20.6_@tiptap+pm@3.20.6/node_modules/@tiptap/core/dist/index.js`

Largest files eagerly shipped from src/scenes/dashboard/Dashboard.tsx

Size	File
315.5 KiB	`../node_modules/.pnpm/posthog-js@1.435.5_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/rrweb.js`
306.2 KiB	`../node_modules/.pnpm/posthog-js@1.435.5_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs`
279.9 KiB	`src/taxonomy/core-filter-definitions-by-group.json`
219.9 KiB	`../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js`
181.8 KiB	`src/queries/validators.js`
153.7 KiB	`../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js`
126.8 KiB	`../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js`
109.9 KiB	`../packages/quill/packages/quill/dist/index.js`
100.5 KiB	`src/lib/api.ts`
93.3 KiB	`../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js`

Largest files eagerly shipped from src/scenes/project-homepage/ProjectHomepage.tsx

Size	File
315.5 KiB	`../node_modules/.pnpm/posthog-js@1.435.5_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/rrweb.js`
306.2 KiB	`../node_modules/.pnpm/posthog-js@1.435.5_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs`
279.9 KiB	`src/taxonomy/core-filter-definitions-by-group.json`
219.9 KiB	`../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js`
181.8 KiB	`src/queries/validators.js`
153.7 KiB	`../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js`
126.8 KiB	`../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js`
109.9 KiB	`../packages/quill/packages/quill/dist/index.js`
100.5 KiB	`src/lib/api.ts`
93.3 KiB	`../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js`

Largest files eagerly shipped from src/scenes/activity/explore/EventsScene.tsx

Size	File
315.5 KiB	`../node_modules/.pnpm/posthog-js@1.435.5_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/rrweb.js`
306.2 KiB	`../node_modules/.pnpm/posthog-js@1.435.5_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs`
279.9 KiB	`src/taxonomy/core-filter-definitions-by-group.json`
219.9 KiB	`../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js`
181.8 KiB	`src/queries/validators.js`
153.7 KiB	`../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js`
126.8 KiB	`../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js`
109.9 KiB	`../packages/quill/packages/quill/dist/index.js`
100.5 KiB	`src/lib/api.ts`
93.3 KiB	`../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js`

Largest files eagerly shipped from src/scenes/session-recordings/detail/SessionRecordingDetail.tsx

Size	File
315.5 KiB	`../node_modules/.pnpm/posthog-js@1.435.5_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/rrweb.js`
306.2 KiB	`../node_modules/.pnpm/posthog-js@1.435.5_@types+react@18.3.27_react@18.3.1/node_modules/posthog-js/dist/module.mjs`
279.9 KiB	`src/taxonomy/core-filter-definitions-by-group.json`
219.9 KiB	`../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js`
181.8 KiB	`src/queries/validators.js`
153.7 KiB	`../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js`
126.8 KiB	`../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js`
109.9 KiB	`../packages/quill/packages/quill/dist/index.js`
100.5 KiB	`src/lib/api.ts`
93.3 KiB	`../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js`

_{Posted automatically by check-eager-graph · sizes are eager output bytes (shipped, post-tree-shake) from the esbuild metafile · part of #32479}

✅ Toolbar bundle — eager 2.19 MiB within budget

What the toolbar ships to customer pages, measured from the esbuild output (minified, post-tree-shake). The eager set is the entry plus everything statically imported from it — fetched before any feature runs; deferred chunks load lazily. The eager guardrail is 5.72 MiB. Each output file must also stay below 10 MB, where CloudFront stops compressing it. The module boundary is enforced separately by check-toolbar-graph.

Metric	Size	Δ vs base	Budget
Eager (shipped) entry + static imports	2.19 MiB · 19 files	no change	`████░░░░░░` 38.3% of 5.72 MiB
Deferred (lazy)	2.10 MiB · 44 files	no change	n/a — loads on demand
Loader `dist/toolbar.js`	1.2 KiB	no change	`█░░░░░░░░░` 6.0% of 19.5 KiB

Largest eagerly-shipped chunks

Size	File
830.5 KiB	`dist/toolbar/toolbar-app-KOLJZZVO.css`
657.2 KiB	`dist/toolbar/chunk-chunk-Z6UICKYF.js`
259.4 KiB	`dist/toolbar/chunk-chunk-VJB3SXU4.js`
138.2 KiB	`dist/toolbar/chunk-chunk-YRDJ3DU2.js`
131.8 KiB	`dist/toolbar/chunk-chunk-FDH2IBXT.js`
75.2 KiB	`dist/toolbar/toolbar-app-KU7GIXWC.js`
69.0 KiB	`dist/toolbar/chunk-chunk-TSAL54PB.js`
35.6 KiB	`dist/toolbar/chunk-chunk-O24ZCDY5.js`
21.0 KiB	`dist/toolbar/chunk-chunk-AC27PX7U.js`
6.8 KiB	`dist/toolbar/chunk-chunk-DV7IWQNF.js`

_{Posted automatically by check-toolbar-size · sizes are toolbar output bytes (shipped, post-tree-shake) from the esbuild metafile}

✅ Dist folder size — 🔺 +8.6 KiB (+0.0%)

Total size of the built frontend/dist folder (all assets), compared against the base branch.

Total: 966.10 MiB · 🔺 +8.6 KiB (+0.0%)

ℹ️ MCP UI apps size — 33 app(s), 17633.1 KB JS

Built size of each MCP UI app (main.js + styles.css).

App	JS	CSS
debug	597.9 KB	199.3 KB
action	454.1 KB	199.3 KB
action-list	564.2 KB	199.3 KB
cohort	453.1 KB	199.3 KB
cohort-list	563.2 KB	199.3 KB
email-template	452.9 KB	199.3 KB
error-details	469.6 KB	199.3 KB
error-issue	454.5 KB	199.3 KB
error-issue-list	564.8 KB	199.3 KB
experiment	561.3 KB	199.3 KB
experiment-list	564.9 KB	199.3 KB
experiment-results	566.3 KB	199.3 KB
feature-flag	566.8 KB	199.3 KB
feature-flag-list	570.5 KB	199.3 KB
feature-flag-testing	457.3 KB	199.3 KB
inline-scan	453.6 KB	199.3 KB
insight-actors	562.3 KB	199.3 KB
invite-email-preview	452.3 KB	199.3 KB
llm-costs	559.3 KB	199.3 KB
session-recording	455.3 KB	199.3 KB
survey	454.7 KB	199.3 KB
survey-global-stats	561.9 KB	199.3 KB
survey-list	564.9 KB	199.3 KB
survey-stats	561.9 KB	199.3 KB
trace-span	453.5 KB	199.3 KB
trace-span-list	564.1 KB	199.3 KB
vision-observation-list	563.3 KB	199.3 KB
workflow	453.4 KB	199.3 KB
workflow-list	563.5 KB	199.3 KB
loops-review	457.8 KB	199.3 KB
query-results	774.1 KB	199.3 KB
render-ui	858.1 KB	199.3 KB
visual-review-snapshots	457.9 KB	199.3 KB

✅ Playwright — all passed

All tests passed.

View test results →

posthog · 2026-10-01T18:22:23Z

🦔 PostHog Review reviewed this pull request

Nothing worth raising this time. Enjoy the moment:

Resolved comments: 1 fixed, 1 declined, 1 left for you

greptile-apps · 2026-10-01T18:26:07Z

[High risk] Changes event ingestion pipeline to skip writing events for flag-evaluation-only organizations.

The PR appears safe to merge, but the staff warning should accurately describe when events writes stop.

_{Reviews (1) · Last reviewed commit: "feat(flags): skip events writes for flag..."}

Copilot

Copilot review overview

🟡 Changes recommended

Experiment-reader compatibility and cache-consistent downgrades need resolution before approval.

Review effort: Balanced
Findings: 2

Open (2)

Cached mode delays cause inconsistent reader and ingestion transitions · New
Legacy exposure readers lose counts when events calls are suppressed · New

What changed in this PR

Adds ingestion support for organizations storing flag calls only in flag_evaluations, alongside the planned reader migrations.

Changes:

Suppresses events-table copies only after queuing flag-evaluation rows.
Adds a rollback switch, outcome metrics, and oversized-row warnings.
Extends tests and updates mode documentation.

File	Description
`products/feature_flags/frontend/staff/StaffFlagEvaluationsModeModal.tsx`	Updates staff warning text.
`products/feature_flags/backend/flag_evaluations_mode.py`	Updates downgrade documentation only.
`products/feature_flags/backend/facade/enums.py`	Documents ingestion behavior and rollback.
`posthog/settings/feature_flags.py`	Updates the default-mode comment only.
`nodejs/tests/ingestion/flag-evaluations-e2e.test.ts`	Tests routing, person updates, and exposure copies.
`nodejs/tests/helpers/sql.ts`	Stores test modes in organization config.
`nodejs/src/ingestion/pipelines/analytics/event-subpipeline.ts`	Updates the fork failure comment only.
`nodejs/src/ingestion/config.ts`	Adds the ingestion rollback switch.
`nodejs/src/ingestion/common/steps/event-processing/fork-flag-evaluations-step.ts`	Filters queued calls and reports outcomes.
`nodejs/src/ingestion/common/steps/event-processing/fork-flag-evaluations-step.test.ts`	Tests suppression, fallback, and warnings.
`nodejs/src/ingestion/common/steps/event-processing/create-event-step.ts`	Passes team context downstream.
`nodejs/src/ingestion/common/steps/event-processing/create-event-step.test.ts`	Adds team context to fixtures.
`nodejs/src/ingestion/common/flag-evaluations/flag-evaluations-service.ts`	Gates suppression by mode and rollback.
`nodejs/src/ingestion/common/flag-evaluations/flag-evaluations-service.test.ts`	Tests rollback configuration wiring.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

posthog · 2026-10-01T19:21:02Z

+            const eventsToEmit = input.eventsToEmit.filter((toEmit) => !mappableEvents.includes(toEmit))
+            return Promise.resolve(ok({ ...input, eventsToEmit }, [settled]))


Escalated. The gap is real, and closing it needs a design decision across the feature flags and experiments products.

For a mode-2 team, experiments that resolve to $feature_flag_called stop counting new exposures, and so do the session readers.

The PR handles this only as a rollout prerequisite, and that check runs only once. It does not cover an org created on mode 2 that starts an experiment later while experiment-exposure-event is off for it.

Options: (a) keep the process gate and make sure experiment-exposure-event is on for every mode-2 org, (b) block the mode change in code, (c) hold the merge until experiments read flag_evaluations.

Options (b) and (c) are cross-product changes that are out of scope for an unattended fix, and option (a) is a rollout policy choice. A maintainer should pick one.

coderabbitai · 2026-10-01T18:31:24Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: PostHog/posthog/.coderabbit.yaml

Review profile: QUIET

Plan: Enterprise

Run ID: 39607fa6-bb13-4edd-840b-0fe31d3d52c3

📥 Commits

Reviewing files that changed from the base of the PR and between 514a49e and 6f57663.

📒 Files selected for processing (2)

nodejs/src/ingestion/common/steps/event-processing/emit-event-step.ts
nodejs/src/ingestion/common/steps/event-processing/fork-flag-evaluations-step.ts

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 9 remain after this review.

📝 Walkthrough

Walkthrough

Ingestion now stops $feature_flag_called event writes for teams in FLAG_EVALUATIONS_ONLY mode, unless the rollback setting is enabled. Successfully queued, mappable flag-call events are removed from event output. Oversized rows in this mode produce ingestion warnings and are counted as lost. Staff tooling, tests, and mode documentation reflect the routing behavior and its effects.

Priority: ➖ Normal

Merge Risk: 🔵 Low · up to 6f576

The ingestion logic looks sound, but the staff-facing and API descriptions of mode 2 may still overstate when flag-call events stop being written to the events table. They also omit the conditions under which writes continue. Fix the wording before merge or accept it as a follow-up.

Security Architecture Review

Security architecture risk: 🟡 Moderate · up to 6f576

Eligible flag calls now depend on one destination for persistence. A permanent delivery failure can lose those calls, and restoring event writes does not recover previously missing data. Tenant routing and experiment-exposure copies are preserved, but reader migration and deployment ordering still require confirmation.

Retained concerns

Medium · reliability · observed: The sole-write path removes eligible calls from events output before broker acknowledgement. Ordinary permanent delivery rejection is then counted and swallowed, leaving no events fallback. Failure metrics expose the loss but do not recover the call, and rollback restores only subsequent event writes. Compared with the described dual-write baseline, this weakens delivery failure containment and historical recovery.

Security review details

Security Blast Radius

inferred — A shared output failure can affect flag calls from every eligible mode-2 team served by the failing ingesters, including multiple organizations when wildcard team eligibility is used. The inspected suppression remains limited to mappable flag-call objects, rather than all tenant events.

Trust Boundaries and Controls

observed — The change carries the existing team object into routing rather than introducing a separate team lookup. Mode storage remains organization-owned, and the upsert compares the stored mode at write time to preserve a concurrent higher mode unless downgrade is authorized. Upstream tenant authentication and cache propagation were not independently verified.

Resilience and Maintainability Implications

observed — Oversized sole-write rows generate a loss outcome and ingestion warning. Ordinary delivery failures generate a produce_failed outcome; the source identifies an associated alert. These are detection controls, not replay or historical-recovery mechanisms.

Hardening Proposals

proposed — For sole-write mode, consider a durable retry or replay mechanism for recoverable delivery failures, distinct from permanently oversized rows. Any recovery design should retain event identity and explicitly handle redelivery deduplication rather than simply retrying the enqueue step.

🚥 Pre-merge checks | ✅ 1

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description is complete and follows the repository template. It explains the problem, user-visible changes, rollout prerequisites, risks, testing coverage, release status, documentation decision, …

✨ Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

_{Comment @coderabbitai help to get the list of available commands.}

trunk-io · 2026-10-01T18:43:53Z

Failed Test	Failure Summary	Logs
`Scenes-App/SidePanels SidePanelNotebooks smoke-test`	The test timed out while waiting for loading indicators or spinners to disappear.	Logs ↗︎

_{View Full Report ↗︎ ⋅ Docs}

coderabbitai

Note

Quiet mode is enabled, so only the most important comments were posted inline. Other review comments are grouped below.

🟡 Other comments (2)

services/mcp/src/api/generated.ts-100005-100005 (1)

100005-100005: 🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win

Both descriptions overstate mode 2’s event-write behavior. A $feature_flag_called call is removed from events only after its flag_evaluations row is queued. Calls without a queued row still go to events.

services/mcp/src/api/generated.ts#L100005-L100005: qualify the target-mode description with the row-queued condition.

services/mcp/src/api/generated.ts#L100085-L100085: qualify the stored-mode description with the same condition.

products/feature_flags/backend/api/staff_team_config.py-114-115 (1)

114-115: 🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win

Document the rollback exception in each unconditional mode-2 description.

INGESTION_FLAG_EVALUATIONS_ONLY_DISABLED=true is passed to FlagEvaluationsService. For stored mode 2, stopsEventsWritesFor then returns false, so ingestion can keep writing $feature_flag_called events without changing the stored mode.

Update the API help text, both modal warnings, parity guidance, posthog/settings/feature_flags.py, products/feature_flags/backend/flag_evaluations_mode.py, and the affected generated MCP descriptions. State that mode-2 suppression and the events-table gap apply only when the rollback flag is false. Keep the existing management-command documentation and products/feature_flags/backend/facade/enums.py comment, which already describe the fallback. The existing Usage tab override is separate and does not document ingestion behavior.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: PostHog/posthog/.coderabbit.yaml

Review profile: QUIET

Plan: Enterprise

Run ID: 73b76ec2-91aa-4844-b419-6b3463df32c3

📥 Commits

Reviewing files that changed from the base of the PR and between ae4b274 and a31d372.

⛔ Files ignored due to path filters (2)

products/feature_flags/frontend/generated/api.schemas.ts is excluded by !**/generated/**
products/feature_flags/frontend/generated/api.zod.ts is excluded by !**/generated/**

📒 Files selected for processing (8)

nodejs/src/ingestion/common/steps/event-processing/fork-flag-evaluations-step.test.ts
nodejs/src/ingestion/config.ts
posthog/models/flag_evaluations/PARITY_CHECK.md
products/feature_flags/backend/api/staff_team_config.py
products/feature_flags/frontend/staff/StaffFlagEvaluationsModeModal.tsx
products/feature_flags/frontend/staff/featureFlagsStaffToolsLogic.test.ts
products/feature_flags/frontend/staff/featureFlagsStaffToolsLogic.ts
services/mcp/src/api/generated.ts

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 6 remain after this review.

coderabbitai

Note

Quiet mode is enabled, so only the most important comments were posted inline. Other review comments are grouped below.

🟡 Other comments (1)

products/feature_flags/frontend/staff/StaffFlagEvaluationsModeModal.tsx-23-23 (1)

23-23: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Qualify the stopped-write claims to calls with valid flag keys.

nodejs/src/ingestion/common/steps/event-processing/fork-flag-evaluations-step.ts filters only mappableEvents. Calls without a valid flag key remain in eventsToEmit and can still be written to events. State this exception in both descriptions.

Also applies to: 119-120

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: PostHog/posthog/.coderabbit.yaml

Review profile: QUIET

Plan: Enterprise

Run ID: 93aa0765-dc76-4c87-857c-fa50c8ff8388

📥 Commits

Reviewing files that changed from the base of the PR and between a31d372 and a2adfde.

📒 Files selected for processing (1)

products/feature_flags/frontend/staff/StaffFlagEvaluationsModeModal.tsx

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 4 remain after this review.

coderabbitai

Note

Quiet mode is enabled, so only the most important comments were posted inline. Other review comments are grouped below.

🟡 Other comments (3)

products/feature_flags/frontend/staff/StaffFlagEvaluationsModeModal.tsx-121-121 (1)

121-121: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Limit the “only to flag_evaluations” claim to queued rows.

The routing change keeps a $feature_flag_called in events when no flag_evaluations row is queued. The warning can therefore mislead staff about event-table coverage for allowlisted teams. Clarify that ingestion omits only calls whose rows were successfully queued.

services/mcp/src/api/generated.ts-100005-100005 (1)

100005-100005: 🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win

Qualify the mode-2 event-write behavior in both descriptions.

These descriptions imply that mode 2 always stops $feature_flag_called writes to events. Suppression applies only when the ingestion allowlist admits the team and the rollback setting is off. In addition, ingestion removes a call only after it queues the corresponding flag_evaluations row; paths that queue no row still write the call to events. State these conditions so API consumers do not treat mode 2 as a guarantee of complete event suppression.

Also applies to: 100085-100085

products/feature_flags/backend/api/staff_team_config.py-115-116 (1)

115-116: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Both descriptions overstate when mode 2 suppresses event writes. Ingestion removes a call from events only after it queues the corresponding flag_evaluations row. Calls on paths that queue no row can still be written to events. State this condition in both descriptions. The PR objective confirms this routing behavior.

products/feature_flags/backend/api/staff_team_config.py#L115-L116: Clarify that the event write stops only after the corresponding flag_evaluations row is queued.

products/feature_flags/backend/api/staff_team_config.py#L175-L176: Apply the same clarification to the mutation help text.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: PostHog/posthog/.coderabbit.yaml

Review profile: QUIET

Plan: Enterprise

Run ID: 0e3b1e6d-7290-4f9f-955e-f668edea587a

📥 Commits

Reviewing files that changed from the base of the PR and between a2adfde and 514a49e.

⛔ Files ignored due to path filters (2)

products/feature_flags/frontend/generated/api.schemas.ts is excluded by !**/generated/**
products/feature_flags/frontend/generated/api.zod.ts is excluded by !**/generated/**

📒 Files selected for processing (4)

nodejs/src/ingestion/common/steps/event-processing/fork-flag-evaluations-step.test.ts
products/feature_flags/backend/api/staff_team_config.py
products/feature_flags/frontend/staff/StaffFlagEvaluationsModeModal.tsx
services/mcp/src/api/generated.ts

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 7 remain after this review.

parameterai · 2026-10-01T22:53:17Z

Risk: Low · 1 low

The changes since the last review are documentation text only (enums.py, generated api.schemas.ts, staff modal copy), plus one behavior flip in nodejs/src/ingestion/config.ts that defaults PERSON_MERGE_TOMBSTONE_TEAM_ALLOWLIST from '' to '*'. The tombstone path is pre-existing code that scrubs person properties on delete, so the default flip introduces no new security exposure; no new findings.

_{Sentinel reviewed e231b72 · Review settings}

greptile-apps

This review was skipped because it would exceed your organization's monthly flex usage limit. Raise the limit in billing settings or wait until the next billing period resets limits.

github-actions · 2026-10-01T22:53:28Z

🦔 Hogbox preview · ✅ ready

▶ Open the preview


🔑 Login	`test@posthog.com` / `12345678` (demo data)
🧩 Running	this PR's backend and frontend, on the PostHog `:master` base
🔗 Link	stable across rebuilds — a re-push swaps the box underneath, the URL stays
🔒 Access	tailnet only (PostHog VPN)
🛠️ Admin	inspect & debug state in hogland
💤 Idle	sleeps after ~30 min idle (snapshot to S3, zero node cost) and wakes on your next visit in ~30s, behind a brief "waking up" screen

_{commit e231b72 · box box-81c26b015a85 · ready in 694s (push → usable) · build log · rebuilds on every push, torn down on close}

parameterai · 2026-10-01T23:23:04Z

+    )
+    count = 0
+    for experiment in experiments:
+        exposure_event, _ = get_exposure_event_and_property(


A crafted experiment exposure_criteria value crashes the staff flag-evaluations-mode tool with a 500

The new count loop runs strict pydantic parsing on each stored exposure_criteria with no exception handling, so one experiment row whose criteria hold a value the write path does not validate makes the whole staff mode-change preview/apply request fail.

How:

An org member creates or edits an experiment with exposure_criteria = {"multiple_variant_handling": "nonsense", "filterTestAccounts": true}.

The write validator (products/experiments/backend/experiment_service.py:669-722) only checks unknown keys, filterTestAccounts, and the exposure_config/activation_config shapes — it never value-checks other known fields, so the row is stored.

count_running_experiments_on_feature_flag_called calls get_exposure_event_and_property, whose normalize_to_exposure_criteria (exposure_query_logic.py:155) runs ExperimentExposureCriteria.model_validate on it, which raises a ValidationError on the invalid enum value.

The exception escapes set_organization_flag_evaluations_mode (flag_evaluations_mode.py:115), so the staff endpoint returns 500 for that organization, and a bulk set_flag_evaluations_mode run aborts.

Fix: Wrap the per-experiment resolution in a try/except and treat an unparseable row conservatively (count it and log), so one bad row cannot block the mode change.

_{React with 👍 if useful or 👎 if not}

stamphog

Not approved yet — waiting on the conditions below.

Re-add the stamphog label to request another review once you have addressed this.

stamphog did not approve this pull request because the prerequisites gate failed: the branch has merge conflicts. The deny-list, size and tier gates all passed, so the conflicts are the only thing blocking it here. To move forward, the author should resolve the merge conflicts and push the update. Because the change touches ingestion, staff tooling and experiments across 28 files, it should then go to a human reviewer.

👍 on the PR from greptile-apps[bot].

Gate mechanics and policy version

Gate		Result
prerequisites	✗	merge conflicts present
deny-list	✓	no deny categories matched
size	✓	272L, 15F substantive, 698L/28F incl. docs/generated/snapshots — within ceiling
tier	✓	T1-agent / T1d-complex (698L, 28F, cross-cutting, feat)
stamphog 2.3.1		`.stamphog/policy.yml` @ `unknown` · reviewed head `e00622c`

For organizations on FLAG_EVALUATIONS_ONLY, the fork step removes each $feature_flag_called event it queued for flag_evaluations from eventsToEmit. The $experiment_exposure copy and any call the fork did not queue still reach events. INGESTION_FLAG_EVALUATIONS_ONLY_DISABLED keeps the events writes for every team on that mode. Claude-Session: https://claude.ai/code/session_012LLLo3Hxxc1Vhne69sC9Hi

Claude-Session: https://claude.ai/code/session_012LLLo3Hxxc1Vhne69sC9Hi

The staff mode modal said ingestion stops the events writes for every team in a FLAG_EVALUATIONS_ONLY organization. Teams outside the ingestion allowlist keep those writes, and so does every team while INGESTION_FLAG_EVALUATIONS_ONLY_DISABLED is on. The mode description and both warnings now say so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Generated-By: PostHog Desktop Task-Id: 4950f313-3930-4d55-a98c-4b8204bf8d1e

Claude-Session: https://claude.ai/code/session_012LLLo3Hxxc1Vhne69sC9Hi

The staff mode preview and the set_flag_evaluations_mode command count each organization's running experiments that started before the experiment exposure cutoff. Those experiments count exposures on $feature_flag_called in events, so moving the organization to FLAG_EVALUATIONS_ONLY stops them. Claude-Session: https://claude.ai/code/session_012LLLo3Hxxc1Vhne69sC9Hi

The mode 2 warning counts running experiments whose exposure event resolves to $feature_flag_called, using the exposure query's own rule, and shows the count per organization in the staff modal and the command output. Claude-Session: https://claude.ai/code/session_012LLLo3Hxxc1Vhne69sC9Hi

Claude-Session: https://claude.ai/code/session_01QBXD1KJRPTTFPmz5ybA5bd

stamphog

Approved.

This touches the ingestion path, but the author has strong familiarity and is on the feature-flags team. Nothing changes until an org is moved to the mode, and an env kill switch restores the events writes. The experiment-exposure concern was handled with staff preview and command warnings plus a stated rollout prerequisite, and the remaining open thread is a low-severity crash in a staff-only tool.

Author wrote 79% of the modified lines and has 53 merged PRs in these paths (familiarity STRONG).
👍 on the PR from greptile-apps[bot].
Unresolved Copilot thread: experiments started before the exposure cutoff still read $feature_flag_called from events. The PR only warns staff and gates the rollout; it does not block the mode change in code.
Unresolved Parameter note: count_running_experiments_on_feature_flag_called has no exception handling, so one experiment row with unparseable exposure_criteria would 500 the staff mode tool. Only staff tooling calls it. Consider wrapping it in try/except and counting the row conservatively.
For FLAG_EVALUATIONS_ONLY teams, a flag_evaluations produce that fails after the step returns loses the call. The PR documents this and counts it in produce_failed, with an alert behind it.

Gate mechanics and policy version

Gate		Result
prerequisites	✓	all clear
deny-list	✓	no deny categories matched
size	✓	269L, 15F substantive, 695L/28F incl. docs/generated/snapshots — within ceiling
tier	✓	T1-agent / T1d-complex (695L, 28F, cross-cutting, feat)
stamphog 2.3.1		`.stamphog/policy.yml` @ `e231b72` · reviewed head `e231b72`

deployment-status-posthog · 2026-10-02T02:15:41Z

Deploy status

Environment	Status	Deployed At	Workflow
dev	✅ Deployed	2026-10-02 02:15 UTC	Run
prod-us	✅ Deployed	2026-10-02 02:25 UTC	Run
prod-eu	✅ Deployed	2026-10-02 02:24 UTC	Run

haacked self-assigned this Oct 1, 2026

haacked requested a balanced review from Copilot October 1, 2026 18:22

haacked added the reviewhog label Oct 1, 2026

github-actions Bot added feature/feature-flags Feature Tag: Feature flags team/feature-flags labels Oct 1, 2026

github-project-automation Bot added this to Feature Flags Oct 1, 2026

Copilot started reviewing on behalf of haacked October 1, 2026 18:22

View session

greptile-apps Bot reviewed Oct 1, 2026

View reviewed changes

Comment thread products/feature_flags/frontend/staff/StaffFlagEvaluationsModeModal.tsx Resolved

Copilot AI reviewed Oct 1, 2026

View reviewed changes

coderabbitai Bot reviewed Oct 1, 2026

View reviewed changes

posthog Bot removed the reviewhog label Oct 1, 2026

coderabbitai Bot reviewed Oct 1, 2026

View reviewed changes

haacked marked this pull request as ready for review October 1, 2026 22:53

greptile-apps Bot reviewed Oct 1, 2026

View reviewed changes

github-actions Bot requested a deployment to preview-pr-110254 October 1, 2026 22:53 In progress

pr-assigner-resolver-posthog Bot requested review from a team October 1, 2026 22:53

posthog-project-board-bot Bot moved this to In Review in Feature Flags Oct 1, 2026

github-actions Bot deployed to preview-pr-110254 October 1, 2026 23:01

View deployment

github-actions Bot deployed to preview-pr-110254 October 1, 2026 23:19

View deployment

parameterai Bot reviewed Oct 1, 2026

View reviewed changes

haacked added the stamphog Request AI approval (no full review) label Oct 2, 2026

stamphog Bot reviewed Oct 2, 2026

View reviewed changes

stamphog Bot removed the stamphog Request AI approval (no full review) label Oct 2, 2026

haacked and others added 9 commits October 1, 2026 17:31

fix(flags): update mode 2 text and warn when lowering from it

1ba68cf

Claude-Session: https://claude.ai/code/session_012LLLo3Hxxc1Vhne69sC9Hi

fix(flags): limit the mode 2 help text to teams ingestion forks

c25853c

Claude-Session: https://claude.ai/code/session_012LLLo3Hxxc1Vhne69sC9Hi

fix(flags): show the lowering gap warning only in the preview

2a8cbcc

Claude-Session: https://claude.ai/code/session_012LLLo3Hxxc1Vhne69sC9Hi

refactor(flags): share the oversize event ingestion warning

efdedb2

Claude-Session: https://claude.ai/code/session_012LLLo3Hxxc1Vhne69sC9Hi

chore(flags): point the fork ack handler at the charts alerts

e231b72

Claude-Session: https://claude.ai/code/session_01QBXD1KJRPTTFPmz5ybA5bd

haacked force-pushed the haacked/flag-evaluations-only-ingestion branch from e00622c to e231b72 Compare October 2, 2026 00:35

github-actions Bot deployed to preview-pr-110254 October 2, 2026 00:35

View deployment

haacked added the stamphog Request AI approval (no full review) label Oct 2, 2026

stamphog Bot approved these changes Oct 2, 2026

View reviewed changes

trunk-io Bot merged commit 6b2869b into master Oct 2, 2026

trunk-io Bot deleted the haacked/flag-evaluations-only-ingestion branch October 2, 2026 01:57

This was referenced Oct 2, 2026

fix(flags): name the readers mode 2 moves to flag_evaluations #111090

Merged

Sprint - October 5 to October 16 #108337

Closed

		const eventsToEmit = input.eventsToEmit.filter((toEmit) => !mappableEvents.includes(toEmit))
		return Promise.resolve(ok({ ...input, eventsToEmit }, [settled]))

Conversation

haacked commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Changes

Rollout prerequisites

How did you test this code?

Release status

Automatic notifications

Docs update

🤖 Agent context

Uh oh!

trunk-io Bot commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 CI report

Uh oh!

posthog Bot commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦔 PostHog Review reviewed this pull request

Uh oh!

greptile-apps Bot commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

posthog Bot Oct 1, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Security Architecture Review

Uh oh!

trunk-io Bot commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

parameterai Bot commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦔 Hogbox preview · ✅ ready

▶ Open the preview

Uh oh!

parameterai Bot Oct 1, 2026

Choose a reason for hiding this comment

Uh oh!

stamphog Bot left a comment

Choose a reason for hiding this comment

Uh oh!

stamphog Bot left a comment

Choose a reason for hiding this comment

Uh oh!

deployment-status-posthog Bot commented Oct 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploy status

Uh oh!

This branch was successfully deployed

Reviewers

haacked commented Oct 1, 2026 •

edited

Loading

trunk-io Bot commented Oct 1, 2026 •

edited

Loading

github-actions Bot commented Oct 1, 2026 •

edited

Loading

posthog Bot commented Oct 1, 2026 •

edited

Loading

greptile-apps Bot commented Oct 1, 2026 •

edited

Loading

coderabbitai Bot commented Oct 1, 2026 •

edited

Loading

trunk-io Bot commented Oct 1, 2026 •

edited

Loading

parameterai Bot commented Oct 1, 2026 •

edited

Loading

github-actions Bot commented Oct 1, 2026 •

edited

Loading

deployment-status-posthog Bot commented Oct 2, 2026 •

edited

Loading