Repository navigation
fix(eng-analytics): bound DORA coverage by window end - #103877
trunk-io[bot] merged 1 commit into
Conversation
🤖 CI report
|
| File | Patch | Uncovered changed lines |
|---|---|---|
products/engineering_analytics/backend/logic/queries/_curated.py |
92.9% | 518 |
🤖 Agents: add a test covering the lines above, or note why under "How did you test this code?". Machine-readable gap list: the patch-coverage artifact on this run (gh run download 35651400882 -n patch-coverage), or the coverage-data block at the end of this comment.
Per-product line coverage (touched products)
| Product | Coverage | Lines |
|---|---|---|
engineering_analytics |
██████████████████░░ 91.2% |
9,935 / 10,891 |
Report-only. Patch coverage = changed backend lines covered vs origin/master. Sorted lowest first.
Known gaps: lines covered only by Temporal tests show as uncovered; core line numbers may drift if master changed the same file.
|
The PR appears safe to merge with no outstanding correctness or rule-compliance issues. Reviews (2) · Last reviewed commit: "fix(eng-analytics): bound DORA coverage" |
|
Understand this PR’s impact Explore downstream dependencies and potential security impact with Blast Radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: PostHog/posthog/.coderabbit.yaml Review profile: QUIET Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review. 📝 WalkthroughWalkthroughDORA lead-time attribution now counts only deployments within the reporting window. The merged-PR denominator still includes all PRs merged during that window. The test fixture adds a successful deployment after the window, links it to PR 4, and verifies that PR 4 remains unattributed while the latest deployment status advances to January 21. Priority: ⬇️ Low Severity of issue fixed: Low 🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
0d349c6 to
ce19e4c
Compare
There was a problem hiding this comment.
Approved.
Contained fix to an internal analytics query with matching test updates, author is on the owning team, and an automated reviewer found no issues; no risky territory (auth/billing/migrations/API) involved.
- Author wrote 14% of the modified lines and has 59 merged PRs in these paths (familiarity MODERATE).
- 👍 on the PR from greptile-apps[bot].
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 8L, 1F substantive, 29L/2F incl. docs/generated/snapshots — within ceiling |
| tier | ✓ | T1-agent / T1b-small (29L, 2F, single-area, fix) |
| stamphog 2.0.0 | .stamphog/policy.yml @ ce19e4c · reviewed head ce19e4c |
ce19e4c to
36f1cbf
Compare
|
😎 Stack merged successfully - details. |
Problem
Changes
How did you test this code?
PostHog coding conventions.
Automatic notifications
Docs update
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Agent: Codex, GPT-5; GPT-6 audit and fixes.
/writing-tests,/writing-code-comments,/simplify,/writing-pr-descriptions,/stacking-prs,/code-review,/qa-team.