New feature: enable rustls-no-provider - #201
Conversation
|
thanks @yawn will take a look at it |
|
we're planning the v1 major release with a few breaking changes, and since this has a breaking change if |
| cache-key: tls-no-provider | ||
| command: >- | ||
| cargo build --verbose --no-default-features --features async-client,error-tracking,capture-v1,tls-no-provider | ||
| && ! cargo tree --package posthog-rs --edges normal --invert aws-lc-sys --no-default-features --features async-client,error-tracking,capture-v1,tls-no-provider |
There was a problem hiding this comment.
blocking: Make the dependency-tree assertion fail closed\n\nNegating cargo tree makes any failure—including registry, dependency-resolution, or argument errors—look like proof that aws-lc-sys is absent, so this regression guard can pass silently. Please run cargo tree as a separately checked command, then inspect its successful output for aws-lc-sys.
| - name: E2E test | ||
| cache-key: e2e | ||
| command: cargo test --verbose --features e2e-test --no-default-features | ||
| command: cargo test --verbose --features e2e-test,tls --no-default-features |
There was a problem hiding this comment.
suggestion: Update the documented E2E command\n\nCI now enables tls for E2E tests, but CONTRIBUTING.md still documents --features e2e-test --no-default-features. That leaves manual E2E runs without an HTTPS backend, so captures can fail while the test appears successful. Please update the documented command to include tls.
|
also:
you have to sign the commits |
|
moving to draft until we figure this out |
Oh, was that in the PR template? Sorry, must have overlooked it ... |
I'd argue that this could still be a minor semver bump. It's not a breaking API change, it's just a non-breaking change (a simple remediation exists without functional implications) for a specific subset of users. |
💡 Motivation and Context
This avoids automatically pulling in
aws-lc-rswhich is quite heavyweight, requires a C toolchain etc.Note that this change is breaking for everybody who uses this crate with
default-features = false. Everybody else is unaffected.💚 How did you test it?
Added an integration test and optionally (extra commit, feel free to drop it) a build/ci test.
📝 Checklist
If releasing new changes
sampo addto generate a changeset file