refactor(openai): share resource and embedding policy - #889
Merged
Conversation
# Conflicts: # posthog/ai/openai/openai.py # posthog/ai/openai/openai_async.py
Contributor
posthog-python Compliance ReportDate: 2026-08-25 07:52:53 UTC ✅ All Tests Passed!111/111 tests passed Capture_V1 Tests✅ 94/94 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
Member
Author
|
This PR is part of a trial using Slopo to identify high-value code duplication for targeted refactoring. |
Contributor
|
Reviews (1): Last reviewed commit: "fix(openai): preserve wrapper public API" | Re-trigger Greptile |
turnipdabeets
approved these changes
Aug 24, 2026
…rce-embedding-policy # Conflicts: # posthog/ai/openai/openai.py # posthog/ai/openai/openai_async.py # posthog/test/ai/openai/test_async_parity.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
The sync, async, and Azure OpenAI clients repeated the same resource discovery and replacement logic. Sync and async embedding wrappers also built the same telemetry properties separately. These copies could drift when OpenAI adds resources or embedding telemetry changes.
This refactor shares resource installation through explicit wrapper maps and uses a private helper for common embedding event construction. Provider dispatch and sync or async API calls remain in their existing adapters.
💚 How did you test it?
uv run pytest --verbose --timeout=30 posthog/test/ai/openai: 79 passed, 1 skippedmake public_api_checkorigin/main: clean📝 Checklist
If releasing new changes
sampo addto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Pi and Slopo identified the duplicated OpenAI resource and embedding paths. The resource-wrapping test now consumes the production wrapper maps so it detects mapping drift. Static type-only assignments remain because the enforced public API snapshot records those dynamically installed class attributes.