Skip to content

refactor(openai): share resource and embedding policy - #889

Merged
marandaneto merged 7 commits into
mainfrom
refactor/openai-resource-embedding-policy
Aug 25, 2026
Merged

refactor(openai): share resource and embedding policy#889
marandaneto merged 7 commits into
mainfrom
refactor/openai-resource-embedding-policy

Conversation

@marandaneto

@marandaneto marandaneto commented Aug 22, 2026

Copy link
Copy Markdown
Member

💡 Motivation and Context

The sync, async, and Azure OpenAI clients repeated the same resource discovery and replacement logic. Sync and async embedding wrappers also built the same telemetry properties separately. These copies could drift when OpenAI adds resources or embedding telemetry changes.

This refactor shares resource installation through explicit wrapper maps and uses a private helper for common embedding event construction. Provider dispatch and sync or async API calls remain in their existing adapters.

💚 How did you test it?

  • uv run pytest --verbose --timeout=30 posthog/test/ai/openai: 79 passed, 1 skipped
  • make public_api_check
  • Ruff formatting and lint checks on changed files
  • Autoreview against origin/main: clean

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

If releasing new changes

  • Ran sampo add to generate a changeset file

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

Pi and Slopo identified the duplicated OpenAI resource and embedding paths. The resource-wrapping test now consumes the production wrapper maps so it detects mapping drift. Static type-only assignments remain because the enforced public API snapshot records those dynamically installed class attributes.

@marandaneto marandaneto self-assigned this Aug 22, 2026
@github-actions

github-actions Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

posthog-python Compliance Report

Date: 2026-08-25 07:52:53 UTC
Duration: 255913ms

✅ All Tests Passed!

111/111 tests passed


Capture_V1 Tests

94/94 tests passed

View Details
Test Status Duration
Endpoint And Method.Targets V1 Endpoint 513ms
Endpoint And Method.Does Not Use Legacy Endpoints 507ms
Required Headers.Has Authorization Bearer Header 507ms
Required Headers.Has Content Type Json 507ms
Required Headers.Has Posthog Sdk Info Format 508ms
Required Headers.Has Posthog Attempt Header 507ms
Required Headers.Has Posthog Request Id 509ms
Required Headers.Has Posthog Request Timestamp 508ms
Required Headers.Has User Agent 508ms
Body Format.Body Has Created At And Batch 507ms
Body Format.No Api Key In Body 508ms
Body Format.No Sent At In Body 508ms
Event Format.Event Has Required Root Fields 508ms
Event Format.Event Uuid Is Valid 509ms
Event Format.Event Timestamp Is Rfc3339 508ms
Event Format.Distinct Id Is String 507ms
Event Format.Distinct Id At Root Not Properties 508ms
Event Format.Custom Properties Preserved 508ms
Event Format.Set Properties Preserved 507ms
Event Format.Set Once Properties Preserved 508ms
Event Format.Groups Properties Preserved 508ms
Event Format.Sdk Generates Uuid If Not Provided 507ms
Event Format.Event Has Required Root Fields Batch 510ms
Event Format.Event Uuid Is Valid Batch 510ms
Event Format.Event Timestamp Is Rfc3339 Batch 510ms
Event Format.Distinct Id Is String Batch 510ms
Event Format.Distinct Id At Root Not Properties Batch 509ms
Event Format.Custom Properties Preserved Batch 510ms
Event Format.Set Properties Preserved Batch 510ms
Event Format.Set Once Properties Preserved Batch 510ms
Event Format.Groups Properties Preserved Batch 510ms
Event Format.Sdk Generates Uuid If Not Provided Batch 510ms
Batch Behavior.Multiple Events In Single Batch 513ms
Batch Behavior.Batch Envelope Smoke 510ms
Batch Behavior.Flush With No Events Sends Nothing 505ms
Batch Behavior.Flush At Triggers Batch 1010ms
Batch Behavior.Created At Reflects Batch Creation Time 508ms
Deduplication.Generates Unique Uuids 512ms
Deduplication.Different Events Same Content Different Uuids 509ms
Deduplication.Preserves Uuid On Retry 6513ms
Deduplication.Preserves Timestamp On Retry 6517ms
Deduplication.Preserves Uuid And Timestamp On Batch Retry 6519ms
Deduplication.No Duplicate Events In Batch 513ms
Header Behavior On Retry.Attempt Header Starts At One 508ms
Header Behavior On Retry.Attempt Header Increments On Retry 13520ms
Header Behavior On Retry.Request Id Preserved On Retry 6514ms
Header Behavior On Retry.Different Requests Have Different Request Ids 3015ms
Header Behavior On Retry.Request Timestamp Changes On Retry 6517ms
Response Format Validation.Success Response Has Uuid Keyed Results 508ms
Response Format Validation.Success Response Has Ok For Each Event 510ms
Response Format Validation.Success No Retry After When All Ok 510ms
Response Format Validation.Success Retry After Present When Retry Events 1512ms
Response Format Validation.Success No Retry After When Drop Only 509ms
Response Format Validation.Response Echoes Request Id 508ms
Retry Behavior.Retries On 408 6513ms
Retry Behavior.Retries On 500 6513ms
Retry Behavior.Retries On 503 8519ms
Retry Behavior.Retries On 504 6516ms
Retry Behavior.Retryable Errors Have Retry After 3514ms
Retry Behavior.Respects Retry After On Retryable Error 11519ms
Retry Behavior.Does Not Retry On 400 2511ms
Retry Behavior.Does Not Retry On 401 2511ms
Retry Behavior.Does Not Retry On 402 2511ms
Retry Behavior.Does Not Retry On 413 2511ms
Retry Behavior.Does Not Retry On 415 2511ms
Retry Behavior.Non Retryable Errors Have No Retry After 2510ms
Retry Behavior.Implements Backoff 22532ms
Retry Behavior.Max Retries Respected 22530ms
Partial Batch Handling.Handles 200 Full Success 2510ms
Partial Batch Handling.Handles 200 With All Ok 3513ms
Partial Batch Handling.Does Not Retry Dropped Events 3513ms
Partial Batch Handling.Does Not Retry Limited Events 3512ms
Partial Batch Handling.Prunes Ok Events On Partial Retry 6518ms
Partial Batch Handling.Prunes Dropped Events On Partial Retry 6514ms
Partial Batch Handling.Retries Only Retry Events From Partial 6519ms
Partial Batch Handling.Partial Retry Preserves Uuids 6515ms
Partial Batch Handling.Partial Retry Attempt Header Increments 6518ms
Partial Batch Handling.Partial Retry Request Id Preserved 6514ms
Partial Batch Handling.Respects Retry After On Partial 8515ms
Partial Batch Handling.Unknown Result Treated As Terminal 3512ms
Partial Batch Handling.Mixed Ok Drop Limited No Retry 3515ms
Compression.Sends Gzip Content Encoding 508ms
Compression.No Content Encoding When Disabled 508ms
Compression.Compressed Body Is Decompressible 507ms
Error Handling.Does Not Retry On Unknown 4Xx 2510ms
Event Options.Cookieless Mode Override 509ms
Event Options.Disable Skew Correction Override 508ms
Event Options.Process Person Profile Override 508ms
Event Options.Product Tour Id Override 507ms
Event Options.Unset Options Omitted 508ms
Event Options.Options Override In Batch 510ms
Geoip And Historical Migration.Geoip Disable Injected Into Properties 508ms
Geoip And Historical Migration.Historical Migration Set In Body 508ms
Geoip And Historical Migration.Historical Migration Absent By Default 508ms

Feature_Flags Tests

17/17 tests passed

View Details
Test Status Duration
Request Payload.Request With Person Properties Device Id 8ms
Request Payload.Flags Request Uses V2 Query Param 6ms
Request Payload.Flags Request Hits Flags Path Not Decide 6ms
Request Payload.Flags Request Omits Authorization Header 6ms
Request Payload.Token In Flags Body Matches Init 7ms
Request Payload.Groups Round Trip 6ms
Request Payload.Groups Default To Empty Object 5ms
Request Payload.Disable Geoip False Propagates As Geoip Disable False 6ms
Request Payload.Disable Geoip Omitted Defaults To False 6ms
Request Payload.Flag Keys To Evaluate Contains Only Requested Key 6ms
Request Lifecycle.No Flags Request On Init Alone 3ms
Request Lifecycle.No Flags Request On Normal Capture 506ms
Request Lifecycle.Two Flag Calls Produce Two Remote Requests 10ms
Request Lifecycle.Mock Response Value Is Returned To Caller 6ms
Retry Behavior.Retries Flags On 502 309ms
Retry Behavior.Retries Flags On 504 310ms
Side Effect Events.Get Feature Flag Captures Feature Flag Called Event 508ms

@marandaneto

Copy link
Copy Markdown
Member Author

This PR is part of a trial using Slopo to identify high-value code duplication for targeted refactoring.

@marandaneto
marandaneto marked this pull request as ready for review August 22, 2026 07:29
@marandaneto
marandaneto requested a review from a team as a code owner August 22, 2026 07:29
@marandaneto
marandaneto requested a review from a team August 22, 2026 07:31
@greptile-apps

greptile-apps Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "fix(openai): preserve wrapper public API" | Re-trigger Greptile

Comment thread posthog/test/ai/openai/test_resource_wrapping.py Outdated
Comment thread posthog/ai/openai/openai.py Outdated
Base automatically changed from refactor/openai-stream-state to main August 25, 2026 07:06
…rce-embedding-policy

# Conflicts:
#	posthog/ai/openai/openai.py
#	posthog/ai/openai/openai_async.py
#	posthog/test/ai/openai/test_async_parity.py
@marandaneto
marandaneto merged commit 02fd926 into main Aug 25, 2026
42 checks passed
@marandaneto
marandaneto deleted the refactor/openai-resource-embedding-policy branch August 25, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants