Skip to content

refactor(ai): share processor privacy and capture policy - #884

Merged
marandaneto merged 4 commits into
mainfrom
refactor/ai-processor-policy
Aug 25, 2026
Merged

refactor(ai): share processor privacy and capture policy#884
marandaneto merged 4 commits into
mainfrom
refactor/ai-processor-policy

Conversation

@marandaneto

@marandaneto marandaneto commented Aug 21, 2026

Copy link
Copy Markdown
Member

💡 Motivation and Context

The Claude Agent SDK and OpenAI Agents processors duplicated privacy redaction and event capture policy. Privacy handling is security-sensitive, and changes could drift between processors.

This change shares privacy handling for duck-typed clients. It also centralizes common property merging, capture capability checks, identity fallback, event submission, and error handling while preserving existing behavior. In particular, a per-call privacy setting can enable redaction but cannot disable processor-level or client-level privacy.

💚 How did you test it?

  • uv run pytest --verbose --timeout=30 posthog/test/ai/claude_agent_sdk posthog/test/ai/openai_agents: 99 passed
  • make public_api_check
  • Ruff formatting and lint checks on changed files
  • Autoreview against origin/main: clean

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

If releasing new changes

  • Ran sampo add to generate a changeset file

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

Pi and Slopo identified the shared privacy and capture policy. The implementation keeps Claude per-call privacy and groups handling separate where they differ. Review feedback identified an unintended privacy-precedence change, which was corrected with regression coverage before the branch was updated.

@marandaneto marandaneto self-assigned this Aug 21, 2026
@github-actions

github-actions Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

posthog-python Compliance Report

Date: 2026-08-25 07:33:03 UTC
Duration: 256050ms

✅ All Tests Passed!

111/111 tests passed


Capture_V1 Tests

94/94 tests passed

View Details
Test Status Duration
Endpoint And Method.Targets V1 Endpoint 513ms
Endpoint And Method.Does Not Use Legacy Endpoints 509ms
Required Headers.Has Authorization Bearer Header 509ms
Required Headers.Has Content Type Json 508ms
Required Headers.Has Posthog Sdk Info Format 509ms
Required Headers.Has Posthog Attempt Header 508ms
Required Headers.Has Posthog Request Id 508ms
Required Headers.Has Posthog Request Timestamp 508ms
Required Headers.Has User Agent 508ms
Body Format.Body Has Created At And Batch 509ms
Body Format.No Api Key In Body 508ms
Body Format.No Sent At In Body 508ms
Event Format.Event Has Required Root Fields 509ms
Event Format.Event Uuid Is Valid 508ms
Event Format.Event Timestamp Is Rfc3339 509ms
Event Format.Distinct Id Is String 507ms
Event Format.Distinct Id At Root Not Properties 509ms
Event Format.Custom Properties Preserved 508ms
Event Format.Set Properties Preserved 508ms
Event Format.Set Once Properties Preserved 508ms
Event Format.Groups Properties Preserved 508ms
Event Format.Sdk Generates Uuid If Not Provided 508ms
Event Format.Event Has Required Root Fields Batch 511ms
Event Format.Event Uuid Is Valid Batch 511ms
Event Format.Event Timestamp Is Rfc3339 Batch 511ms
Event Format.Distinct Id Is String Batch 511ms
Event Format.Distinct Id At Root Not Properties Batch 511ms
Event Format.Custom Properties Preserved Batch 511ms
Event Format.Set Properties Preserved Batch 511ms
Event Format.Set Once Properties Preserved Batch 510ms
Event Format.Groups Properties Preserved Batch 511ms
Event Format.Sdk Generates Uuid If Not Provided Batch 511ms
Batch Behavior.Multiple Events In Single Batch 513ms
Batch Behavior.Batch Envelope Smoke 512ms
Batch Behavior.Flush With No Events Sends Nothing 506ms
Batch Behavior.Flush At Triggers Batch 1009ms
Batch Behavior.Created At Reflects Batch Creation Time 508ms
Deduplication.Generates Unique Uuids 514ms
Deduplication.Different Events Same Content Different Uuids 510ms
Deduplication.Preserves Uuid On Retry 6517ms
Deduplication.Preserves Timestamp On Retry 6513ms
Deduplication.Preserves Uuid And Timestamp On Batch Retry 6516ms
Deduplication.No Duplicate Events In Batch 514ms
Header Behavior On Retry.Attempt Header Starts At One 508ms
Header Behavior On Retry.Attempt Header Increments On Retry 13520ms
Header Behavior On Retry.Request Id Preserved On Retry 6517ms
Header Behavior On Retry.Different Requests Have Different Request Ids 3016ms
Header Behavior On Retry.Request Timestamp Changes On Retry 6517ms
Response Format Validation.Success Response Has Uuid Keyed Results 508ms
Response Format Validation.Success Response Has Ok For Each Event 512ms
Response Format Validation.Success No Retry After When All Ok 510ms
Response Format Validation.Success Retry After Present When Retry Events 1513ms
Response Format Validation.Success No Retry After When Drop Only 510ms
Response Format Validation.Response Echoes Request Id 508ms
Retry Behavior.Retries On 408 6517ms
Retry Behavior.Retries On 500 6517ms
Retry Behavior.Retries On 503 8516ms
Retry Behavior.Retries On 504 6517ms
Retry Behavior.Retryable Errors Have Retry After 3514ms
Retry Behavior.Respects Retry After On Retryable Error 11521ms
Retry Behavior.Does Not Retry On 400 2511ms
Retry Behavior.Does Not Retry On 401 2511ms
Retry Behavior.Does Not Retry On 402 2511ms
Retry Behavior.Does Not Retry On 413 2511ms
Retry Behavior.Does Not Retry On 415 2511ms
Retry Behavior.Non Retryable Errors Have No Retry After 2511ms
Retry Behavior.Implements Backoff 22527ms
Retry Behavior.Max Retries Respected 22533ms
Partial Batch Handling.Handles 200 Full Success 2511ms
Partial Batch Handling.Handles 200 With All Ok 3512ms
Partial Batch Handling.Does Not Retry Dropped Events 3511ms
Partial Batch Handling.Does Not Retry Limited Events 3514ms
Partial Batch Handling.Prunes Ok Events On Partial Retry 6517ms
Partial Batch Handling.Prunes Dropped Events On Partial Retry 6517ms
Partial Batch Handling.Retries Only Retry Events From Partial 6521ms
Partial Batch Handling.Partial Retry Preserves Uuids 6519ms
Partial Batch Handling.Partial Retry Attempt Header Increments 6518ms
Partial Batch Handling.Partial Retry Request Id Preserved 6519ms
Partial Batch Handling.Respects Retry After On Partial 8518ms
Partial Batch Handling.Unknown Result Treated As Terminal 3513ms
Partial Batch Handling.Mixed Ok Drop Limited No Retry 3517ms
Compression.Sends Gzip Content Encoding 509ms
Compression.No Content Encoding When Disabled 508ms
Compression.Compressed Body Is Decompressible 509ms
Error Handling.Does Not Retry On Unknown 4Xx 2511ms
Event Options.Cookieless Mode Override 509ms
Event Options.Disable Skew Correction Override 508ms
Event Options.Process Person Profile Override 509ms
Event Options.Product Tour Id Override 508ms
Event Options.Unset Options Omitted 508ms
Event Options.Options Override In Batch 511ms
Geoip And Historical Migration.Geoip Disable Injected Into Properties 508ms
Geoip And Historical Migration.Historical Migration Set In Body 509ms
Geoip And Historical Migration.Historical Migration Absent By Default 508ms

Feature_Flags Tests

17/17 tests passed

View Details
Test Status Duration
Request Payload.Request With Person Properties Device Id 9ms
Request Payload.Flags Request Uses V2 Query Param 7ms
Request Payload.Flags Request Hits Flags Path Not Decide 7ms
Request Payload.Flags Request Omits Authorization Header 8ms
Request Payload.Token In Flags Body Matches Init 7ms
Request Payload.Groups Round Trip 7ms
Request Payload.Groups Default To Empty Object 7ms
Request Payload.Disable Geoip False Propagates As Geoip Disable False 7ms
Request Payload.Disable Geoip Omitted Defaults To False 7ms
Request Payload.Flag Keys To Evaluate Contains Only Requested Key 7ms
Request Lifecycle.No Flags Request On Init Alone 3ms
Request Lifecycle.No Flags Request On Normal Capture 507ms
Request Lifecycle.Two Flag Calls Produce Two Remote Requests 11ms
Request Lifecycle.Mock Response Value Is Returned To Caller 8ms
Retry Behavior.Retries Flags On 502 310ms
Retry Behavior.Retries Flags On 504 311ms
Side Effect Events.Get Feature Flag Captures Feature Flag Called Event 510ms

@marandaneto
marandaneto marked this pull request as ready for review August 22, 2026 06:51
@marandaneto
marandaneto requested a review from a team as a code owner August 22, 2026 06:51
@greptile-apps

greptile-apps Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "refactor(ai): share processor capture po..." | Re-trigger Greptile

@marandaneto
marandaneto marked this pull request as draft August 22, 2026 07:11
@marandaneto

Copy link
Copy Markdown
Member Author

This PR is part of a trial using Slopo to identify high-value code duplication for targeted refactoring.

@marandaneto
marandaneto marked this pull request as ready for review August 22, 2026 07:29
@marandaneto
marandaneto requested a review from a team August 22, 2026 07:31
@greptile-apps

greptile-apps Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Reviews (2): Last reviewed commit: "fix(ai): preserve processor public API" | Re-trigger Greptile

Comment thread posthog/ai/claude_agent_sdk/processor.py
@marandaneto
marandaneto merged commit 183ec06 into main Aug 25, 2026
43 checks passed
@marandaneto
marandaneto deleted the refactor/ai-processor-policy branch August 25, 2026 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants