refactor(ai): share processor privacy and capture policy - #884
Merged
Conversation
Contributor
posthog-python Compliance ReportDate: 2026-08-25 07:33:03 UTC ✅ All Tests Passed!111/111 tests passed Capture_V1 Tests✅ 94/94 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
marandaneto
marked this pull request as ready for review
August 22, 2026 06:51
Contributor
|
Reviews (1): Last reviewed commit: "refactor(ai): share processor capture po..." | Re-trigger Greptile |
marandaneto
marked this pull request as draft
August 22, 2026 07:11
Member
Author
|
This PR is part of a trial using Slopo to identify high-value code duplication for targeted refactoring. |
marandaneto
marked this pull request as ready for review
August 22, 2026 07:29
Contributor
|
Reviews (2): Last reviewed commit: "fix(ai): preserve processor public API" | Re-trigger Greptile |
turnipdabeets
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
The Claude Agent SDK and OpenAI Agents processors duplicated privacy redaction and event capture policy. Privacy handling is security-sensitive, and changes could drift between processors.
This change shares privacy handling for duck-typed clients. It also centralizes common property merging, capture capability checks, identity fallback, event submission, and error handling while preserving existing behavior. In particular, a per-call privacy setting can enable redaction but cannot disable processor-level or client-level privacy.
💚 How did you test it?
uv run pytest --verbose --timeout=30 posthog/test/ai/claude_agent_sdk posthog/test/ai/openai_agents: 99 passedmake public_api_checkorigin/main: clean📝 Checklist
If releasing new changes
sampo addto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Pi and Slopo identified the shared privacy and capture policy. The implementation keeps Claude per-call privacy and groups handling separate where they differ. Review feedback identified an unintended privacy-precedence change, which was corrected with regression coverage before the branch was updated.