test: harden snapshot User-Agent normalization - #877
Open
dustinbyrne wants to merge 1 commit into
Open
Conversation
Contributor
|
Reviews (1): Last reviewed commit: "test: harden snapshot User-Agent normali..." | Re-trigger Greptile |
Contributor
posthog-python Compliance ReportDate: 2026-08-18 20:48:09 UTC ✅ All Tests Passed!111/111 tests passed Capture_V1 Tests✅ 94/94 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Release-dependent SDK versions can make otherwise-correct server payload snapshots fail after a release. This hardens snapshot normalization so expected
posthog-python/<version>User-Agent values are stable while malformed or unrelated values remain snapshot-visible.This prevents false-negative snapshots without release-version churn and does not change runtime behavior.
💚 How did you test it?
uv run pytest --verbose --timeout=30 posthog/test/test_server_payload_snapshots.py(10 passed)uv run ruff format --check posthog/test/test_server_payload_snapshots.pyuv run ruff check posthog/test/test_server_payload_snapshots.pygit diff --check📝 Checklist
If releasing new changes
sampo addto generate a changeset fileThis is test-only, so no Sampo changeset is required.
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Implemented with the Pi coding agent in a human-directed session; no shareable session URL is available. The final review identified that the initial User-Agent matcher accepted non-token HTTP product versions, so it was tightened to the RFC token character set and covered with malformed-version cases before submission.