Repository navigation
feat: expose Android push capture options - #101
Merged
Merged
Conversation
turnipdabeets
approved these changes
Oct 20, 2026
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Closes #100.
KMP apps cannot disable Android's automatic push-token registration or push-open capture, even when another provider owns push delivery.
capturePushNotificationSubscriptionsandcapturePushNotificationOpenedinPostHogConfigand forward them independently before Android setup.true. These options affect Android only, with no change to current default capture behavior.copy, and deprecatedapiKeyfactory signatures for JVM binary and Java source compatibility. Compatibility copies preserve the new options.💚 How did you test it?
Using JDK 17 and the local Android SDK:
./gradlew :posthog-kmp:jvmTest :posthog-kmp:testAndroidHostTest :posthog-kmp:compileKotlinJs :posthog-kmp:compileKotlinWasmJs— passed, 69 JVM tests and 51 Android host tests../gradlew detekt— passed../gradlew :posthog-kmp:compileKotlinIosArm64— passed.apiKeyform. Java tests compile and exercise the existing constructor, factory, and copy signatures.📝 Checklist
If releasing new changes
pnpm changeto generate a change intent file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Implemented with Pi using file, shell, and GitHub CLI tools, plus a fresh read-only reviewer. The review identified Java source visibility in the compatibility overloads. The final overloads remain Java-callable, with regression tests. Human review is required.