Repository navigation
feat: Show warning if identifying with "distinct_id" - #918
Merged
Merged
Conversation
pauldambra
reviewed
Dec 4, 2023
| } | ||
|
|
||
| if (isDistinctIdStringLike(new_distinct_id)) { | ||
| logger.critical( |
Member
There was a problem hiding this comment.
#lazyweb does the logger critical show even with debug false?
Contributor
Author
There was a problem hiding this comment.
Indeed. Figured it was "critical" in the sense that I want people to see the error even if they don't have debug mode on
pauldambra
approved these changes
Dec 4, 2023
Contributor
|
Size Change: +889 B (0%) Total Size: 745 kB
ℹ️ View Unchanged
|
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Came across enough cases of this in support that I figured it was worth making this not possible. We document all over the place "distinct_id" and many people for sure just copy and paste...
Checklist