Repository navigation
fix(browser): clear persisted featureFlags group properties on resetGroups (#5673) - #5749
Open
VaibhavBajpaij wants to merge 1 commit into
Open
VaibhavBajpaij wants to merge 1 commit into
VaibhavBajpaij wants to merge 1 commit into
Conversation
…roups In experimental @posthog/browser, analytics.resetGroups() cleared group membership but left persisted group properties used for flag evaluation in extensionData['featureFlags']['$stored_group_properties'] when the flags product was absent. Ensure resetGroups() durably clears $stored_group_properties from the featureFlags extensionData namespace in Core state, so group-only reset consistently removes both memberships and group property overrides independently of whether the flags extension is installed. Fixes PostHog#5673 Signed-off-by: Vaibhav Bajpai <bajpaivaibhav2005@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5673. Follow-up to #5655.
In experimental
@posthog/browser,analytics.resetGroups()cleared group membership but retained persisted group properties used for flag evaluation ($stored_group_propertiesinthis._state.extensionData['featureFlags']) when the flags product is absent. If a later client installed flags, that retained context would be sent again.Changes
packages/browser-next/src/state.ts, updatedBrowserState.resetGroups()to durably remove$stored_group_propertiesfrom thefeatureFlagsextension storage namespace during group reset.packages/browser-next/tests/identity-helpers.spec.tsverifying that persisted$stored_group_propertiesare cleared onresetGroups()and stay cleared across storage reloads.