Skip to content

fix: remove warning of duplicate nextjs import - #566

Merged
lharries merged 2 commits into
masterfrom
luke/reactjs-load
Mar 8, 2023
Merged

lharries merged 2 commits into
masterfrom
luke/reactjs-load

Conversation

@lharries

@lharries lharries commented Mar 6, 2023

Copy link
Copy Markdown
Contributor

Removes warning of duplicate posthog import, as this occurs normally when using react strict mode

@lharries
lharries requested a review from pauldambra March 6, 2023 09:15
@lharries
lharries marked this pull request as draft March 6, 2023 09:16
@github-actions

github-actions Bot commented Mar 6, 2023 •

Copy link
Copy Markdown
Contributor

Size Change: 0 B

Total Size: 2.28 MB

ℹ️ View Unchanged
Filename Size
dist/array.full.js 152 kB
dist/array.js 93.6 kB
dist/es.js 93.4 kB
dist/module.js 93.7 kB
dist/recorder-v2.js 92.5 kB
dist/recorder.js 58.3 kB
lib/rrweb/dist/plugins/console-record.js 26.6 kB
lib/rrweb/dist/plugins/console-record.min.js 10.8 kB
lib/rrweb/dist/plugins/console-replay.js 12.7 kB
lib/rrweb/dist/plugins/console-replay.min.js 5.72 kB
lib/rrweb/dist/plugins/sequential-id-record.js 910 B
lib/rrweb/dist/plugins/sequential-id-record.min.js 417 B
lib/rrweb/dist/plugins/sequential-id-replay.js 1.24 kB
lib/rrweb/dist/plugins/sequential-id-replay.min.js 578 B
lib/rrweb/dist/record/rrweb-record-pack.js 31.4 kB
lib/rrweb/dist/record/rrweb-record-pack.min.js 10.7 kB
lib/rrweb/dist/record/rrweb-record.js 140 kB
lib/rrweb/dist/record/rrweb-record.min.js 51.7 kB
lib/rrweb/dist/replay/rrweb-replay-unpack.js 188 kB
lib/rrweb/dist/replay/rrweb-replay-unpack.min.js 71.1 kB
lib/rrweb/dist/replay/rrweb-replay.js 172 kB
lib/rrweb/dist/replay/rrweb-replay.min.js 66.4 kB
lib/rrweb/dist/rrweb-all.js 356 kB
lib/rrweb/dist/rrweb-all.min.js 133 kB
lib/rrweb/dist/rrweb.js 302 kB
lib/rrweb/dist/rrweb.min.js 116 kB
lib/rrweb/es/rrweb/ext/base64-arraybuffer/dist/base64-arraybuffer.es5.js 1.94 kB
lib/rrweb/es/rrweb/ext/mitt/dist/mitt.es.js 1.99 kB

compressed-size-action

@lharries

lharries commented Mar 6, 2023

Copy link
Copy Markdown
Contributor Author

@pauldambra any thoughts on whether we should keep the "return" or not? I'd suggest we default to yes as it's working with it and no need to re-initialized PostHog. I also wouldn't be expect people to be initiating the provider multiple types with different variables.

@lharries
lharries marked this pull request as ready for review March 6, 2023 09:24

@pauldambra pauldambra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants