Repository navigation
docs: require signed commits in contributor docs - #5394
Merged
Merged
Conversation
Contributors often open PRs with unsigned commits because signing isn't documented here.
Contributor
📝 No Changeset FoundThis PR doesn't include a changeset. A changeset is required to release a new version. How to add a changesetRun this command and follow the prompts: pnpm changesetRemember: Never use |
turnipdabeets
marked this pull request as ready for review
October 22, 2026 22:17
This was referenced Oct 22, 2026
turnipdabeets
enabled auto-merge
October 22, 2026 22:20
Contributor
Coherence4 spec problems · 0 failing chokepoints · 2 spec gaps · 0 guard failures 44 components, 7 bullets (5 invariants, 2 requirements), 4 problems Spec problems (spec --check)
Chokepoints: none declared. Spec gaps: 2 entrances with outside or unknown trust and no traced control, and 10 more held by the adoption baseline
Close one with |
marandaneto
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
mainrequires signed commits, but nothing in this repo's contributor docs says so. Contributors, especially first-timers and agent-driven ones, keep opening PRs with unsigned commits. Maintainers then have to ask for re-signing or re-sign the commits themselves before merging. Example: #5353, #5355 and #5393 from the same contributor. They signed one commit by hand after being asked, but their next commits were unsigned again because signing isn't on in their git config.posthog-python already has a "Commit signing" section in its
CONTRIBUTING.md. This PR brings the same section to posthog-js.Changes
CONTRIBUTING.md: new "Commit signing" section linking to the handbook guide. It tells contributors to setcommit.gpgsigntotrueso signing persists.AGENTS.md: one line telling agents to sign every commit in the git config they commit with.Docs only, so there's no changeset.
Release info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset fileTest plan
oxfmt --checkpasses on the three changed files.#commit-signingexists.🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Claude Code (Opus) drafted this while looking into why a contributor's PRs kept arriving unsigned. The wording mirrors posthog-python's existing section. The plan is to port the same change to the other SDK repos once this one is agreed. A CI check that fails unsigned fork PRs early was considered, but it's left for a separate change.
🤖 Generated with Claude Code