Repository navigation
Rename apiKey to projectToken with aliases - #573
Merged
Merged
Conversation
Contributor
posthog-ios Compliance ReportDate: 2026-04-23 13:35:12 UTC
|
| Test | Status | Duration |
|---|---|---|
| Request Payload.Request With Person Properties Device Id | ❌ | 166ms |
Failures
request_payload.request_with_person_properties_device_id
404, message='Not Found', url='http://host.docker.internal:8080/get_feature_flag'
marandaneto
commented
Apr 23, 2026
marandaneto
marked this pull request as ready for review
April 23, 2026 12:58
turnipdabeets
approved these changes
Apr 23, 2026
marandaneto
commented
Apr 23, 2026
| } | ||
|
|
||
| let sessionId = resumeCurrent | ||
| guard (resumeCurrent |
Member
Author
There was a problem hiding this comment.
fixing build warning:
removed unused sessionId binding by guarding on presence directly
marandaneto
commented
Apr 23, 2026
| boolValue = PostHogSDK.shared.isFeatureEnabled("4535-funnel-bar-viz") | ||
| stringValue = PostHogSDK.shared.getFeatureFlag("multivariant") as? String | ||
| payloadValue = PostHogSDK.shared.getFeatureFlagPayload("multivariant") as? [String: String] | ||
| payloadValue = PostHogSDK.shared.getFeatureFlagResult("multivariant")?.payload as? [String: String] |
Member
Author
There was a problem hiding this comment.
fixed build warnings
marandaneto
commented
Apr 23, 2026
| // This will throw an NSInvalidArgumentException | ||
| NSMutableArray *mutableArray = [[NSMutableArray alloc] init]; | ||
| [mutableArray insertObject:nil atIndex:0]; // Inserting nil object | ||
| #pragma clang diagnostic push |
Member
Author
There was a problem hiding this comment.
fixed build warnings
ioannisj
approved these changes
Apr 23, 2026
ioannisj
left a comment
ioannisj
left a comment
Contributor
There was a problem hiding this comment.
LG, looked at public api changes and I think everything is covered
eareyereading
pushed a commit
to eareyereading/posthog-ios
that referenced
this pull request
May 6, 2026
Merged
5 of 9 tasks
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
The iOS SDK still uses
apiKeyas the public name for the project credential. This draft updates the public surface to preferprojectToken, while keepingapiKeyworking as a backwards-compatible alias.It also improves the runtime messaging around the old name by:
apiKeyis used💚 How did you test it?
PostHogConfigTestto cover the newprojectTokensurface and the deprecatedapiKeyalias.📝 Checklist
If releasing new changes
pnpm changesetto generate a changeset filereleaselabel to the PR