feat(surveys): support survey popup delay by adboio · Pull Request #520 · PostHog/posthog-ios

adboio · 2026-03-10T23:51:59Z

💡 Motivation and Context

ios does not support survey popup delay

closes #499

💚 How did you test it?

unit test / manual testing

📝 Checklist

I reviewed the submitted code.
I added tests to verify the changes.
I updated the docs if needed.
No breaking change or entry added to the changelog.

If releasing new changes

Ran pnpm changeset to generate a changeset file
Added the release label to the PR

adboio · 2026-03-10T23:52:12Z

feat(surveys): support survey popup delay #520 👈 (View in Graphite)
feat(surveys): support event property filters #519
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2026-03-11T00:08:48Z

posthog-ios Compliance Report

Date: 2026-04-15 14:33:20 UTC
Duration: 2993ms

⚠️ Some Tests Failed

0/1 tests passed, 1 failed

Feature_Flags Tests

⚠️ 0/1 tests passed, 1 failed

View Details

Test	Status	Duration
Request Payload.Request With Person Properties Device Id	❌	396ms

Failures

request_payload.request_with_person_properties_device_id

404, message='Not Found', url='http://host.docker.internal:8080/get_feature_flag'

marandaneto · 2026-03-24T11:36:43Z

@adboio @ioannisj what is missing here? no reviews and still draft

ioannisj · 2026-04-07T17:20:15Z

+            ]
+
+            let sorted = surveys.sorted {
+                ($0.appearance?.surveyPopupDelaySeconds ?? 0) < ($1.appearance?.surveyPopupDelaySeconds ?? 0)


nit: I think this could be flaky cause .sorted is not guaranteed to be stable for equal keys I think. Maybe add tie-breaker as well or remove the scenario where there are equal keys (no-delay and delayed-0)

Also, this just duplicates production code, so if we change sorting at some point, this will still pass. I think we just need to test what getActiveMatchingSurveys returns instead

On first point above, actually it seems that it's guaranteed, so never mind

https://developer.apple.com/documentation/swift/array/sorted()

The sorting algorithm is guaranteed to be stable. A stable sort preserves the relative order of elements that compare as equal.

ioannisj · 2026-04-07T17:30:51Z

+                        let delay = survey.appearance?.surveyPopupDelaySeconds ?? 0
+                        let deadline: DispatchTime = delay > 0 ? .now() + delay : .now()


I think this may be a bit unecessary and just adds noise. We could just do this?

Suggested change

let delay = survey.appearance?.surveyPopupDelaySeconds ?? 0

let deadline: DispatchTime = delay > 0 ? .now() + delay : .now()

let delay = max(survey.appearance?.surveyPopupDelaySeconds ?? 0, 0)

let deadline: DispatchTime = .now() + delay

ioannisj · 2026-04-07T17:37:13Z

+                    let sortedSurveys = activeSurveys.sorted {
+                        ($0.appearance?.surveyPopupDelaySeconds ?? 0) < ($1.appearance?.surveyPopupDelaySeconds ?? 0)
+                    }


Does web sdk behave similar to this? This feels like the wrong approach to me cause it changes the whole survey selection behavior, right? Now surveys with a smaller delay are given display priority, whereas before, selection was simply by first(where:) to a list returned by the server/config

I feel that the delay should actually be handled in the UI layer, in PostHogSurveysDefaultDelegate where the delegate will delay the presentation of a survey (and handle the dismissal scenario before delay like we do in L302) after the survey has been selected by getActiveMatchingSurveys()

Yes, looks like js SDK is performing this delay logic in display layer in handlePopoverSurvey

github-actions · 2026-04-15T10:00:03Z

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

ioannisj · 2026-04-15T13:34:10Z

@PostHog/team-client-libraries pushed some changes if you can please review?

adboio mentioned this pull request Mar 10, 2026

feat(surveys): support event property filters #519

Merged

6 tasks done

adboio added the release label Mar 10, 2026 — with Graphite App

adboio requested a review from a team March 10, 2026 23:52

adboio force-pushed the 03-10-feat_surveys_support_survey_popup_delay branch 2 times, most recently from 8caa460 to eaaf956 Compare March 11, 2026 18:21

adboio force-pushed the 03-10-feat_surveys_support_event_property_filters branch from a334421 to 81c5433 Compare March 11, 2026 18:21

adboio changed the base branch from 03-10-feat_surveys_support_event_property_filters to graphite-base/520 March 11, 2026 19:32

adboio force-pushed the graphite-base/520 branch from 81c5433 to a9366ad Compare March 11, 2026 19:32

adboio force-pushed the 03-10-feat_surveys_support_survey_popup_delay branch from eaaf956 to b7c6843 Compare March 11, 2026 19:32

graphite-app Bot changed the base branch from graphite-base/520 to main March 11, 2026 19:32

adboio force-pushed the 03-10-feat_surveys_support_survey_popup_delay branch from b7c6843 to 268e6e5 Compare March 11, 2026 19:32

feat(surveys): support survey popup delay

9e7acb3

adboio force-pushed the 03-10-feat_surveys_support_survey_popup_delay branch from 268e6e5 to 9e7acb3 Compare March 12, 2026 17:27

marandaneto closed this Mar 24, 2026

marandaneto reopened this Mar 24, 2026

ioannisj marked this pull request as ready for review April 7, 2026 17:06

Merge branch 'main' into 03-10-feat_surveys_support_survey_popup_delay

9edddd6

ioannisj reviewed Apr 7, 2026

View reviewed changes

github-actions Bot added the stale label Apr 15, 2026

ioannisj added 5 commits April 15, 2026 14:19

fix: revert changes on survey integration

775460f

feat: add delay logic in display delegate

4393afd

fix: format

fc88071

fix: revert tests

055e430

fix: add tests

09805ce

ioannisj requested review from a team and ioannisj April 15, 2026 13:33

ioannisj removed their request for review April 15, 2026 13:33

ioannisj removed the stale label Apr 15, 2026

Merge branch 'main' into 03-10-feat_surveys_support_survey_popup_delay

a1cfd0a

marandaneto approved these changes Apr 15, 2026

View reviewed changes

ioannisj merged commit feeaeac into main Apr 17, 2026
32 checks passed

ioannisj deleted the 03-10-feat_surveys_support_survey_popup_delay branch April 17, 2026 07:39

ioannisj temporarily deployed to Release April 17, 2026 07:40 — with GitHub Actions Inactive

ioannisj mentioned this pull request Apr 20, 2026

chore(docs): update survey docs on ios popup delay PostHog/posthog#55335

Merged

turnipdabeets mentioned this pull request Nov 9, 2026

fix(surveys): start the wait period on show and ignore closes before display #1049

Merged

6 tasks done

Navigation Menu

Repository navigation

feat(surveys): support survey popup delay - #520

feat(surveys): support survey popup delay#520
ioannisj merged 8 commits into
mainfrom
03-10-feat_surveys_support_survey_popup_delay

adboio commented Mar 10, 2026 •

edited

Loading

Uh oh!

adboio commented Mar 10, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Mar 11, 2026 •

edited

Loading

Failures

Uh oh!

marandaneto commented Mar 24, 2026

Uh oh!

ioannisj Apr 7, 2026

Uh oh!

ioannisj Apr 7, 2026

Uh oh!

ioannisj Apr 7, 2026

Uh oh!

ioannisj Apr 7, 2026 •

edited

Loading

Uh oh!

ioannisj Apr 8, 2026

Uh oh!

github-actions Bot commented Apr 15, 2026

Uh oh!

ioannisj commented Apr 15, 2026 •

edited

Loading

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		let delay = survey.appearance?.surveyPopupDelaySeconds ?? 0
		let deadline: DispatchTime = delay > 0 ? .now() + delay : .now()

Conversation

adboio commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

If releasing new changes

Uh oh!

adboio commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

posthog-ios Compliance Report

⚠️ Some Tests Failed

Feature_Flags Tests

Failures

Uh oh!

marandaneto commented Mar 24, 2026

Uh oh!

ioannisj Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

ioannisj Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

ioannisj Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

ioannisj Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ioannisj Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 15, 2026

Uh oh!

ioannisj commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

adboio commented Mar 10, 2026 •

edited

Loading

adboio commented Mar 10, 2026 •

edited

Loading

github-actions Bot commented Mar 11, 2026 •

edited

Loading

ioannisj Apr 7, 2026 •

edited

Loading

ioannisj commented Apr 15, 2026 •

edited

Loading