Repository navigation
chore: feature flag resiliency - #38
Merged
Merged
Conversation
Contributor
|
should we add tests for this? (asking for android too) |
Contributor
Author
|
Good point, the no-replacement on error yes I would say so. For timeouts idts |
neilkakkar
reviewed
Feb 7, 2023
| NSLog(@"%@",json); | ||
| success(json); | ||
| NSInteger code = ((NSHTTPURLResponse *)response).statusCode; | ||
| if (code < 300) { |
Contributor
There was a problem hiding this comment.
can this be anything other than 200?
Contributor
Author
There was a problem hiding this comment.
Do you mean based on what we send?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
What are the relevant tickets?
Screenshots or screencasts (if UI/UX change)
Questions: