Skip to content

fix: Allow for optional setting of key values #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EDsCODE merged 2 commits into from
Feb 2, 2023
Merged

fix: Allow for optional setting of key values #36

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65725f3
allow for optional setting of key values
EDsCODE Feb 1, 2023
261dbea
generate anon id if nil
EDsCODE Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions PostHog/Classes/PHGPayloadManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,10 +180,10 @@ - (void)reloadFeatureFlags
{
NSMutableDictionary *payload = [[NSMutableDictionary alloc] init];
// TODO: handle IDs
[payload setObject:[self getAnonymousId] forKey:@"$anon_distinct_id"];
[payload setObject:self.integration.distinctId ? self.integration.distinctId : [self getAnonymousId] forKey:@"distinct_id"];
[payload setObject:[self getGroups] forKey:@"$groups"];
[payload setObject:self.posthog.configuration.apiKey forKey:@"api_key"];
[payload setValue:[self getAnonymousId] forKey:@"$anon_distinct_id"];
Comment thread
benjackwhite marked this conversation as resolved.
Resolved
[payload setValue:self.integration.distinctId ? self.integration.distinctId : [self getAnonymousId] forKey:@"distinct_id"];
[payload setValue:[self getGroups] forKey:@"$groups"];
[payload setValue:self.posthog.configuration.apiKey forKey:@"api_key"];

NSURL *url = [self.posthog.configuration.host URLByAppendingPathComponent:@"decide"];
NSString *absoluteUrl = [url absoluteString];
Expand Down Expand Up @@ -255,6 +255,9 @@ - (void)resetAnonymousId

- (NSString *)getAnonymousId;
{
if (self.cachedAnonymousId == nil) {
[self resetAnonymousId];
}
return self.cachedAnonymousId;
}

Expand Down