Skip to content

Update alias doc strings - #34

Closed
lharries wants to merge 1 commit into
masterfrom
lharries-patch-1
Closed

lharries wants to merge 1 commit into
masterfrom
lharries-patch-1

Conversation

@lharries

Copy link
Copy Markdown

What does this PR do?

Update the alias doc string to match how aliasing actually works. It was implying the wrong order


@param alias The new ID you want to alias the existing ID to. The existing ID will be either the
previousId if you have called identify, or the anonymous ID.
@param alias The alias ID that you want to attach to the user

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's be more clear here - this needs to be the anonymous ID (that hasn't been merged with anything else). Please see https://posthog.com/docs/integrate/server/node#alias for example. what "alias ID" is is not clear.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize this was the case, I've asked a question here: PostHog/posthog-python#82 (comment)

@marandaneto

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants