Repository navigation
Conversation
this allows clients to delay checking for feature flags until they've loaded.
benjackwhite
self-requested a review
January 25, 2023 18:00
Contributor
|
Just noticed this (we had few eyes on this repo as Christmas approached and passed). I'm working on this SDK atm so will check this out ASAP and get it in as it looks good at a glance 👍 |
benjackwhite
approved these changes
Mar 22, 2023
Member
|
Closed because of the new major version that should have addressed this use case (via callback and/or notification) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Big fan, first time caller. I'm starting to use PostHog's experiments, and wanted an easy way to know which group users fell into. In my testing, all users were
controlat launch, and then were assigned to their groups some time later as data is fetched from the server.What does this PR do?
Allows clients to delay checking for feature flags until they've loaded, as well as listen for relevant updates.
I tried to fit in with the current style of the project, but am glad to make any stylistic changes.
Where should the reviewer start?
How should this be manually tested?
On launch, or after calling
reloadFeatureFlags, clients should expect thePHGPostHogFeatureFlagsDidLoadNotification.Any background context you want to provide?
Questions:
PHGPostHogIntegrationDidStartnotification to better match, for example providing aNotificationsuffix so the compiler automatically creates an NSNotification.Name for us.What are the relevant tickets?
Screenshots or screencasts (if UI/UX change)
Questions:
Perhaps—if you all agree with the change, it would be useful to let clients know to listen.