Repository navigation
Conversation
* feat: support multivariate flag checking * send capture call * Persistence of feature flags and groups (#31) * feat: make sure groups and feature flags and persisted and sent * remove deprecated key
EDsCODE
marked this pull request as ready for review
July 25, 2022 18:40
liyiy
reviewed
Jul 25, 2022
| @interface PHGSession () | ||
|
|
||
| @property (nonatomic, copy) NSString *sessionId; | ||
| @property (nonatomic) NSTimeInterval sessionStartTimestamp; |
Contributor
There was a problem hiding this comment.
i'm calling this a sessionLastTimestamp here instead to align with https://github.com/PostHog/posthog-js-lite/pull/4/files#diff-30dde81fd76ff386b3bde594b35a527f3bac4438ed7ef3183ed03ab756b4c562R34, shall we consolidate to that naming?
liyiy
reviewed
Jul 26, 2022
|
|
||
| @interface PHGSession () | ||
|
|
||
| @property (nonatomic, copy) NSString *sessionId; |
Contributor
There was a problem hiding this comment.
will these values persist across app restarts? 🤔
Contributor
|
I think we're also missing a |
neilkakkar
requested review from
benjackwhite
and removed request for
rcmarron
October 13, 2022 14:25
Contributor
|
Adding Ben just for sess-rec awareness |
Contributor
|
Happy to add a review but not sure it has much impact on sesh-rec world...? |
Contributor
|
D'oh, right, you wouldn't need this at all, since no session recordings on mobile 🤦 |
neilkakkar
approved these changes
Oct 13, 2022
neilkakkar
left a comment
neilkakkar
left a comment
Contributor
There was a problem hiding this comment.
Looks good, judging by the tests! (no swift-fu here 😅 )
benjackwhite
approved these changes
Oct 13, 2022
Closed
Member
|
Closed in favor of #100 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
What are the relevant tickets?
Screenshots or screencasts (if UI/UX change)
Questions: