Repository navigation
fix: read accessibilityLabel from parent's view to avoid performance hit on RN - #259
Merged
Merged
Conversation
marandaneto
marked this pull request as ready for review
November 20, 2024 08:28
marandaneto
changed the title
This was referenced Nov 25, 2024
eakurnikov
pushed a commit
to trustwallet/posthog-ios
that referenced
this pull request
Feb 6, 2025
…hit on RN (PostHog#259) * fix: read accessibilityLabel from parent's view to avoid performance hit on RN * fix
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
we dont need the parent's accessibilityLabel/concatenated with all the children if any
avoid recursive and endless function
💚 How did you test it?
running on RN and native iOS app with UIKit
Fix is not breaking compatibility
📝 Checklist