Repository navigation
Swift package management work - #10
Merged
Merged
Conversation
Member
Author
|
I did this over break and thought I had put up a PR for it. I use my forked library on a toy app I also built over break. Works great! |
Contributor
|
If it works great, then I have no problem merging! :) |
Contributor
|
I am getting errors like this when I try to publish the package though: Can you explain what's the case with changing the paths? I could fix those errors, but will it mess something up for swift? |
Merged
Contributor
|
So I reverted the imports, hoping that won't mess up anything, and released 1.2.2 (, and used the oxford comma). |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a few bugs that kept swift package management fail
Where should the reviewer start?
In the files that changed ;)
Give it a try. Try to add this branch as a dep using swift package management from xcode.
How should this be manually tested?
Try to add this branch as a dep using swift package management from xcode.
Any background context you want to provide?
Swift package management is quickly becoming the future of managing deps in apple development. Good to enable this for our ios users.
What are the relevant tickets?
#1
Screenshots or screencasts (if UI/UX change)
Questions:
Does the docs need an update?
Only slightly
Are there any security concerns?
None