Repository navigation
fix: exclude failed Dart flag values on Windows and Linux - #721
Merged
Merged
Conversation
Contributor
posthog-flutter Compliance ReportDate: 2026-11-12 10:31:08 UTC ✅ All Tests Passed!45/45 tests passed Capture Tests✅ 29/29 tests passed View Details
Feature_Flags Tests✅ 16/16 tests passed View Details
|
marandaneto
marked this pull request as ready for review
November 12, 2026 12:13
PR overviewNo security issues were found in this pull request. Reviews
|
ioannisj
approved these changes
Nov 12, 2026
ioannisj
left a comment
Contributor
There was a problem hiding this comment.
🤖 An AI agent wrote this on behalf of @ioannisj.
No findings. I traced the failed details through the getters, bulk results, listener and capture enrichment, and the errored-refresh merge and evaluation_failed reporting line up with the spec.
6 of 17 tasks
turnipdabeets
added a commit
that referenced
this pull request
Nov 13, 2026
#721's failed-flags test answered every request with a /flags body, which the capture v1 sender reads as a 2xx without per-event results. Answer only /flags with it so capture gets its default results. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
On Windows and Linux, the Dart implementation could serve a failed feature flag's placeholder value or payload and report it as a missing flag. This patch applies the failed-record rules in PostHog/sdk-specs#211 to the Windows/Linux Dart implementation only.
Failed records now return no scalar, boolean, or structured result. Bulk results, listeners, and capture enrichment omit them. Failed direct reads report
evaluation_failedwith a null response and retain response-wide errors independently. An errored refresh preserves successful cached values and paired payloads. A complete refresh without response-wide errors replaces state instead.Includes a patch changeset. Dependency constraints are unchanged. Android, iOS/macOS, and web still require fixed upstream engine releases and follow-up dependency or host-JS updates. This PR does not claim native/web or full shared-harness conformance.
💚 How did you test it?
📝 Checklist
If releasing new changes
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Pi agents implemented and independently reviewed the scoped fix. Publication used Git, GitHub CLI, Flutter/Dart checks, and the isolated autoreview helper. No shareable session URL is available. The human driver is assigned as the DRI. Human review is required.
The native/web dependency updates were deliberately left out because unpublished engine fixes are not consumable version pins. Existing cache refresh boundaries and event controls were preserved rather than adding new APIs or changing dependencies.