Repository navigation

`device_type` on iOS isn't changeable - should it be? #49

Closed

Labels

documentationiOSquestion

opened

on Sep 25, 2023

https://github.com/PostHog/posthog-ios/blob/d3eeb3b60bd54b5cb87299c40378118e642a4474/PostHog/Internal/PHGPostHogIntegration.m#L145

Questions:

should device_type be changeable?
should device_type be mobile by default?
is the device_type -> android for Android? I have not found any references to this field on this SDK and on the Android SDK, so apparently this field isn't set at all (checked the latest version).

Docs:
https://posthog.com/docs/product-analytics/autocapture#autocaptured-properties
https://posthog.com/docs/product-analytics/user-properties

single source of truth: https://github.com/PostHog/posthog/blob/master/frontend/src/lib/taxonomy.tsx
Ticket

marandaneto
added
iOS

bugSomething isn't working

documentationImprovements or additions to documentation

questionFurther information is requested
and removed
bugSomething isn't working
on Sep 25, 2023
marandaneto commented on Sep 29, 2023
marandaneto
on Sep 29, 2023
MemberAuthor
Similar to PostHog/posthog-ios#63
marandaneto commented on Oct 5, 2023
marandaneto
on Oct 5, 2023
MemberAuthor
We should follow the convention, we'll merge the PR to align on iOS.
The new Android SDK already sets it to Mobile as well.
There are other fields to filter per Android/iOS, such as $os_name
marandaneto commented on Oct 9, 2023
marandaneto
on Oct 9, 2023
MemberAuthor
https://github.com/PostHog/posthog-ios/releases/tag/2.0.5 updates the device_type to `Mobile.
Just upgrade your cocoapods dependencies.
marandaneto
closed this as completed on Oct 9, 2023

to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

Labels

documentationiOSquestion

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests